CHANGES

Added variables.tf.
Updated README with instructions to change values in variables.tf instead of lambda handler.py and main.tf.
Updated README to exclude instruction for manually compressing lambda handler.
Updated main.tf to use bucket name and AWS region from variables.tf, and also include environment variables for Lambda function.
Updated handler.py to reference environments variables for AWS region and bucket name.

Author: sidd130

sqs-lambda-s3-terraform-python/README.md

@@ -29,51 +29,21 @@ Learn more about this pattern at Serverless Land Patterns: [SQS to Lambda to S3]
     ```
     cd sqs-lambda-s3-terraform-python
     ```
-1. Pick a unique name for the target S3 bucket eg. `my-bucket-20250329`. Replace the bucket name in following files:
-
-    * Lambda handler - `handler.py`
-        
-        ```
-        resp = s3_client.put_object(
-            Body=str(request_body).encode(encoding="utf-8"),
-            Bucket='my-bucket-20250329',
-            Key=file_name
-        )
-        ```
-    * Terraform configuration - `main.tf`
-        
-        ```
-        # S3 bucket
-        resource "aws_s3_bucket" "event-storage" {
-            bucket        = "my-bucket-20250329"
-            force_destroy = true
-            tags = {
-                Name = "event-storage"
-            }
-        }
-        ```
-1. Update the AWS region in the following files with the region, in which the resources will be created:
-
-    * Lambda handler - `handler.py`
-        
-        ```
-        config = Config(region_name='ap-south-1')
-        ```
-    * Terraform configuration - `main.tf`
-        
-        ```
-        provider "aws" {
-            region = "ap-south-1"
-        }
-        ```
-
-1. Compress the lambda handler to generate a zip file:
-    
+
+1. Pick a unique name for the target S3 bucket eg. `my-bucket-20250329`. Replace the bucket name and AWS region in `variables.tf`:
+
     ```
-    cp handler.py handler_1.py
-    gzip -S .zip handler.py
-    mv handler.py.zip sqs-lambda-s3.zip
-    mv handler_1.py handler.py
+    variable aws_region_name {
+        type = string
+        default = "ap-south-1"
+        description = "AWS Region"
+    }
+
+    variable "s3_bucket_name" {
+        type = string
+        default = "my-bucket-20250329"
+        description = "S3 Bucket name"
+    }
     ```
 
 1. Deploy the AWS resources through Terraform:
@@ -98,7 +68,7 @@ The SQS queue is configured as a trigger for the Lambda function. Whenever a mes
 
 ## Testing
 
-1. Create an IAM user which will be used for writing messages on the SQS queue
+1. Create an IAM user which will be used for writing messages on the SQS queue.
 
 2. Add persmissions for the IAM user through the following inline policy:
     

sqs-lambda-s3-terraform-python/handler.py

@@ -1,5 +1,6 @@
 import boto3
 from botocore.config import Config
+import os
 import json
 
 import boto3.s3
@@ -9,12 +10,13 @@ def lambda_handler(event, context):
     print(context)
     file_name = 'request_' + json.loads(event['Records'][0]['body'])["uniqueID"] + '.json'
     request_body = event['Records'][0]['body']
-    
-    config = Config(region_name='ap-south-1')
+    aws_region = os.getenv('AWS_REGION')
+    s3_bucket_ident = os.getenv('S3_BUCKET_NAME')
+    config = Config(region_name=aws_region)
     s3_client = boto3.client('s3',config=config)
     resp = s3_client.put_object(
         Body=str(request_body).encode(encoding="utf-8"),
-        Bucket='my-bucket-20250329',
+        Bucket=s3_bucket_ident,
         Key=file_name
     )
 

sqs-lambda-s3-terraform-python/main.tf

@@ -10,7 +10,7 @@ terraform {
 }
 
 provider "aws" {
-  region = "ap-south-1"
+  region = var.aws_region_name
 }
 
 data "archive_file" "lambda_handler_zip_file" {
@@ -27,6 +27,12 @@ resource "aws_lambda_function" "event-processor" {
   handler          = "handler.lambda_handler"
   runtime          = "python3.12"
   role             = aws_iam_role.event-processor-exec-role.arn
+  environment {
+    variables = {
+      AWS_REGION = var.aws_region_name
+      S3_BUCKET_NAME = var.s3_bucket_name
+    }
+  }
 }
 
 # Lambda execution role
@@ -149,7 +155,7 @@ resource "aws_sqs_queue_policy" "event-collector-policy" {
 
 # S3 bucket
 resource "aws_s3_bucket" "event-storage" {
-  bucket        = "my-bucket-20250329"
+  bucket        = var.s3_bucket_name
   force_destroy = true
   tags = {
     Name = "event-storage"

sqs-lambda-s3-terraform-python/variables.tf

@@ -0,0 +1,11 @@
+variable aws_region_name {
+    type = string
+    default = "ap-south-1"
+    description = "AWS Region"
+}
+
+variable "s3_bucket_name" {
+    type = string
+    default = "my-bucket-20250329"
+    description = "S3 Bucket name"
+}