Skip to content

Commit 53bda27

Browse files
tbrandtbrandaws
andauthored
Fix closed network subnet selection (#1301)
Co-authored-by: Taichiro Suzuki <taichirs@amazon.co.jp>
1 parent 6b3fbb7 commit 53bda27

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

packages/cdk/lib/construct/closedNetwork/resolver.ts

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {
55
SecurityGroup,
66
ISubnet,
77
SubnetType,
8-
SubnetFilter,
8+
Subnet,
99
} from 'aws-cdk-lib/aws-ec2';
1010
import { CfnResolverEndpoint } from 'aws-cdk-lib/aws-route53resolver';
1111
import { Construct } from 'constructs';
@@ -41,15 +41,13 @@ export class Resolver extends Construct {
4141
'DNS UDP'
4242
);
4343

44-
const subnets = props.vpc.selectSubnets(
45-
props.subnetIds
46-
? {
47-
subnetFilters: [SubnetFilter.byIds(props.subnetIds)],
48-
}
49-
: {
50-
subnetType: SubnetType.PRIVATE_ISOLATED,
51-
}
52-
).subnets;
44+
const subnets = props.subnetIds
45+
? props.subnetIds.map((subnetId) =>
46+
Subnet.fromSubnetId(this, `ResolverSubnet-${subnetId}`, subnetId)
47+
)
48+
: props.vpc.selectSubnets({
49+
subnetType: SubnetType.PRIVATE_ISOLATED,
50+
}).subnets;
5351

5452
const ipAddresses: CfnResolverEndpoint.IpAddressRequestProperty[] =
5553
subnets.map((s: ISubnet) => ({ subnetId: s.subnetId }));

0 commit comments

Comments
 (0)