Merge pull request #73 from aws-samples/sql_server

Remove 30 character password length restriction on SQL Server

Author: JoeJesse

SecretsManagerRDSSQLServerRotationMultiUser/lambda_function.py

@@ -121,7 +121,7 @@ def create_secret(service_client, arn, token):
         # Get exclude characters from environment variable
         exclude_characters = os.environ['EXCLUDE_CHARACTERS'] if 'EXCLUDE_CHARACTERS' in os.environ else '/@"\'\\'
         # Generate a random password
-        passwd = service_client.get_random_password(ExcludeCharacters=exclude_characters, PasswordLength=30)
+        passwd = service_client.get_random_password(ExcludeCharacters=exclude_characters)
         current_dict['password'] = passwd['RandomPassword']
 
         # Put the secret
@@ -667,4 +667,4 @@ def is_rds_replica_database(replica_dict, master_dict):
 
     # DB Instance identifiers are unique - can only be one result
     current_instance = instances[0]
-    return master_instance_id == current_instance.get('ReadReplicaSourceDBInstanceIdentifier')
+    return master_instance_id == current_instance.get('ReadReplicaSourceDBInstanceIdentifier')

SecretsManagerRDSSQLServerRotationSingleUser/lambda_function.py

@@ -115,7 +115,7 @@ def create_secret(service_client, arn, token):
         # Get exclude characters from environment variable
         exclude_characters = os.environ['EXCLUDE_CHARACTERS'] if 'EXCLUDE_CHARACTERS' in os.environ else '/@"\'\\'
         # Generate a random password
-        passwd = service_client.get_random_password(ExcludeCharacters=exclude_characters, PasswordLength=30)
+        passwd = service_client.get_random_password(ExcludeCharacters=exclude_characters)
         current_dict['password'] = passwd['RandomPassword']
 
         # Put the secret