Merge pull request #6 from lasred/master

Bug fix for handling uppercase username in PostgreSQL rotation lambda

Author: willtong1234

SecretsManagerRDSPostgreSQLRotationMultiUser/lambda_function.py

@@ -187,11 +187,11 @@ def set_secret(service_client, arn, token):
             # If the user exists, just update the password
             cur.execute("SELECT 1 FROM pg_roles where rolname = %s", (pending_dict['username'],))
             if len(cur.fetchall()) == 0:
-                create_role = "CREATE ROLE %s" % pending_dict['username']
+                create_role = "CREATE ROLE \"%s\"" % pending_dict['username']
                 cur.execute(create_role + " WITH LOGIN PASSWORD %s", (pending_dict['password'],))
-                cur.execute("GRANT %s TO %s" % (current_dict['username'], pending_dict['username']))
+                cur.execute("GRANT \"%s\" TO \"%s\"" % (current_dict['username'], pending_dict['username']))
             else:
-                alter_role = "ALTER USER %s" % pending_dict['username']
+                alter_role = "ALTER USER \"%s\"" % pending_dict['username']
                 cur.execute(alter_role + " WITH PASSWORD %s", (pending_dict['password'],))
 
             conn.commit()

SecretsManagerRDSPostgreSQLRotationSingleUser/lambda_function.py

@@ -169,7 +169,7 @@ def set_secret(service_client, arn, token):
     # Now set the password to the pending password
     try:
         with conn.cursor() as cur:
-            alter_role = "ALTER USER %s" % pending_dict['username']
+            alter_role = "ALTER USER \"%s\"" % pending_dict['username']
             cur.execute(alter_role + " WITH PASSWORD %s", (pending_dict['password'],))
             conn.commit()
             logger.info("setSecret: Successfully set password for user %s in PostgreSQL DB for secret arn %s." % (pending_dict['username'], arn))