chore: add Node.js 18 support (#1192)

* chore: add Node.js 18 support

* build: downgraded @middy/core to 3.x

* tests: update default runtime for e2e tests

* fix: improved log filtering logic

* chore: aws-sdk in node18 e2e tests

* tests: updated aws-sdk calls in tracer integration tests

* tests: updated aws-sdk calls in tracer integration tests

* tests: updated aws-sdk calls in tracer integration tests

Author: dreamorosi

.devcontainer/Dockerfile

@@ -1,6 +1,6 @@
 # See here for image contents: https://github.com/microsoft/vscode-dev-containers/blob/v0.212.0/containers/javascript-node/.devcontainer/base.Dockerfile
-# [Choice] Node.js version (use -bullseye variants on local arm64/Apple Silicon): 16, 14, 16-bullseye, 14-bullseye, 16-buster, 14-buster
-ARG VARIANT="16-bullseye"
+# [Choice] Node.js version (use -bullseye variants on local arm64/Apple Silicon): 18, 16, 14, 18-bullseye, 16-bullseye, 14-bullseye, 18-buster, 16-buster, 14-buster
+ARG VARIANT="18-bullseye"
 FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:0-${VARIANT}
 
 # This section to install additional OS packages.

.devcontainer/devcontainer.json

@@ -4,11 +4,11 @@
   "name": "Node.js",
   "build": {
     "dockerfile": "Dockerfile",
-    // Update 'VARIANT' to pick a Node version: 16, 14.
+    // Update 'VARIANT' to pick a Node version: 18, 16, 14.
     // Append -bullseye or -buster to pin to an OS version.
     // Use -bullseye variants on local arm64/Apple Silicon.
     "args": {
-      "VARIANT": "16-bullseye"
+      "VARIANT": "18-bullseye"
     }
   },
   // Set *default* container specific settings.json values on container create.

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -58,8 +58,9 @@ body:
     attributes:
       label: AWS Lambda function runtime
       options:
-        - 14.x
+        - 18.x
         - 16.x
+        - 14.x
     validations:
       required: true
   - type: dropdown

.github/workflows/make-release.yml

@@ -20,7 +20,7 @@ jobs:
       - name: Setup NodeJS
         uses: actions/setup-node@v3
         with:
-          node-version: "16"
+          node-version: "18"
           cache: "npm"
       - name: Setup npm
         run: |
@@ -33,7 +33,7 @@ jobs:
           path: "./node_modules"
           # Use the combo between node version, name, and SHA-256 hash of the lock file as cache key so that
           # if one of them changes the cache is invalidated/discarded
-          key: 16-cache-utils-node-modules-${{ hashFiles('./package-lock.json') }}
+          key: 18-cache-utils-node-modules-${{ hashFiles('./package-lock.json') }}
       - name: Build packages
         run: |
           npm run build -w packages/commons

.github/workflows/publish_layer.yaml

@@ -34,7 +34,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v3
         with:
-          node-version: "16.12"
+          node-version: "18"
       - name: Set release notes tag
         run: |
           RELEASE_INPUT=${{ inputs.latest_published_version }}

.github/workflows/reusable-publish-docs.yml

@@ -38,7 +38,7 @@ jobs:
       - name: Setup NodeJS
         uses: actions/setup-node@v3
         with:
-          node-version: "16"
+          node-version: "18"
           cache: "npm"
       # Use the combo between node version, name, and SHA-256 hash of the lock file as cache key so that
       # if one of them changes the cache is invalidated/discarded
@@ -47,7 +47,7 @@ jobs:
         uses: actions/cache@v3
         with:
           path: "./node_modules"
-          key: 16-cache-utils-node-modules-${{ hashFiles('./package-lock.json') }}
+          key: 18-cache-utils-node-modules-${{ hashFiles('./package-lock.json') }}
       - name: Install dependencies
         # We can skip the installation if there was a cache hit
         if: steps.cache-node-modules.outputs.cache-hit != 'true'

.github/workflows/reusable-run-linting-check-and-unit-tests.yml

@@ -10,7 +10,7 @@ jobs:
       NODE_ENV: dev
     strategy:
       matrix:
-        version: [14, 16]
+        version: [14, 16, 18]
       fail-fast: false
     steps:
       - name: Checkout code

.github/workflows/reusable_deploy_layer_stack.yml

@@ -62,7 +62,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v3
         with:
-          node-version: "16.12"
+          node-version: "18"
       - name: install cdk and deps
         run: |
           npm install -g aws-cdk@2.29.0

.github/workflows/run-e2e-tests.yml

@@ -20,7 +20,7 @@ jobs:
     strategy:
       matrix:
         package: [logger, metrics, tracer]
-        version: [14, 16]
+        version: [14, 16, 18]
       fail-fast: false
     steps:
       - name: Checkout Repo
@@ -70,7 +70,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        version: [14, 16]
+        version: [14, 16, 18]
     steps:
       - name: Checkout Repo
         uses: actions/checkout@v3
@@ -93,8 +93,8 @@ jobs:
       - name: Setup NodeJS
         uses: actions/setup-node@v3
         with:
-          # Always use version 16 as we use TypeScript target es2020
-          node-version: 16
+          # Always use version 18
+          node-version: 18
       - name: Setup npm
         run: npm i -g npm@next-8
       - name: "Configure AWS credentials"

.nvmrc

@@ -1 +1 @@
-lts/gallium
+lts/hydrogen