chore(parameters): fix SonarQube code quality issues and optimize imports (#4359)

Author: shrivarshapoojari

packages/parameters/src/appconfig/AppConfigProvider.ts

@@ -189,8 +189,8 @@ class AppConfigProvider extends BaseProvider {
     { value: string; expiration: number }
   >();
   protected valueStore = new Map<string, Uint8Array>();
-  private application?: string;
-  private environment: string;
+  private readonly application?: string;
+  private readonly environment: string;
 
   /**
    * It initializes the AppConfigProvider class.

packages/parameters/src/base/BaseProvider.ts

@@ -92,7 +92,7 @@ abstract class BaseProvider implements BaseProviderInterface {
   public async get(
     name: string,
     options?: GetOptionsInterface
-  ): Promise<unknown | undefined> {
+  ): Promise<unknown> {
     const configs = new GetOptions(options);
     const key = [name, configs.transform].toString();
 

packages/parameters/src/dynamodb/DynamoDBProvider.ts

@@ -1,13 +1,11 @@
 import type { JSONValue } from '@aws-lambda-powertools/commons/types';
-import type {
-  GetItemCommandInput,
-  QueryCommandInput,
-} from '@aws-sdk/client-dynamodb';
 import {
   DynamoDBClient,
   type DynamoDBPaginationConfiguration,
   GetItemCommand,
+  type GetItemCommandInput,
   paginateQuery,
+  type QueryCommandInput,
 } from '@aws-sdk/client-dynamodb';
 import { marshall, unmarshall } from '@aws-sdk/util-dynamodb';
 import { BaseProvider } from '../base/BaseProvider.js';

packages/parameters/src/ssm/SSMProvider.ts

@@ -821,7 +821,7 @@ class SSMProvider extends BaseProvider {
    * @param {boolean} throwOnError - Whether to throw an error if any of the parameters' retrieval throws an error or handle them gracefully
    */
   protected static handleAnyInvalidGetParameterErrors(
-    result: GetParametersCommandOutput,
+    result: Partial<GetParametersCommandOutput>,
     throwOnError: boolean
   ): string[] {
     const errors: string[] = [];
@@ -920,7 +920,7 @@ class SSMProvider extends BaseProvider {
    * @param {boolean} throwOnError - Whether to throw an error if any of the parameters' retrieval throws an error or handle them gracefully
    */
   protected transformAndCacheGetParametersResponse(
-    response: GetParametersCommandOutput,
+    response: Partial<GetParametersCommandOutput>,
     parameters: Record<string, SSMGetParametersByNameOptions>,
     throwOnError: boolean
   ): Record<string, unknown> {

packages/parameters/tests/helpers/tinyLogger.ts

@@ -13,7 +13,7 @@ import { Console } from 'node:console';
  * the function code is working as expected.
  */
 export class TinyLogger {
-  private console = new Console({
+  private readonly console: Console = new Console({
     stdout: process.stdout,
     stderr: process.stderr,
   });

packages/parameters/tests/unit/BaseProvider.test.ts

@@ -24,7 +24,7 @@ class TestProvider extends BaseProvider {
   public constructor() {
     super({
       awsSdkV3ClientPrototype: class {
-        #name = 'TestProvider';
+        readonly #name: string = 'TestProvider';
 
         public hello(): string {
           return this.#name;
@@ -412,7 +412,7 @@ describe('Class: BaseProvider', () => {
       // Act & Assess
       await expect(
         provider.getMultiple('my-path', {
-          // @ts-ignore - we want to test an unexpected runtime error
+          // @ts-expect-error - we want to test an unexpected runtime error
           transform: 1,
           throwOnTransformError: true,
         })

packages/parameters/tests/unit/SSMProvider.test.ts

@@ -1012,7 +1012,7 @@ describe('Class: SSMProvider', () => {
         throwOnError: boolean
       ): string[] {
         return SSMProvider.handleAnyInvalidGetParameterErrors(
-          result as GetParametersCommandOutput,
+          result,
           throwOnError
         );
       }
@@ -1232,7 +1232,7 @@ describe('Class: SSMProvider', () => {
         throwOnError: boolean
       ): Record<string, unknown> {
         return super.transformAndCacheGetParametersResponse(
-          response as GetParametersCommandOutput,
+          response,
           parameters,
           throwOnError
         );