improv: test validator decorator

Author: heitorlessa

aws_lambda_powertools/utilities/validation/validator.py

@@ -28,7 +28,7 @@ def validator(
 
     if outbound_schema:
         logger.debug("Validating outbound event")
-        validate_data_against_schema(data=event, schema=outbound_schema)
+        validate_data_against_schema(data=response, schema=outbound_schema)
 
     return response
 

tests/functional/validator/conftest.py

@@ -68,6 +68,23 @@ def schema_array():
     }
 
 
+@pytest.fixture
+def schema_response():
+    return {
+        "$schema": "http://json-schema.org/draft-07/schema",
+        "$id": "http://example.com/example.json",
+        "type": "object",
+        "title": "Sample outgoing schema",
+        "description": "The root schema comprises the entire JSON document.",
+        "examples": [{"statusCode": 200, "body": "response"}],
+        "required": ["statusCode", "body"],
+        "properties": {
+            "statusCode": {"$id": "#/properties/statusCode", "type": "integer", "title": "The statusCode"},
+            "body": {"$id": "#/properties/body", "type": "string", "title": "The response"},
+        },
+    }
+
+
 @pytest.fixture
 def raw_event():
     return {"message": "hello hello", "username": "blah blah"}
@@ -88,6 +105,11 @@ def wrapped_event_base64_json_string():
     return {"data": "eyJtZXNzYWdlIjogImhlbGxvIGhlbGxvIiwgInVzZXJuYW1lIjogImJsYWggYmxhaCJ9="}
 
 
+@pytest.fixture
+def raw_response():
+    return {"statusCode": 200, "body": "response"}
+
+
 @pytest.fixture
 def apigateway_event():
     return {

tests/functional/validator/test_validator.py

@@ -1,6 +1,6 @@
 import pytest
 
-from aws_lambda_powertools.utilities.validation import envelopes, exceptions, validate
+from aws_lambda_powertools.utilities.validation import envelopes, exceptions, validate, validator
 
 
 def test_validate_raw_event(schema, raw_event):
@@ -72,13 +72,34 @@ def test_cloudwatch_logs_envelope(cloudwatch_logs_schema, cloudwatch_logs_event)
     validate(event=cloudwatch_logs_event, schema=cloudwatch_logs_schema, envelope=envelopes.CLOUDWATCH_LOGS)
 
 
-def test_validator_incoming():
-    raise NotImplementedError()
+def test_validator_incoming(schema, raw_event):
+    @validator(inbound_schema=schema)
+    def lambda_handler(evt, context):
+        pass
 
+    lambda_handler(raw_event, {})
 
-def test_validator_outgoing():
-    raise NotImplementedError()
 
+def test_validator_outgoing(schema_response, raw_response):
+    @validator(outbound_schema=schema_response)
+    def lambda_handler(evt, context):
+        return raw_response
 
-def test_validator_incoming_and_outgoing():
-    raise NotImplementedError()
+    lambda_handler({}, {})
+
+
+def test_validator_incoming_and_outgoing(schema, schema_response, raw_event, raw_response):
+    @validator(inbound_schema=schema, outbound_schema=schema_response)
+    def lambda_handler(evt, context):
+        return raw_response
+
+    lambda_handler(raw_event, {})
+
+
+def test_validator_propagates_exception(schema, raw_event, schema_response):
+    @validator(inbound_schema=schema, outbound_schema=schema_response)
+    def lambda_handler(evt, context):
+        raise ValueError("Bubble up")
+
+    with pytest.raises(ValueError):
+        lambda_handler(raw_event, {})