refactor: remove references to BaseProcessor. Left BasePartialProcessor

Author: gmcrocetti

aws_lambda_powertools/utilities/batch/__init__.py

@@ -3,12 +3,12 @@
 """
 Batch processing utility
 """
-from .base import BasePartialProcessor, BaseProcessor
+
+from .base import BasePartialProcessor
 from .middlewares import batch_processor
 from .sqs import PartialSQSProcessor
 
 __all__ = (
-    "BaseProcessor",
     "BasePartialProcessor",
     "PartialSQSProcessor",
     "batch_processor",

aws_lambda_powertools/utilities/batch/base.py

@@ -5,14 +5,18 @@
 """
 
 from abc import ABC, abstractmethod
-from typing import Any, Callable, Iterable, List, MutableSequence, Tuple
+from typing import Any, Callable, Iterable, List, Tuple
 
 
-class BaseProcessor(ABC):
+class BasePartialProcessor(ABC):
     """
     Abstract class for batch processors.
     """
 
+    def __init__(self):
+        self.success_messages: List = []
+        self.fail_messages: List = []
+
     @abstractmethod
     def _prepare(self):
         """
@@ -62,20 +66,14 @@ def __call__(self, records: Iterable[Any], handler: Callable):
         self.handler = handler
         return self
 
-
-class BasePartialProcessor(BaseProcessor):
-
-    success_messages: MutableSequence = None
-    fail_messages: MutableSequence = None
-
     def success_handler(self, record: Any, result: Any):
         """
         Success callback
 
         Returns
         -------
         tuple
-            "success", record processing result and original record
+            "success", result, original record
         """
         entry = ("success", result, record)
         self.success_messages.append(record)

aws_lambda_powertools/utilities/batch/middlewares.py

@@ -8,12 +8,12 @@
 
 from aws_lambda_powertools.middleware_factory import lambda_handler_decorator
 
-from .base import BaseProcessor
+from .base import BasePartialProcessor
 
 
 @lambda_handler_decorator
 def batch_processor(
-    handler: Callable, event: Dict, context: Dict, record_handler: Callable, processor: BaseProcessor = None
+    handler: Callable, event: Dict, context: Dict, record_handler: Callable, processor: BasePartialProcessor = None
 ):
     """
     Middleware to handle batch event processing

aws_lambda_powertools/utilities/batch/sqs.py

@@ -48,15 +48,11 @@ class PartialSQSProcessor(BasePartialProcessor):
 
     def __init__(self, config: Optional[Config] = None):
         """
-        Initializes sqs client and also success and failure lists
-        to keep track of record's execution status.
+        Initializes sqs client.
         """
         config = config or Config()
         self.client = boto3.client("sqs", config=config)
 
-        self.success_messages: List = []
-        self.fail_messages: List = []
-
         super().__init__()
 
     def _get_queue_url(self) -> str:

tests/unit/test_utilities_batch.py

@@ -47,7 +47,7 @@ def test_partial_sqs_get_entries_to_clean_with_success(mocker, sqs_event, partia
     expected_entries = [{"Id": sqs_event["messageId"], "ReceiptHandle": sqs_event["receiptHandle"]}]
 
     success_messages_mock = mocker.patch.object(
-        PartialSQSProcessor, "success_messages", new_callable=mocker.PropertyMock
+        PartialSQSProcessor, "success_messages", create=True, new_callable=mocker.PropertyMock
     )
     success_messages_mock.return_value = [sqs_event]
 
@@ -60,7 +60,7 @@ def test_partial_sqs_get_entries_to_clean_without_success(mocker, partial_sqs_pr
     expected_entries = []
 
     success_messages_mock = mocker.patch.object(
-        PartialSQSProcessor, "success_messages", new_callable=mocker.PropertyMock
+        PartialSQSProcessor, "success_messages", create=True, new_callable=mocker.PropertyMock
     )
     success_messages_mock.return_value = []