formatting

Author: liustve

awsagentprovider/src/main/java/software/amazon/opentelemetry/javaagent/providers/exporter/aws/common/BaseEmfExporter.java

@@ -21,6 +21,7 @@
 import io.opentelemetry.sdk.metrics.Aggregation;
 import io.opentelemetry.sdk.metrics.InstrumentType;
 import io.opentelemetry.sdk.metrics.data.AggregationTemporality;
+import io.opentelemetry.sdk.metrics.data.Data;
 import io.opentelemetry.sdk.metrics.data.ExponentialHistogramData;
 import io.opentelemetry.sdk.metrics.data.ExponentialHistogramPointData;
 import io.opentelemetry.sdk.metrics.data.GaugeData;
@@ -57,29 +58,29 @@ public CompletableResultCode export(Collection<MetricData> metricsData) {
       Map<String, List<MetricRecord>> groupedMetrics = new HashMap<>();
 
       for (MetricData metric : metricsData) {
-        if (metric.getData() == null || metric.getData().getPoints().isEmpty()) {
+        Data<? extends PointData> metricData = metric.getData();
+        if (metricData == null || metricData.getPoints().isEmpty()) {
           continue;
         }
 
-        for (PointData point : metric.getData().getPoints()) {
+        for (PointData point : metricData.getPoints()) {
           MetricRecord record = null;
 
-          if (metric.getData() instanceof GaugeData || metric.getData() instanceof SumData) {
+          if (metricData instanceof GaugeData || metricData instanceof SumData) {
             record = MetricRecord.convertGaugeAndSum(metric, point);
           }
-          if (metric.getData() instanceof HistogramData && point instanceof HistogramPointData) {
+          if (metricData instanceof HistogramData && point instanceof HistogramPointData) {
             record = MetricRecord.convertHistogram(metric, (HistogramPointData) point);
           }
-          if (metric.getData() instanceof ExponentialHistogramData
+          if (metricData instanceof ExponentialHistogramData
               && point instanceof ExponentialHistogramPointData) {
             record =
                 MetricRecord.convertExponentialHistogram(
                     metric, (ExponentialHistogramPointData) point);
           }
 
           if (record == null) {
-            logger.fine(
-                "Unsupported metric data type: " + metric.getData().getClass().getSimpleName());
+            logger.fine("Unsupported metric data type: " + metricData.getClass().getSimpleName());
             continue;
           }
 
@@ -116,25 +117,6 @@ record =
     }
   }
 
-  private String groupByAttributesAndTimestamp(MetricRecord record) {
-    // Java doesn't have built-in, hashable tuples, so we
-    // concatenate the attributes key and timestamp into a single string to create a unique
-    // grouping key for the HashMap.
-    String attrsKey = getAttributesKey(record.getAttributes());
-    return attrsKey + "_" + record.getTimestamp();
-  }
-
-  private String getAttributesKey(Attributes attributes) {
-    // Sort the attributes to ensure consistent keys
-    // Using TreeMap: The map is sorted
-    // according to the natural ordering of its keys, or by a Comparator provided at map creation
-    // time, depending on which constructor is used.
-    // https://docs.oracle.com/javase/8/docs/api/java/util/TreeMap.html
-    Map<String, Object> sortedAttrs = new TreeMap<>();
-    attributes.forEach((key, value) -> sortedAttrs.put(key.getKey(), value));
-    return sortedAttrs.toString();
-  }
-
   @Override
   public abstract CompletableResultCode flush();
 
@@ -143,7 +125,6 @@ private String getAttributesKey(Attributes attributes) {
 
   @Override
   public AggregationTemporality getAggregationTemporality(InstrumentType instrumentType) {
-    // Set up temporality preference default to DELTA for all instrument types
     return AggregationTemporality.DELTA;
   }
 
@@ -156,11 +137,30 @@ public Aggregation getDefaultAggregation(InstrumentType instrumentType) {
   }
 
   /**
-   * Send a log event to the destination (CloudWatch Logs, console, etc.).
+   * Export a log event.
    *
    * <p>This method must be implemented by subclasses to define where the EMF logs are sent.
    *
    * @param logEvent The log event to send
    */
   protected abstract void emit(Map<String, Object> logEvent);
+
+  private String groupByAttributesAndTimestamp(MetricRecord record) {
+    // Java doesn't have built-in, hashable tuples, so we
+    // concatenate the attributes key and timestamp into a single string to create a unique
+    // grouping key for the HashMap.
+    String attrsKey = getAttributesKey(record.getAttributes());
+    return attrsKey + "_" + record.getTimestamp();
+  }
+
+  private String getAttributesKey(Attributes attributes) {
+    // Sort the attributes to ensure consistent keys
+    // Using TreeMap: The map is sorted
+    // according to the natural ordering of its keys, or by a Comparator provided at map creation
+    // time, depending on which constructor is used.
+    // https://docs.oracle.com/javase/8/docs/api/java/util/TreeMap.html
+    Map<String, Object> sortedAttrs = new TreeMap<>();
+    attributes.forEach((key, value) -> sortedAttrs.put(key.getKey(), value));
+    return sortedAttrs.toString();
+  }
 }