Skip to content

Commit b03846d

Browse files
committed
fix bug with AWS_REGION being parsed in config properties
1 parent 21e814a commit b03846d

File tree

3 files changed

+12
-13
lines changed

3 files changed

+12
-13
lines changed

awsagentprovider/src/main/java/software/amazon/opentelemetry/javaagent/providers/AwsApplicationSignalsCustomizerProvider.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,8 @@
8888
public final class AwsApplicationSignalsCustomizerProvider
8989
implements AutoConfigurationCustomizerProvider {
9090
// https://docs.aws.amazon.com/cli/v1/userguide/cli-configure-envvars.html
91-
static final String AWS_REGION = "AWS_REGION";
92-
static final String AWS_DEFAULT_REGION = "AWS_DEFAULT_REGION";
91+
static final String AWS_REGION = "aws.region";
92+
static final String AWS_DEFAULT_REGION = "aws.default.region";
9393
static final String AWS_LAMBDA_FUNCTION_NAME_CONFIG = "AWS_LAMBDA_FUNCTION_NAME";
9494
static final String LAMBDA_APPLICATION_SIGNALS_REMOTE_ENVIRONMENT =
9595
"LAMBDA_APPLICATION_SIGNALS_REMOTE_ENVIRONMENT";

awsagentprovider/src/main/java/software/amazon/opentelemetry/javaagent/providers/exporter/aws/common/emitter/CloudWatchLogsClientEmitter.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
import software.amazon.awssdk.retries.api.BackoffStrategy;
2525
import software.amazon.awssdk.services.cloudwatchlogs.CloudWatchLogsClient;
2626
import software.amazon.awssdk.services.cloudwatchlogs.model.*;
27-
import software.amazon.opentelemetry.javaagent.providers.exporter.aws.metrics.AwsCloudWatchEmfExporter;
2827

2928
/**
3029
* CloudWatch Logs client for batching and sending log events.
@@ -33,7 +32,8 @@
3332
* logs while respecting CloudWatch Logs constraints.
3433
*/
3534
public class CloudWatchLogsClientEmitter implements LogEventEmitter<CloudWatchLogsClient> {
36-
private static final Logger logger = Logger.getLogger(AwsCloudWatchEmfExporter.class.getName());
35+
private static final Logger logger =
36+
Logger.getLogger(CloudWatchLogsClientEmitter.class.getName());
3737

3838
// Constants for CloudWatch Logs limits
3939
// http://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/cloudwatch_limits_cwl.html
@@ -344,8 +344,7 @@ private static StandardRetryStrategy createExponentialBackoffRetryStrategy() {
344344
/**
345345
* Container for a batch of CloudWatch log events with metadata.
346346
*
347-
* <p>Tracks the log events, total byte size, and timestamps for efficient batching and
348-
* validation.
347+
* <p>Tracks the log events, total byte size, and timestamps for batching and validation.
349348
*/
350349
private static class LogEventBatch {
351350
private final List<InputLogEvent> logEvents = new ArrayList<>();

awsagentprovider/src/test/java/software/amazon/opentelemetry/javaagent/providers/AwsApplicationSignalsCustomizerProviderTest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -571,11 +571,11 @@ static Stream<Arguments> invalidEmfConfigProvider() {
571571
"otlp",
572572
OTEL_EXPORTER_OTLP_LOGS_HEADERS,
573573
"x-aws-log-group=test-group,x-aws-log-stream=test-stream,x-aws-metric-namespace=test-namespace",
574-
"AWS_REGION",
574+
AWS_REGION,
575575
"us-east-1");
576576

577577
Map<String, String> missingHeaders =
578-
Map.of(OTEL_METRICS_EXPORTER, "awsemf", "AWS_REGION", "us-east-1");
578+
Map.of(OTEL_METRICS_EXPORTER, "awsemf", AWS_REGION, "us-east-1");
579579

580580
Map<String, String> missingRegion =
581581
Map.of(
@@ -589,7 +589,7 @@ static Stream<Arguments> invalidEmfConfigProvider() {
589589
"awsemf",
590590
OTEL_EXPORTER_OTLP_LOGS_HEADERS,
591591
"x-aws-log-stream=test-stream,x-aws-metric-namespace=test-namespace",
592-
"AWS_REGION",
592+
AWS_REGION,
593593
"us-east-1");
594594

595595
Map<String, String> missingLogStream =
@@ -598,7 +598,7 @@ static Stream<Arguments> invalidEmfConfigProvider() {
598598
"awsemf",
599599
OTEL_EXPORTER_OTLP_LOGS_HEADERS,
600600
"x-aws-log-group=test-group,x-aws-metric-namespace=test-namespace",
601-
"AWS_REGION",
601+
AWS_REGION,
602602
"us-east-1");
603603

604604
Map<String, String> missingNamespace =
@@ -607,7 +607,7 @@ static Stream<Arguments> invalidEmfConfigProvider() {
607607
"awsemf",
608608
OTEL_EXPORTER_OTLP_LOGS_HEADERS,
609609
"x-aws-log-group=test-group,x-aws-log-stream=test-stream",
610-
"AWS_REGION",
610+
AWS_REGION,
611611
"us-east-1");
612612

613613
args.add(wrongExporter);
@@ -629,7 +629,7 @@ static Stream<Arguments> validEmfConfigProvider() {
629629
"awsemf",
630630
OTEL_EXPORTER_OTLP_LOGS_HEADERS,
631631
"x-aws-log-group=test-group,x-aws-log-stream=test-stream,x-aws-metric-namespace=test-namespace",
632-
"AWS_REGION",
632+
AWS_REGION,
633633
"us-east-1");
634634

635635
Map<String, String> awsDefaultRegionConfig =
@@ -638,7 +638,7 @@ static Stream<Arguments> validEmfConfigProvider() {
638638
"awsemf",
639639
OTEL_EXPORTER_OTLP_LOGS_HEADERS,
640640
"x-aws-log-group=test-group,x-aws-log-stream=test-stream,x-aws-metric-namespace=test-namespace",
641-
"AWS_DEFAULT_REGION",
641+
AWS_DEFAULT_REGION,
642642
"us-west-2");
643643

644644
args.add(awsRegionConfig);

0 commit comments

Comments
 (0)