[Java] Custom Metrics E2E Test #479
Open
+387
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thpierce
reviewed
Oct 30, 2025
Contributor
thpierce
left a comment
thpierce
left a comment
There was a problem hiding this comment.
Why is there no change to the following files?
.github/workflows/java-ec2-default-test.ymlterraform/python/ec2/default/README.md
Comment on lines
158
to
160
| name: cloud.platform | ||
| value: aws_ec2 | ||
| value: aws_ec2 |
Contributor
There was a problem hiding this comment.
Duplicated.
Suggested change
| name: cloud.platform | |
| value: aws_ec2 | |
| value: aws_ec2 | |
| name: cloud.platform | |
| value: aws_ec2 |
| # Get and run the sample application with configuration | ||
| aws s3 cp ${var.sample_app_jar} ./main-service.jar | ||
| aws s3 cp ${var.sample_app_jar} ./main-service-delete-me.jar |
| OTEL_RESOURCE_ATTRIBUTES="service.name=$${SERVICE_NAME},deployment.environment.name=$${DEPLOYMENT_ENVIRONMENT_NAME},Internal_Org=Financial,Business Unit=Payments,Region=us-east-1,aws.application_signals.metric_resource_keys=Business Unit&Region&Organization" \ | ||
| OTEL_INSTRUMENTATION_COMMON_EXPERIMENTAL_CONTROLLER_TELEMETRY_ENABLED=true \ | ||
| nohup java -XX:+UseG1GC -jar main-service.jar &> nohup.out & | ||
| nohup java -XX:+UseG1GC -jar main-service-delete-me.jar &> nohup.out & |
| # Get and run the sample application with configuration | ||
| aws s3 cp ${var.sample_remote_app_jar} ./remote-service.jar | ||
| aws s3 cp ${var.sample_remote_app_jar} ./remote-service-delete-me.jar |
| OTEL_RESOURCE_ATTRIBUTES=service.name=sample-remote-application-${var.test_id} \ | ||
| OTEL_INSTRUMENTATION_COMMON_EXPERIMENTAL_CONTROLLER_TELEMETRY_ENABLED=true \ | ||
| nohup java -XX:+UseG1GC -jar remote-service.jar &> nohup.out & | ||
| nohup java -XX:+UseG1GC -jar remote-service-delete-me.jar &> nohup.out & |
| @ResponseBody | ||
| public String awssdkCall(@RequestParam(name = "testingId", required = false) String testingId) { | ||
|
|
||
| logger.info("Incrementing custom counter - OpenTelemetry available: {}", GlobalOpenTelemetry.get() != null); |
Contributor
There was a problem hiding this comment.
Not needed
Suggested change
| logger.info("Incrementing custom counter - OpenTelemetry available: {}", GlobalOpenTelemetry.get() != null); |
Comment on lines
103
to
105
| private final LongCounter pipelineCounter; | ||
| private final DoubleHistogram pipelineHistogram; | ||
| private final LongUpDownCounter pipelineGauge; |
Contributor
There was a problem hiding this comment.
Suggested change
| private final LongCounter pipelineCounter; | |
| private final DoubleHistogram pipelineHistogram; | |
| private final LongUpDownCounter pipelineGauge; | |
| private final LongCounter customPipelineCounter; | |
| private final DoubleHistogram customPipelineHistogram; | |
| private final LongUpDownCounter customPipelineGauge; |
| .build(); | ||
|
|
||
| SdkMeterProvider pipelineMeterProvider = SdkMeterProvider.builder() | ||
| .setResource(Resource.getDefault()) |
Contributor
There was a problem hiding this comment.
Don't you need to create the resource with servicename/deploymentenvname?
| .build(); | ||
|
|
||
| MetricReader pipelineMetricReader = PeriodicMetricReader.builder(pipelineMetricExporter) | ||
| .setInterval(Duration.ofSeconds(60)) |
Contributor
There was a problem hiding this comment.
Suggested change
| .setInterval(Duration.ofSeconds(60)) | |
| .setInterval(Duration.ofSeconds(1)) |
| private static final LongUpDownCounter gauge = meter.upDownCounterBuilder("agent_based_gauge").build(); | ||
|
|
||
| // Pipeline-based metrics (initialized in constructor) | ||
| private final Meter pipelineMeter; |
Contributor
There was a problem hiding this comment.
Not needed
Suggested change
| private final Meter pipelineMeter; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds custom metrics to the existing sample app to verify public documentation is correct and functionality continues to work as changes happen in the future (Regression testing). Specifically for OpenTelemetry metrics using the CloudWatch Agent.
The changes made in this PR are:
Git revert back to last passing CSHA: 82e7075
<Can we safely revert this commit if needed? If not, detail what must be done to safely revert and why it is needed.>
Ensure you've run the following tests on your changes and include the link below:
To do so, create a
test.ymlfile withname: Testand workflow description to test your changes, then remove the file for your PR. Link your test run in your PR description. This process is a short term solution while we work on creating a staging environment for testing.NOTE: TESTS RUNNING ON A SINGLE EKS CLUSTER CANNOT BE RUN IN PARALLEL. See the needs keyword to run tests in succession.
e2e-playgroundin us-east-1 and eu-central-2e2e-playgroundin us-east-1 and eu-central-2e2e-playgroundin us-east-1 and eu-central-2By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.