Fixing support for existing_sso_users #53
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@novekm , could you please review and merge this or assign somebody else for this review? Would be extremely great to have this in functionaltiy. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Collaborator
|
/do-e2e-tests |
|
End to end test has been scheduled |
|
E2E tests in progress |
1 similar comment
|
E2E tests in progress |
![aws-ia-automator-prod[bot]](https://avatars.githubusercontent.com/u/149281641?s=60&v=4){kind=small}
|
I've attempted a simpler approach that should hopefully clear e2e tests: #60. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allows to specify existing_sso_users together with sso_groups. Should fix this issue