update conditions on delete and aws error code+message (#91)

Description of changes:
- bring in changes from aws-controllers-k8s/code-generator#175, aws-controllers-k8s/code-generator#176
- corresponding unit and integ test changes
- fix some erroneous unit tests like model package group and endpoint config
- fix invalid name in unit test
- fix assertion in notebook instance test since PR build was failing and add it to missing canary cleanup

Testing:
unit test
tested manually, rely on PR build, later we can add more unit tests for delete failed scenario


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: surajkota

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,7 +1,7 @@
 ack_generate_info:
-  build_date: "2021-08-31T22:29:55Z"
-  build_hash: 07d7ea755625b2cac93bbf293bf5a8cab24ecb68
-  go_version: go1.16.4 darwin/amd64
+  build_date: "2021-09-01T00:07:38Z"
+  build_hash: 6f22b7b568e25b4ee007bb1ab5f9338c16daf172
+  go_version: go1.16.4 linux/amd64
   version: v0.13.0
 api_directory_checksum: 13c67d2ac904c5b3c1ddea34aba38d90f06f3adc
 api_version: v1alpha1
@@ -11,4 +11,4 @@ generator_config_info:
   original_file_name: generator.yaml
 last_modification:
   reason: API generation
-  timestamp: 2021-08-31 22:30:07.288585 +0000 UTC
+  timestamp: 2021-09-01 00:07:46.08290738 +0000 UTC

helm/Chart.yaml

@@ -1,6 +1,6 @@
 apiVersion: v1
 name: sagemaker-chart
-description: A Helm chart for the ACK service controller for sagemaker
+description: A Helm chart for the ACK service controller for Amazon SageMaker (SageMaker)
 version: v0.0.3
 appVersion: v0.0.3
 home: https://github.com/aws-controllers-k8s/sagemaker-controller
@@ -10,7 +10,7 @@ sources:
 maintainers:
   - name: ACK Admins
     url: https://github.com/orgs/aws-controllers-k8s/teams/ack-admin
-  - name: sagemaker Admins
+  - name: SageMaker Admins
     url: https://github.com/orgs/aws-controllers-k8s/teams/sagemaker-maintainer
 keywords:
   - aws

pkg/resource/data_quality_job_definition/manager.go

@@ -3,7 +3,7 @@ kind: DataQualityJobDefinition
 metadata:
   name: unit_testing_job_definition
 spec:
-  jobDefinitionName: !-intentionally-invalid-name
+  jobDefinitionName: intentionally@invalid-name
   jobResources:
     clusterConfig:
       instanceCount: 1

pkg/resource/data_quality_job_definition/sdk.go

@@ -24,7 +24,7 @@ spec:
         localPath: /opt/ml/processing/output
         s3URI: s3://source-data-bucket-592697580195-us-west-2/sagemaker/data_quality_job_definition/reports
         s3UploadMode: Continuous
-  jobDefinitionName: ""
+  jobDefinitionName: intentionally@invalid-name
   jobResources:
     clusterConfig:
       instanceCount: 1
@@ -44,6 +44,7 @@ status:
   ackResourceMetadata:
     ownerAccountID: ""
   conditions:
-  - message: The job definition name must start with an alphanumeric character.
+  - message: "InvalidParameterValue: The job definition name must not include a special
+      character.\n\tstatus code: 0, request id: "
     status: "True"
     type: ACK.Terminal

pkg/resource/data_quality_job_definition/testdata/data_quality_job_definition/v1alpha1/dqjd_invalid_before_create.yaml

@@ -10,7 +10,7 @@ tests:
            - operation: CreateDataQualityJobDefinitionWithContext
              error:
                code: InvalidParameterValue
-               message: "The job definition name must start with an alphanumeric character."
+               message: "The job definition name must not include a special character."
        invoke: Create
        expect:
          latest_state: "data_quality_job_definition/v1alpha1/dqjd_invalid_create_attempted.yaml"

pkg/resource/data_quality_job_definition/testdata/data_quality_job_definition/v1alpha1/dqjd_invalid_create_attempted.yaml

@@ -10,7 +10,7 @@ tests:
             - operation: CreateEndpointWithContext
               error:
                 code: InvalidParameterValue
-                message: "The endpoint name must start with an alphanumeric character."
+                message: "The endpoint name must not include a special character."
         invoke: Create
         expect:
           latest_state: "v1alpha1/create/observed/invalid_create_attempted.yaml"