Skip to content

chore: warn of ChangeBatch eventual deprecation #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: warn of ChangeBatch eventual deprecation #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apis/v1alpha1/ack-generate-metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
ack_generate_info:
build_date: "2025-03-27T16:26:40Z"
build_hash: 980cb1e4734f673d16101cf55206b84ca639ec01
build_date: "2025-04-23T16:43:40Z"
build_hash: 0909e7f0adb8ffe4120a8c20d5d58b991f2539e9
go_version: go1.24.1
version: v0.44.0
version: v0.44.0-3-g0909e7f
api_directory_checksum: b920521646bacef1fba9d0b97a423d11565c7a60
api_version: v1alpha1
aws_sdk_go_version: v1.32.6
Expand Down
4 changes: 3 additions & 1 deletion pkg/resource/record_set/sdk.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion templates/hooks/record_set/sdk_create_post_build_request.go.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@

if desired.ko.Spec.ChangeBatch != nil {
rlog.Info("WARNING: ChangeBatch field is no-op, and will be removed soon!")
}
action := svcsdktypes.ChangeActionCreate
recordSet, err := rm.newResourceRecordSet(ctx, desired)
if err != nil {
Expand Down