Add check to not update locations if nothing changed

Guido van der Hart · Guido van der Hart · commit 2d9f8d3736f2 · 2024-09-10T14:18:17.000+02:00
diff --git a/apis/v1alpha1/ack-generate-metadata.yaml b/apis/v1alpha1/ack-generate-metadata.yaml
@@ -1,13 +1,13 @@
 ack_generate_info:
-  build_date: "2024-08-29T17:03:54Z"
+  build_date: "2024-09-10T12:17:23Z"
   build_hash: f8f98563404066ac3340db0a049d2e530e5c51cc
-  go_version: go1.22.5
+  go_version: go1.23.1
   version: v0.38.1
-api_directory_checksum: 78fb7fd24a85da24b8de6246cad67ff3fb6598f8
+api_directory_checksum: fcc2a039096955dfeb2eb1dbd94def23713aeb03
 api_version: v1alpha1
 aws_sdk_go_version: v1.49.0
 generator_config_info:
-  file_checksum: a841c574fab5ddf8a35ade3ba90e7f6713255d7e
+  file_checksum: aaca78853a15611ad9b6b6abec9a4e8989b103a9
   original_file_name: generator.yaml
 last_modification:
   reason: API generation
diff --git a/pkg/resource/cidr_collection/hooks.go b/pkg/resource/cidr_collection/hooks.go
@@ -115,6 +115,11 @@ func (rm *resourceManager) customUpdateCidrCollection(
 	}
 	oldLocations := rm.oldLocations(latest)
 
+	// Do not update Locations if nothing changed
+	if reflect.DeepEqual(newLocations, oldLocations) {
+		return &resource{ko}, nil
+	}
+
 	// First remove old Locations as there is no api call for updating cidr Collection locations
 	if oldLocations != nil {
 		input.SetChanges(oldLocations)
diff --git a/pkg/resource/cidr_collection/manager_factory.go b/pkg/resource/cidr_collection/manager_factory.go
