Make messages consistent, validate parameters modifications, and remove unnecessary terminal exceptions (#54)

Issue #, if available:
1. Some messages are not consistent.
2. e2e test only validates single parameter change for Parameter Group.
3. generator.yaml file has some unnecessary terminal exception.

Description of changes:
1. Keep messages consistent.
2. Use e2e test to validate modifying every parameters at the same time.
4. Remove unnecessary terminal exceptions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: kyriechen96

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,13 +1,13 @@
 ack_generate_info:
-  build_date: "2023-03-02T19:20:54Z"
+  build_date: "2023-03-03T20:58:18Z"
   build_hash: d0f3d78cbea8061f822cbceac3786128f091efe6
   go_version: go1.19
   version: v0.24.2
 api_directory_checksum: 321c79032b9f73aba90926b35167e224f577ecd6
 api_version: v1alpha1
 aws_sdk_go_version: v1.44.93
 generator_config_info:
-  file_checksum: 99d34352ff773953425db4a1251affc22aa523e9
+  file_checksum: c1d34ab8fe5fc4fa9f0fcc7098afa04a4701e675
   original_file_name: generator.yaml
 last_modification:
   reason: API generation

apis/v1alpha1/generator.yaml

@@ -10,14 +10,8 @@ resources:
           code: ClusterNotFoundFault
       terminal_codes:
         - ClusterAlreadyExistsFault
-        - ClusterQuotaForCustomerExceededFault
-        - NodeQuotaForClusterExceededFault
-        - NodeQuotaForCustomerExceededFault
-        - InsufficientClusterCapacityFault
-        - ShardsPerClusterQuotaExceededFault
         - InvalidParameterValueException
         - InvalidParameterCombinationException
-        - TagQuotaPerResourceExceeded
         - NoOperationFault
     renames:
       operations:
@@ -97,14 +91,10 @@ resources:
         404:
           code: SubnetGroupNotFoundFault
       terminal_codes:
-        - SubnetGroupAlreadyExistsFault
-        - SubnetGroupQuotaExceededFault
-        - SubnetQuotaExceededFault
         - InvalidSubnet
-        - SubnetNotAllowedFault
-        - TagQuotaPerResourceExceeded
-        - SubnetInUse
         - InvalidParameterValueException
+        - SubnetGroupAlreadyExistsFault
+        - SubnetNotAllowedFault
     fields:
       SubnetIDs:
         references:
@@ -145,10 +135,8 @@ resources:
         - ACLAlreadyExistsFault
         - DefaultUserRequired
         - DuplicateUserNameFault
-        - ACLQuotaExceededFault
         - InvalidParameterValueException
         - InvalidParameterCombinationException
-        - TagQuotaPerResourceExceeded
     fields:
       UserNames:
         references:
@@ -188,12 +176,10 @@ resources:
         404:
           code: UserNotFoundFault
       terminal_codes:
-        - InvalidParameterValueException
         - UserAlreadyExistsFault
-        - UserQuotaExceededFault
+        - InvalidParameterValueException
         - DuplicateUserNameFault
         - InvalidParameterCombinationException
-        - TagQuotaPerResourceExceeded
     fields:
       AuthenticationMode.Passwords:
         is_secret: true
@@ -233,12 +219,10 @@ resources:
         404:
           code: SnapshotNotFoundFault
       terminal_codes:
-        -  InvalidParameterCombinationException
-        -  SnapshotAlreadyExistsFault
-        -  SnapshotQuotaExceededFault
-        -  TagQuotaPerResourceExceeded
-        -  InvalidParameterValueException
-        -  InvalidParameter
+        - InvalidParameterCombinationException
+        - InvalidParameterValueException
+        - InvalidParameter
+        - SnapshotAlreadyExistsFault
     fields:
       SourceSnapshotName:
         from:
@@ -293,12 +277,10 @@ resources:
         404:
           code: ParameterGroupNotFoundFault
       terminal_codes:
-        - ParameterGroupQuotaExceededFault
-        - ParameterGroupAlreadyExistsFault
         - InvalidParameterGroupStateFault
         - InvalidParameterValueException
         - InvalidParameterCombinationException
-        - TagQuotaPerResourceExceeded
+        - ParameterGroupAlreadyExistsFault
     fields:
       Name:
         is_primary_key: true

generator.yaml

@@ -10,14 +10,8 @@ resources:
           code: ClusterNotFoundFault
       terminal_codes:
         - ClusterAlreadyExistsFault
-        - ClusterQuotaForCustomerExceededFault
-        - NodeQuotaForClusterExceededFault
-        - NodeQuotaForCustomerExceededFault
-        - InsufficientClusterCapacityFault
-        - ShardsPerClusterQuotaExceededFault
         - InvalidParameterValueException
         - InvalidParameterCombinationException
-        - TagQuotaPerResourceExceeded
         - NoOperationFault
     renames:
       operations:
@@ -97,14 +91,10 @@ resources:
         404:
           code: SubnetGroupNotFoundFault
       terminal_codes:
-        - SubnetGroupAlreadyExistsFault
-        - SubnetGroupQuotaExceededFault
-        - SubnetQuotaExceededFault
         - InvalidSubnet
-        - SubnetNotAllowedFault
-        - TagQuotaPerResourceExceeded
-        - SubnetInUse
         - InvalidParameterValueException
+        - SubnetGroupAlreadyExistsFault
+        - SubnetNotAllowedFault
     fields:
       SubnetIDs:
         references:
@@ -145,10 +135,8 @@ resources:
         - ACLAlreadyExistsFault
         - DefaultUserRequired
         - DuplicateUserNameFault
-        - ACLQuotaExceededFault
         - InvalidParameterValueException
         - InvalidParameterCombinationException
-        - TagQuotaPerResourceExceeded
     fields:
       UserNames:
         references:
@@ -188,12 +176,10 @@ resources:
         404:
           code: UserNotFoundFault
       terminal_codes:
-        - InvalidParameterValueException
         - UserAlreadyExistsFault
-        - UserQuotaExceededFault
+        - InvalidParameterValueException
         - DuplicateUserNameFault
         - InvalidParameterCombinationException
-        - TagQuotaPerResourceExceeded
     fields:
       AuthenticationMode.Passwords:
         is_secret: true
@@ -233,12 +219,10 @@ resources:
         404:
           code: SnapshotNotFoundFault
       terminal_codes:
-        -  InvalidParameterCombinationException
-        -  SnapshotAlreadyExistsFault
-        -  SnapshotQuotaExceededFault
-        -  TagQuotaPerResourceExceeded
-        -  InvalidParameterValueException
-        -  InvalidParameter
+        - InvalidParameterCombinationException
+        - InvalidParameterValueException
+        - InvalidParameter
+        - SnapshotAlreadyExistsFault
     fields:
       SourceSnapshotName:
         from:
@@ -293,12 +277,10 @@ resources:
         404:
           code: ParameterGroupNotFoundFault
       terminal_codes:
-        - ParameterGroupQuotaExceededFault
-        - ParameterGroupAlreadyExistsFault
         - InvalidParameterGroupStateFault
         - InvalidParameterValueException
         - InvalidParameterCombinationException
-        - TagQuotaPerResourceExceeded
+        - ParameterGroupAlreadyExistsFault
     fields:
       Name:
         is_primary_key: true

pkg/resource/acl/sdk.go

@@ -29,8 +29,8 @@ import (
 )
 
 var (
-	condMsgCurrentlyDeleting            = "cluster currently being deleted"
-	condMsgNoDeleteWhileUpdating        = "cluster is being updated. cannot delete"
+	condMsgCurrentlyDeleting            = "cluster is currently being deleted"
+	condMsgNoDeleteWhileUpdating        = "cluster is currently being updated. cannot delete"
 	resourceStatusAvailable      string = "available"
 )