Skip to content

Commit 49b75f9

Browse files
authored
Ignore ClusterName for copySnapshot API (#58)
Issue #, if available: v0.23.1 code-controller considers ClusterName as required field for snapshot, but memorydb copySnapshot API should have empty ClusterName. Description of changes: Set is_required value of ClusterName to false for snapshot. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent cab999c commit 49b75f9

File tree

7 files changed

+11
-12
lines changed

7 files changed

+11
-12
lines changed
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
ack_generate_info:
2-
build_date: "2023-02-03T00:39:12Z"
3-
build_hash: c6651c200ba136e5c7f50ad8be751fae060a38e6
2+
build_date: "2023-02-07T22:28:52Z"
3+
build_hash: b55ae8752ece381c383ffe5b388ed2147c6b30d8
44
go_version: go1.19
5-
version: v0.22.0-1-gc6651c2
5+
version: v0.23.1
66
api_directory_checksum: ee32acc4d4a0ba7e2823dd20fdbe2c4ef1d9e0f4
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.44.93
99
generator_config_info:
10-
file_checksum: d7ad13c5bc8d9e9e2171c92dc3ac51c2b5e3b769
10+
file_checksum: 19e41b58c6c4d1971db53e6c1694da632d71d053
1111
original_file_name: generator.yaml
1212
last_modification:
1313
reason: API generation

apis/v1alpha1/generator.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,7 @@ resources:
209209
path: SourceSnapshotName
210210
ClusterName:
211211
is_primary_key: false
212+
is_required: false
212213
from:
213214
operation: CreateSnapshot
214215
path: ClusterName

config/controller/deployment.yaml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
apiVersion: v1
22
kind: Namespace
33
metadata:
4-
labels:
5-
control-plane: controller
64
name: ack-system
75
---
86
apiVersion: apps/v1
@@ -11,16 +9,17 @@ metadata:
119
name: ack-memorydb-controller
1210
namespace: ack-system
1311
labels:
14-
control-plane: controller
12+
app.kubernetes.io/name: ack-memorydb-controller
13+
app.kubernetes.io/part-of: ack-system
1514
spec:
1615
selector:
1716
matchLabels:
18-
control-plane: controller
17+
app.kubernetes.io/name: ack-memorydb-controller
1918
replicas: 1
2019
template:
2120
metadata:
2221
labels:
23-
control-plane: controller
22+
app.kubernetes.io/name: ack-memorydb-controller
2423
spec:
2524
containers:
2625
- command:

config/controller/service.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ metadata:
55
namespace: ack-system
66
spec:
77
selector:
8-
control-plane: controller
8+
app.kubernetes.io/name: ack-memorydb-controller
99
ports:
1010
- name: metricsport
1111
port: 8080

generator.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,7 @@ resources:
209209
path: SourceSnapshotName
210210
ClusterName:
211211
is_primary_key: false
212+
is_required: false
212213
from:
213214
operation: CreateSnapshot
214215
path: ClusterName

helm/templates/deployment.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ metadata:
1010
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
1111
k8s-app: {{ include "app.name" . }}
1212
helm.sh/chart: {{ include "chart.name-version" . }}
13-
control-plane: controller
1413
spec:
1514
replicas: 1
1615
selector:

helm/templates/metrics-service.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ metadata:
1111
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
1212
k8s-app: {{ include "app.name" . }}
1313
helm.sh/chart: {{ include "chart.name-version" . }}
14-
control-plane: controller
1514
spec:
1615
selector:
1716
app.kubernetes.io/name: {{ include "app.name" . }}

0 commit comments

Comments
 (0)