Terminal codes for DhcpOptions (#60)

Issue #, if available: [1362](aws-controllers-k8s/community#1362)

Description of changes:

- Mapped terminal codes for **DhcpOptions** resource.
- Added integration tests for the terminal codes mapped.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: LikithaVemulapalli

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,13 +1,13 @@
 ack_generate_info:
-  build_date: "2022-07-13T18:52:15Z"
+  build_date: "2022-07-21T17:09:05Z"
   build_hash: 208b1e15257d57c46729698f47a40fd59441ecbd
   go_version: go1.18.3
   version: v0.19.2-1-g208b1e1
 api_directory_checksum: 8c35bdcab21768638dfaa277896e05fdd8a11969
 api_version: v1alpha1
 aws_sdk_go_version: v1.42.0
 generator_config_info:
-  file_checksum: b8c9656298e66891b1a4ecf1c915423499795c6c
+  file_checksum: 2d139419a1025deea1337589c5831061d23499bb
   original_file_name: generator.yaml
 last_modification:
   reason: API generation

apis/v1alpha1/generator.yaml

@@ -156,6 +156,9 @@ operations:
     resource_name: Instance
 resources:
   DhcpOptions:
+    exceptions:
+      terminal_codes:
+      - InvalidParameterValue
     fields:
       DHCPConfigurations.Values:
         set:

generator.yaml

@@ -156,6 +156,9 @@ operations:
     resource_name: Instance
 resources:
   DhcpOptions:
+    exceptions:
+      terminal_codes:
+      - InvalidParameterValue
     fields:
       DHCPConfigurations.Values:
         set:

pkg/resource/dhcp_options/sdk.go

@@ -78,4 +78,41 @@ def test_create_delete(self, ec2_client):
         time.sleep(DELETE_WAIT_AFTER_SECONDS)
 
         # Check DHCP Options no longer exists in AWS
-        ec2_validator.assert_dhcp_options(resource_id, exists=False)
+        ec2_validator.assert_dhcp_options(resource_id, exists=False)
+
+    def test_terminal_condition_invalid_parameter_value(self):
+        test_resource_values = REPLACEMENT_VALUES.copy()
+        resource_name = random_suffix_name("dhcp-opts-fail", 24)
+
+        test_resource_values["DHCP_OPTIONS_NAME"] = resource_name
+        test_resource_values["DHCP_KEY_1"] = "InvalidValue"
+        test_resource_values["DHCP_VAL_1"] = "ack-example.com"
+        test_resource_values["DHCP_KEY_2"] = "domain-name-servers"
+        test_resource_values["DHCP_VAL_2_1"] = "10.2.5.1"
+        test_resource_values["DHCP_VAL_2_2"] = "10.2.5.2"
+
+        # Load DHCP Options CR
+        resource_data = load_ec2_resource(
+            "dhcp_options",
+            additional_replacements=test_resource_values,
+        )
+        logging.debug(resource_data)
+
+        # Create k8s resource
+        ref = k8s.CustomResourceReference(
+            CRD_GROUP, CRD_VERSION, RESOURCE_PLURAL,
+            resource_name, namespace="default",
+        )
+        k8s.create_custom_resource(ref, resource_data)
+        cr = k8s.wait_resource_consumed_by_controller(ref)
+
+        assert cr is not None
+        assert k8s.get_resource_exists(ref)
+
+        expected_msg = "InvalidParameterValue: Value (InvalidValue) for parameter name is invalid. Unknown DHCP option"
+        terminal_condition = k8s.get_resource_condition(ref, "ACK.Terminal")
+        # Example condition message:
+        # An error occurred (InvalidParameterValue) when calling the CreateDhcpOptions operation:
+        # Value (InvalidValue) for parameter value is invalid.
+        # Unknown DHCP option
+        assert expected_msg in terminal_condition['message']