update code according to prettier rules

Author: eduardomourar

.eslintrc.js

@@ -3,12 +3,7 @@ module.exports = {
         jest: true,
         node: true,
     },
-    plugins: [
-        '@typescript-eslint',
-        'prettier',
-        'import',
-        'prefer-arrow',
-    ],
+    plugins: ['@typescript-eslint', 'prettier', 'import', 'prefer-arrow'],
     parser: '@typescript-eslint/parser',
     parserOptions: {
         ecmaVersion: '2017',
@@ -28,19 +23,19 @@ module.exports = {
             node: {},
             typescript: {
                 directory: './tsconfig.eslint.json',
-            }
-        }
+            },
+        },
     },
-    ignorePatterns: ['*.js', '*.d.ts', 'node_modules/', '*.generated.ts'],
+    ignorePatterns: ['*.d.ts', '*.generated.ts'],
     rules: {
         // Require use of the `import { foo } from 'bar';` form instead of `import foo = require('bar');`
         '@typescript-eslint/no-require-imports': ['error'],
 
+        '@typescript-eslint/ban-ts-ignore': ['warn'],
+        '@typescript-eslint/no-empty-function': ['warn'],
+
         // Require all imported dependencies are actually declared in package.json
         'import/no-extraneous-dependencies': ['error'],
         'import/no-unresolved': ['error'],
-
-        '@typescript-eslint/ban-ts-ignore': ['warn'],
-        '@typescript-eslint/no-empty-function': ['warn'],
-    }
-}
+    },
+};

.github/workflows/ci.yml

@@ -47,3 +47,5 @@ jobs:
           ls -la
           printf "AWS::Foo::Bar\n1\nn" | cfn init -vv
           ls -la
+          npm install --optional
+          npm run build

.pre-commit-config.yaml

@@ -75,7 +75,7 @@ repos:
       - id: jest-local
         name: jest-local
         description: Run jest in the local environment
-        entry: npm run test:ci
+        entry: npx jest --ci
         language: system
         # ignore all files, run on hard-coded modules instead
         pass_filenames: false

README.md

@@ -100,7 +100,7 @@ pip3 install \
 
 That ensures neither is accidentally installed from PyPI.
 
-Linting and running unit tests is done via [pre-commit](https://pre-commit.com/), and so is performed automatically on commit after being installed (`pre-commit install`).
+Linting and running unit tests is done via [pre-commit](https://pre-commit.com/), and so is performed automatically on commit after being installed (`pre-commit install`). The continuous integration also runs these checks. Manual options are available so you don't have to commit:
 
 ```shell
 # run all hooks on all files, mirrors what the CI runs

jest.config.js

@@ -1,10 +1,18 @@
 module.exports = {
-  preset: 'ts-jest',
-  testEnvironment: 'node',
-  globals: {
-    'ts-jest': {
-      diagnostics: false, // Necessary to avoid typeschecking error in decorators
-    }
-  },
-  testRegex: '\\.test.ts$',
+    preset: 'ts-jest',
+    testEnvironment: 'node',
+    globals: {
+        'ts-jest': {
+            diagnostics: false, // Necessary to avoid typeschecking error in decorators
+        },
+    },
+    testRegex: '\\.test.ts$',
+    coverageThreshold: {
+        global: {
+            branches: 80,
+            statements: 90,
+        },
+    },
+    collectCoverage: true,
+    coverageReporters: ['lcov', 'html', 'text-summary'],
 };

package.json

@@ -13,12 +13,10 @@
     "scripts": {
         "build": "npx tsc",
         "prepack": "npm run build",
-        "postinstall": "npm run build",
-        "lint": "npx eslint '**/*.ts'",
-        "lint:fix": "npx eslint --fix '**/*.ts'",
+        "lint": "npx eslint --ext .ts,.js .",
+        "lint:fix": "npx eslint --fix --ext .ts,.js .",
         "test": "npx jest",
-        "test:debug": "npx --node-arg=--inspect jest --runInBand",
-        "test:ci": "npx jest --ci --collect-coverage"
+        "test:debug": "npx --node-arg=--inspect jest --runInBand"
     },
     "engines": {
         "node": ">=10.0.0",

src/callback.ts

@@ -4,7 +4,6 @@ import CloudFormation from 'aws-sdk/clients/cloudformation';
 import { SessionProxy } from './proxy';
 import { BaseResourceModel, CfnResponse, OperationStatus } from './interface';
 
-
 const LOGGER = console;
 
 interface ProgressOptions extends CfnResponse<BaseResourceModel> {
@@ -13,7 +12,6 @@ interface ProgressOptions extends CfnResponse<BaseResourceModel> {
 }
 
 export async function reportProgress(options: ProgressOptions): Promise<void> {
-
     const {
         session,
         bearerToken,
@@ -39,11 +37,16 @@ export async function reportProgress(options: ProgressOptions): Promise<void> {
     }
     if (currentOperationStatus) {
         request.CurrentOperationStatus = currentOperationStatus;
-        const response: { [key: string]: any } = await client.recordHandlerProgress(request).promise();
+        const response: { [key: string]: any } = await client
+            .recordHandlerProgress(request)
+            .promise();
         let requestId = '';
         if (response['ResponseMetadata']) {
             requestId = response.ResponseMetadata.RequestId;
         }
-        LOGGER.debug(`Record Handler Progress with Request Id ${requestId} and Request:`, request);
+        LOGGER.debug(
+            `Record Handler Progress with Request Id ${requestId} and Request:`,
+            request
+        );
     }
 }

src/exceptions.ts

@@ -6,9 +6,10 @@ export abstract class BaseHandlerException extends Error {
 
     public errorCode: HandlerErrorCode;
 
-    public constructor(message? : any, errorCode? : HandlerErrorCode) {
+    public constructor(message?: any, errorCode?: HandlerErrorCode) {
         super(message);
-        this.errorCode = errorCode || HandlerErrorCode[this.constructor.name as HandlerErrorCode];
+        this.errorCode =
+            errorCode || HandlerErrorCode[this.constructor.name as HandlerErrorCode];
         Object.setPrototypeOf(this, new.target.prototype); // restore prototype chain
     }
 
@@ -28,16 +29,16 @@ export class InvalidCredentials extends BaseHandlerException {}
 export class AlreadyExists extends BaseHandlerException {
     constructor(typeName: string, identifier: string) {
         super(
-            `Resource of type '${typeName}' with identifier '${identifier}' already exists.`,
-        )
+            `Resource of type '${typeName}' with identifier '${identifier}' already exists.`
+        );
     }
 }
 
 export class NotFound extends BaseHandlerException {
     constructor(typeName: string, identifier: string) {
         super(
-            `Resource of type '${typeName}' with identifier '${identifier}' was not found.`,
-        )
+            `Resource of type '${typeName}' with identifier '${identifier}' was not found.`
+        );
     }
 }
 

src/interface.ts

@@ -5,7 +5,6 @@ import {
 } from 'aws-sdk/clients/cloudformation';
 import { allArgsConstructor, builder } from 'tombok';
 
-
 export type Optional<T> = T | undefined | null;
 
 export interface Callable<R extends Array<any>, T> {
@@ -75,7 +74,9 @@ export class BaseResourceModel {
     protected static readonly TYPE_NAME?: string;
 
     constructor(...args: any[]) {}
-    public static builder(): any {return null}
+    public static builder(): any {
+        return null;
+    }
 
     public getTypeName(): string {
         return Object.getPrototypeOf(this).constructor.TYPE_NAME;