chore: update magic number for face height (#83)

phantumcode · web-flow · commit 0b2878985a57 · 2023-11-29T14:31:59.000-06:00
diff --git a/Sources/FaceLiveness/FaceDetection/BlazeFace/DetectedFace.swift b/Sources/FaceLiveness/FaceDetection/BlazeFace/DetectedFace.swift
@@ -34,7 +34,7 @@ struct DetectedFace {
         }
         
         let faceWidth = ow
-        let faceHeight = 1.68 * faceWidth
+        let faceHeight = 1.618 * faceWidth
         let faceBoxBottom = boundingBox.maxY
         let faceBoxTop = faceBoxBottom - faceHeight
         let faceBoxLeft = min(cx - ow / 2, rightEar.x)
diff --git a/Tests/FaceLivenessTests/DetectedFaceTests.swift b/Tests/FaceLivenessTests/DetectedFaceTests.swift
@@ -100,9 +100,9 @@ final class DetectedFaceTests: XCTestCase {
         let ovalRect = CGRect.zero
         let expectedBoundingBox = CGRect(
             x: 0.1658528943614037,
-            y: 0.041756969751750916,
+            y: 0.072967669448238516,
             width: 0.6240418540649166,
-            height: 0.8457092820983773
+            height: 0.8144985824018897
         )
         let boundingBox = detectedFace.boundingBoxFromLandmarks(ovalRect: ovalRect)
         XCTAssertEqual(boundingBox.origin.x, expectedBoundingBox.origin.x)

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ struct DetectedFace {`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`let faceWidth = ow`
`37`		`- let faceHeight = 1.68 * faceWidth`
	`37`	`+ let faceHeight = 1.618 * faceWidth`
`38`	`38`	`let faceBoxBottom = boundingBox.maxY`
`39`	`39`	`let faceBoxTop = faceBoxBottom - faceHeight`
`40`	`40`	`let faceBoxLeft = min(cx - ow / 2, rightEar.x)`