Skip to content

Commit 868b0a8

Browse files
committed
set artifactsOverride.type to NO_ARTIFACTS
1 parent 3821a17 commit 868b0a8

File tree

2 files changed

+38
-12
lines changed

2 files changed

+38
-12
lines changed

code-build.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,8 +173,9 @@ function githubInputs() {
173173
core.getInput("compute-type-override", { required: false }) || undefined;
174174

175175
const environmentTypeOverride =
176-
core.getInput("environment-type-override", { required: false }) || undefined;
177-
const imageOverride =
176+
core.getInput("environment-type-override", { required: false }) ||
177+
undefined;
178+
const imageOverride =
178179
core.getInput("image-override", { required: false }) || undefined;
179180

180181
const envPassthrough = core
@@ -211,6 +212,7 @@ function inputs2Parameters(inputs) {
211212

212213
const sourceTypeOverride = "GITHUB";
213214
const sourceLocationOverride = `https://github.com/${owner}/${repo}.git`;
215+
const artifactsOverride = { type: "NO_ARTIFACTS" };
214216

215217
const environmentVariablesOverride = Object.entries(process.env)
216218
.filter(
@@ -225,6 +227,7 @@ function inputs2Parameters(inputs) {
225227
sourceVersion,
226228
sourceTypeOverride,
227229
sourceLocationOverride,
230+
artifactsOverride,
228231
buildspecOverride,
229232
computeTypeOverride,
230233
environmentTypeOverride,

test/code-build-test.js

Lines changed: 33 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,12 @@ describe("githubInputs", () => {
7171
expect(test)
7272
.to.haveOwnProperty("buildspecOverride")
7373
.and.to.equal(undefined);
74-
expect(test).to.haveOwnProperty("computeTypeOverride").and.to.equal(undefined);
75-
expect(test).to.haveOwnProperty("environmentTypeOverride").and.to.equal(undefined);
74+
expect(test)
75+
.to.haveOwnProperty("computeTypeOverride")
76+
.and.to.equal(undefined);
77+
expect(test)
78+
.to.haveOwnProperty("environmentTypeOverride")
79+
.and.to.equal(undefined);
7680
expect(test).to.haveOwnProperty("imageOverride").and.to.equal(undefined);
7781
expect(test).to.haveOwnProperty("envPassthrough").and.to.deep.equal([]);
7882
});
@@ -88,7 +92,7 @@ describe("githubInputs", () => {
8892
process.env[`GITHUB_REPOSITORY`] = repoInfo;
8993
process.env[`GITHUB_SHA`] = sha;
9094

91-
process.env[`INPUT_ENV-VARS-FOR-CODEBUILD`] = `one, two
95+
process.env[`INPUT_ENV-VARS-FOR-CODEBUILD`] = `one, two
9296
, three,
9397
four `;
9498

@@ -123,8 +127,12 @@ describe("githubInputs", () => {
123127
expect(test)
124128
.to.haveOwnProperty("buildspecOverride")
125129
.and.to.equal(undefined);
126-
expect(test).to.haveOwnProperty("computeTypeOverride").and.to.equal(undefined);
127-
expect(test).to.haveOwnProperty("environmentTypeOverride").and.to.equal(undefined);
130+
expect(test)
131+
.to.haveOwnProperty("computeTypeOverride")
132+
.and.to.equal(undefined);
133+
expect(test)
134+
.to.haveOwnProperty("environmentTypeOverride")
135+
.and.to.equal(undefined);
128136
expect(test).to.haveOwnProperty("imageOverride").and.to.equal(undefined);
129137
expect(test).to.haveOwnProperty("envPassthrough").and.to.deep.equal([]);
130138
});
@@ -176,11 +184,19 @@ describe("inputs2Parameters", () => {
176184
expect(test)
177185
.to.haveOwnProperty("sourceLocationOverride")
178186
.and.to.equal(`https://github.com/owner/repo.git`);
187+
expect(test)
188+
.to.haveOwnProperty("artifactsOverride")
189+
.that.has.property("type")
190+
.that.equals("NO_ARTIFACTS");
179191
expect(test)
180192
.to.haveOwnProperty("buildspecOverride")
181193
.and.to.equal(undefined);
182-
expect(test).to.haveOwnProperty("computeTypeOverride").and.to.equal(undefined);
183-
expect(test).to.haveOwnProperty("environmentTypeOverride").and.to.equal(undefined);
194+
expect(test)
195+
.to.haveOwnProperty("computeTypeOverride")
196+
.and.to.equal(undefined);
197+
expect(test)
198+
.to.haveOwnProperty("environmentTypeOverride")
199+
.and.to.equal(undefined);
184200
expect(test).to.haveOwnProperty("imageOverride").and.to.equal(undefined);
185201

186202
// I send everything that starts 'GITHUB_'
@@ -218,7 +234,8 @@ describe("inputs2Parameters", () => {
218234
repo: "repo",
219235
computeTypeOverride: "BUILD_GENERAL1_LARGE",
220236
environmentTypeOverride: "LINUX_CONTAINER",
221-
imageOverride: "111122223333.dkr.ecr.us-west-2.amazonaws.com/codebuild-docker-repo"
237+
imageOverride:
238+
"111122223333.dkr.ecr.us-west-2.amazonaws.com/codebuild-docker-repo",
222239
});
223240
expect(test).to.haveOwnProperty("projectName").and.to.equal(projectName);
224241
expect(test).to.haveOwnProperty("sourceVersion").and.to.equal(sha);
@@ -228,6 +245,10 @@ describe("inputs2Parameters", () => {
228245
expect(test)
229246
.to.haveOwnProperty("sourceLocationOverride")
230247
.and.to.equal(`https://github.com/owner/repo.git`);
248+
expect(test)
249+
.to.haveOwnProperty("artifactsOverride")
250+
.that.has.property("type")
251+
.that.equals("NO_ARTIFACTS");
231252
expect(test)
232253
.to.haveOwnProperty("buildspecOverride")
233254
.and.to.equal(undefined);
@@ -239,7 +260,9 @@ describe("inputs2Parameters", () => {
239260
.and.to.equal(`LINUX_CONTAINER`);
240261
expect(test)
241262
.to.haveOwnProperty("imageOverride")
242-
.and.to.equal(`111122223333.dkr.ecr.us-west-2.amazonaws.com/codebuild-docker-repo`);
263+
.and.to.equal(
264+
`111122223333.dkr.ecr.us-west-2.amazonaws.com/codebuild-docker-repo`
265+
);
243266

244267
// I send everything that starts 'GITHUB_'
245268
expect(test)
@@ -270,7 +293,7 @@ describe("inputs2Parameters", () => {
270293
process.env[`GITHUB_REPOSITORY`] = repoInfo;
271294
process.env[`GITHUB_SHA`] = sha;
272295

273-
process.env[`INPUT_ENV-VARS-FOR-CODEBUILD`] = `one, two
296+
process.env[`INPUT_ENV-VARS-FOR-CODEBUILD`] = `one, two
274297
, three,
275298
four `;
276299

0 commit comments

Comments
 (0)