fix: gracefully handle logName on undefined Arn

Author: Canas

code-build.js

@@ -234,13 +234,18 @@ function buildSdk() {
 }
 
 function logName(Arn) {
-  const [logGroupName, logStreamName] = Arn.split(":log-group:")
-    .pop()
-    .split(":log-stream:");
-  if (logGroupName === "null" || logStreamName === "null")
-    return {
-      logGroupName: undefined,
-      logStreamName: undefined,
-    };
-  return { logGroupName, logStreamName };
+  const logs = {
+    logGroupName: undefined,
+    logStreamName: undefined,
+  };
+  if (Arn) {
+    const [logGroupName, logStreamName] = Arn.split(":log-group:")
+      .pop()
+      .split(":log-stream:");
+    if (logGroupName !== "null" && logStreamName !== "null") {
+      logs.logGroupName = logGroupName;
+      logs.logStreamName = logStreamName;
+    }
+  }
+  return logs;
 }

test/code-build-test.js

@@ -29,6 +29,13 @@ describe("logName", () => {
     expect(test).to.haveOwnProperty("logGroupName").and.to.equal(undefined);
     expect(test).to.haveOwnProperty("logStreamName").and.to.equal(undefined);
   });
+
+  it("return undefined when the Arn is undefined", () => {
+    const arn = undefined;
+    const test = logName(arn);
+    expect(test).to.haveOwnProperty("logGroupName").and.to.equal(undefined);
+    expect(test).to.haveOwnProperty("logStreamName").and.to.equal(undefined);
+  });
 });
 
 describe("githubInputs", () => {