handle enableECSManagedTagsInput

when no input enableECSManagedTagsInput, not include it to request params

Author: wim-web

index.js

@@ -133,18 +133,21 @@ async function tasksExitCode(ecs, clusterName, taskArns) {
 }
 
 // Deploy to a service that uses the 'ECS' deployment controller
-async function updateEcsService(ecs, clusterName, service, taskDefArn, waitForService, waitForMinutes, forceNewDeployment, desiredCount, enableECSManagedTags, propagateTags) {
+async function updateEcsService(ecs, clusterName, service, taskDefArn, waitForService, waitForMinutes, forceNewDeployment, desiredCount, enableECSManagedTagsInput, propagateTags) {
   core.debug('Updating the service');
 
   let params = {
     cluster: clusterName,
     service: service,
     taskDefinition: taskDefArn,
     forceNewDeployment: forceNewDeployment,
-    enableECSManagedTags: enableECSManagedTags,
     propagateTags: propagateTags
   };
 
+  if (enableECSManagedTagsInput !== "") {
+    params.enableECSManagedTags = enableECSManagedTagsInput.toLowerCase() === 'true';
+  }
+
   // Add the desiredCount property only if it is defined and a number.
   if (!isNaN(desiredCount) && desiredCount !== undefined) {
     params.desiredCount = desiredCount;
@@ -398,7 +401,7 @@ async function run() {
     const forceNewDeployInput = core.getInput('force-new-deployment', { required: false }) || 'false';
     const forceNewDeployment = forceNewDeployInput.toLowerCase() === 'true';
     const desiredCount = parseInt((core.getInput('desired-count', {required: false})));
-    const enableECSManagedTagsInput = core.getInput('enable-ecs-managed-tags', { required: false }) || 'false';
+    const enableECSManagedTagsInput = core.getInput('enable-ecs-managed-tags', { required: false }) || '';
     const enableECSManagedTags = enableECSManagedTagsInput.toLowerCase() === 'true';
     const propagateTags = core.getInput('propagate-tags', { required: false }) || 'NONE';
 
@@ -452,7 +455,7 @@ async function run() {
       if (!serviceResponse.deploymentController || !serviceResponse.deploymentController.type || serviceResponse.deploymentController.type === 'ECS') {
         // Service uses the 'ECS' deployment controller, so we can call UpdateService
         core.debug('Updating service...');
-        await updateEcsService(ecs, clusterName, service, taskDefArn, waitForService, waitForMinutes, forceNewDeployment, desiredCount, enableECSManagedTags, propagateTags);
+        await updateEcsService(ecs, clusterName, service, taskDefArn, waitForService, waitForMinutes, forceNewDeployment, desiredCount, enableECSManagedTagsInput, propagateTags);
 
       } else if (serviceResponse.deploymentController.type === 'CODE_DEPLOY') {
         // Service uses CodeDeploy, so we should start a CodeDeploy deployment

index.test.js

@@ -183,7 +183,6 @@ describe('Deploy to ECS', () => {
             service: 'service-456',
             taskDefinition: 'task:def:arn',
             forceNewDeployment: false,
-            enableECSManagedTags: false,
             propagateTags: 'NONE'
         });
         expect(waitUntilServicesStable).toHaveBeenCalledTimes(0);
@@ -216,7 +215,6 @@ describe('Deploy to ECS', () => {
             service: 'service-456',
             taskDefinition: 'task:def:arn',
             forceNewDeployment: false,
-            enableECSManagedTags: false,
             propagateTags: 'NONE'
         });
         expect(waitUntilServicesStable).toHaveBeenCalledTimes(0);
@@ -951,7 +949,6 @@ describe('Deploy to ECS', () => {
             service: 'service-456',
             taskDefinition: 'task:def:arn',
             forceNewDeployment: false,
-            enableECSManagedTags: false,
             propagateTags: 'NONE'
         });
         expect(waitUntilServicesStable).toHaveBeenNthCalledWith(
@@ -992,7 +989,6 @@ describe('Deploy to ECS', () => {
             service: 'service-456',
             taskDefinition: 'task:def:arn',
             forceNewDeployment: false,
-            enableECSManagedTags: false,
             propagateTags: 'NONE'
         });
         expect(waitUntilServicesStable).toHaveBeenNthCalledWith(
@@ -1033,7 +1029,6 @@ describe('Deploy to ECS', () => {
             service: 'service-456',
             taskDefinition: 'task:def:arn',
             forceNewDeployment: false,
-            enableECSManagedTags: false,
             propagateTags: 'NONE'
         });
         expect(waitUntilServicesStable).toHaveBeenNthCalledWith(
@@ -1076,7 +1071,6 @@ describe('Deploy to ECS', () => {
             service: 'service-456',
             taskDefinition: 'task:def:arn',
             forceNewDeployment: true,
-            enableECSManagedTags: false,
             propagateTags: 'NONE'
         });
     });
@@ -1102,7 +1096,6 @@ describe('Deploy to ECS', () => {
             service: 'service-456',
             taskDefinition: 'task:def:arn',
             forceNewDeployment: false,
-            enableECSManagedTags: false,
             propagateTags: 'NONE'
         });
     });
@@ -1273,7 +1266,6 @@ describe('Deploy to ECS', () => {
             service: 'service-456',
             taskDefinition: 'task:def:arn',
             forceNewDeployment: false,
-            enableECSManagedTags: false,
             propagateTags: 'NONE',
         });
         expect(mockRunTask).toHaveBeenCalledWith({
@@ -1547,4 +1539,4 @@ describe('Deploy to ECS', () => {
             propagateTags: 'SERVICE'
         });
     });
-});
+});