#9 - Add type conversion for boolean, Boolean, BigDecimal, Instant, OffsetDateTime

Fix for root path

Author: rbygrave

src/main/java/io/dinject/javalin/generator/ControllerReader.java

@@ -84,7 +84,7 @@ String getPath() {
     if (path == null) {
       return null;
     }
-    return Util.trimTrailingSlash(path.value());
+    return Util.trimPath(path.value());
   }
 
   void addImportType(String rawType) {

src/main/java/io/dinject/javalin/generator/PathSegments.java

@@ -18,16 +18,21 @@ static PathSegments parse(String fullPath) {
 
     StringBuilder path = new StringBuilder();
 
-    for (String section : fullPath.split("/")) {
-      if (!section.isEmpty()) {
-        path.append("/");
-        if (section.startsWith(":")) {
-          Segment segment = createSegment(section.substring(1));
-          segments.add(segment);
-          path.append(segment.path(section));
-
-        } else {
-          path.append(section);
+    if ("/".equals(fullPath)) {
+      path.append("/");
+
+    } else {
+      for (String section : fullPath.split("/")) {
+        if (!section.isEmpty()) {
+          path.append("/");
+          if (section.startsWith(":")) {
+            Segment segment = createSegment(section.substring(1));
+            segments.add(segment);
+            path.append(segment.path(section));
+
+          } else {
+            path.append(section);
+          }
         }
       }
     }

src/main/java/io/dinject/javalin/generator/Util.java

@@ -5,13 +5,15 @@
 import javax.lang.model.element.Element;
 import javax.lang.model.type.DeclaredType;
 import java.util.ArrayList;
-import java.util.LinkedHashSet;
 import java.util.List;
-import java.util.Set;
 
 class Util {
 
-  static String trimTrailingSlash(String value) {
+  static String trimPath(String value) {
+    return value.length() <= 1 ? value : trimTrailingSlash(value);
+  }
+
+  private static String trimTrailingSlash(String value) {
     if (value.endsWith("/")) {
       return value.substring(0, value.length() - 1);
     }

src/test/java/io/dinject/javalin/generator/UtilTest.java

@@ -26,6 +26,19 @@ public void combinePath() {
     assertEquals(Util.combinePath("/a", "/"), "/a");
   }
 
+  @Test
+  public void combinePath_forRoot() {
+    assertEquals(Util.combinePath("/", ""), "/");
+    assertEquals(Util.combinePath("", "/"), "");
+  }
+
+  @Test
+  public void trimPath() {
+    assertEquals(Util.trimPath("/"), "/");
+    assertEquals(Util.trimPath("/foo"), "/foo");
+    assertEquals(Util.trimPath("/foo/"), "/foo");
+  }
+
   @Test
   public void snakeCase() {