void body parameters

Author: SentryMan

http-generator-nima/src/main/java/io/avaje/http/generator/helidon/nima/ControllerMethodWriter.java

@@ -102,6 +102,10 @@ void writeHandler(boolean requestScoped) {
     writer.append("    ");
     if (!method.isVoid()) {
       writer.append("var result = ");
+    } else if (method.isVoid()
+        && params.stream().noneMatch(p -> "ServerResponse".equals(p.getShortType()))) {
+      throw new IllegalStateException(
+          "Void controller methods must have a ServerResponse parameter");
     }
 
     if (method.includeValidate()) {

http-generator-nima/src/main/java/io/avaje/http/generator/helidon/nima/ControllerWriter.java

@@ -3,7 +3,6 @@
 import java.io.IOException;
 import java.util.List;
 import java.util.Optional;
-import java.util.function.Predicate;
 
 import javax.lang.model.type.DeclaredType;
 
@@ -19,7 +18,6 @@ class ControllerWriter extends BaseControllerWriter {
 
   private static final String AT_GENERATED = "@Generated(\"avaje-helidon-nima-generator\")";
   private final boolean useJsonB;
-  private List<MethodReader> jsonBMethodList;
 
   ControllerWriter(ControllerReader reader, ProcessingContext ctx, boolean jsonB)
       throws IOException {
@@ -28,14 +26,6 @@ class ControllerWriter extends BaseControllerWriter {
     if (useJsonB) {
       reader.addImportType("io.avaje.jsonb.Jsonb");
       reader.addImportType("io.avaje.jsonb.JsonType");
-      jsonBMethodList =
-          reader.getMethods().stream()
-              .filter(MethodReader::isWebMethod)
-              .filter(Predicate.not(MethodReader::isVoid))
-              .filter(m -> !"byte[]".equals(m.getReturnType().toString()))
-              .filter(
-                  m -> m.getProduces() == null || m.getProduces().toLowerCase().contains("json"))
-              .toList();
     }
     // reader.addImportType("io.helidon.common.http.FormParams");
     reader.addImportType("io.helidon.nima.webserver.http.HttpRules");
@@ -103,8 +93,18 @@ private void writeClassStart() {
       writer.append("  private final Validator validator;").eol();
     }
 
+    List<MethodReader> jsonMethods;
     if (useJsonB) {
-      writeJsonBTypeFields();
+      jsonMethods =
+          reader.getMethods().stream()
+              .filter(MethodReader::isWebMethod)
+              .filter(m -> !"byte[]".equals(m.getReturnType().toString()))
+              .filter(
+                  m -> m.getProduces() == null || m.getProduces().toLowerCase().contains("json"))
+              .toList();
+      writeJsonBTypeFields(jsonMethods);
+    } else {
+      jsonMethods = null;
     }
 
     writer.eol();
@@ -125,14 +125,14 @@ private void writeClassStart() {
     }
 
     if (useJsonB) {
-      writeJsonBTypeAssignments();
+      writeJsonBTypeAssignments(jsonMethods);
     }
 
     writer.append("  }").eol().eol();
   }
 
-  public void writeJsonBTypeFields() {
-    for (final MethodReader methodReader : jsonBMethodList) {
+  public void writeJsonBTypeFields(List<MethodReader> jsonMethods) {
+    for (final MethodReader methodReader : jsonMethods) {
       // body types
       if (methodReader.getBodyType() != null) {
         methodReader.getParams().stream()
@@ -145,6 +145,11 @@ public void writeJsonBTypeFields() {
                             param.getUType().full(), methodReader.simpleName())
                         .eol());
       }
+
+      if (methodReader.isVoid()) {
+        continue;
+      }
+
       // return types
       if (methodReader.getReturnType() instanceof final DeclaredType fullType) {
         final var typeArgs = fullType.getTypeArguments();
@@ -168,11 +173,16 @@ public void writeJsonBTypeFields() {
     }
   }
 
-  public void writeJsonBTypeAssignments() {
+  public void writeJsonBTypeAssignments(List<MethodReader> jsonMethods) {
 
-    for (final MethodReader methodReader : jsonBMethodList) {
+    for (final MethodReader methodReader : jsonMethods) {
       // body types
       writeBodyJsonType(methodReader);
+
+      if (methodReader.isVoid()) {
+        continue;
+      }
+
       writeReturnJsonType(methodReader);
     }
   }

http-generator-nima/src/main/java/io/avaje/http/generator/helidon/nima/NimaProcessor.java

@@ -20,8 +20,8 @@ public NimaProcessor() {
     }
   }
 
-  public NimaProcessor(boolean b) {
-    jsonB = b;
+  public NimaProcessor(boolean useJsonb) {
+    jsonB = useJsonb;
   }
 
   @Override

tests/test-nima-jsonb/src/main/java/org/example/HelloController.java

@@ -9,6 +9,7 @@
 import io.avaje.http.api.Post;
 import io.avaje.http.api.Produces;
 import io.avaje.http.api.Put;
+import io.helidon.nima.webserver.http.ServerResponse;
 
 @Controller
 public class HelloController {
@@ -20,6 +21,11 @@ byte[] testBytes() {
     return "not really an image but ok".getBytes();
   }
 
+  @Get("/void")
+  void testVoid(Person p, ServerResponse res) {
+    res.send("success");
+  }
+
   @Get("hello")
   String helloWorld() {
     return "Hello world";