revert client changes

Author: SentryMan

http-client/src/main/java/io/avaje/http/client/DHttpClientRequest.java

@@ -16,7 +16,6 @@
 import java.util.*;
 import java.util.concurrent.CompletableFuture;
 import java.util.function.Supplier;
-import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
 import static java.net.http.HttpResponse.BodyHandlers.discarding;
@@ -125,25 +124,7 @@ public HttpClientRequest header(String name, String value) {
   }
 
   @Override
-  public HttpClientRequest header(String name, Collection<String> value) {
-    if (headers == null) {
-      headers = new LinkedHashMap<>();
-    }
-    headers.computeIfAbsent(name, s -> new ArrayList<>()).addAll(value);
-    return this;
-  }
-
-  @Override
-  @SuppressWarnings("unchecked")
   public HttpClientRequest header(String name, Object value) {
-
-    if (value instanceof Collection) {
-      final var headerList =
-          ((Collection<Object>) value).stream().map(Object::toString).collect(Collectors.toList());
-
-      return header(name, headerList);
-    }
-
     return value != null ? header(name, value.toString()) : this;
   }
 

http-client/src/main/java/io/avaje/http/client/HttpClientRequest.java

@@ -5,7 +5,6 @@
 import java.net.http.HttpResponse;
 import java.nio.file.Path;
 import java.time.Duration;
-import java.util.Collection;
 import java.util.List;
 import java.util.Map;
 import java.util.function.Supplier;
@@ -127,15 +126,6 @@ public interface HttpClientRequest {
    */
   HttpClientRequest header(Map<String, ?> headers);
 
-  /**
-   * Add the headers to the request via Collection.
-   *
-   * @param name The header name
-   * @param value The header values
-   * @return The request being built
-   */
-  HttpClientRequest header(String name, Collection<String> value);
-
   /**
    * Return the header values that have been set for the given header name.
    *

http-client/src/main/java/io/avaje/http/client/UrlBuilder.java

@@ -2,7 +2,6 @@
 
 import java.net.URLEncoder;
 import java.nio.charset.StandardCharsets;
-import java.util.Collection;
 import java.util.Map;
 
 /**
@@ -85,14 +84,6 @@ public UrlBuilder queryParam(String name, String value) {
    * The name and value parameters are url encoded.
    */
   public UrlBuilder queryParam(String name, Object value) {
-	  
-    if (value instanceof Collection) {
-      for (var e : (Collection) value) {
-        queryParam(name, e);
-      }
-      return this;
-    }
-    
     if (value != null) {
       addQueryParam(name, value.toString());
     }

http-client/src/test/java/io/avaje/http/client/DHttpClientRequestTest.java

@@ -1,11 +1,10 @@
 package io.avaje.http.client;
 
-import static org.assertj.core.api.Assertions.assertThat;
+import org.junit.jupiter.api.Test;
 
 import java.time.Duration;
-import java.util.List;
 
-import org.junit.jupiter.api.Test;
+import static org.assertj.core.api.Assertions.assertThat;
 
 class DHttpClientRequestTest {
 
@@ -22,35 +21,6 @@ void suppressLogging_listenerEvent_expect_suppressedPayloadContent() {
     assertThat(event.responseBody()).isEqualTo("<suppressed response body>");
   }
 
-  @Test
-  void assertHeader() {
-    final var request = new DHttpClientRequest(context, Duration.ZERO);
-
-    final var headers =
-        request
-            .header("Accept", (Object) List.of("application/json", "application/json2"))
-            .header("Accept");
-
-    assertThat(headers).asList().contains("application/json", "application/json2");
-  }
-
-  @Test
-  void assertQuery() {
-    final var client = HttpClient.builder().baseUrl("https://ap7i.github.com").build();
-
-    final var uri =
-        client
-            .request()
-            .queryParam("param", List.of("param1", "param2"))
-            .HEAD()
-            .asDiscarding()
-            .request()
-            .uri()
-            .toString();
-
-    assertThat(uri).isEqualTo("https://ap7i.github.com?param=param1&param=param2");
-  }
-
   @Test
   void skipAuthToken_listenerEvent_expect_suppressedPayloadContent() {
     final DHttpClientRequest request = new DHttpClientRequest(context, Duration.ZERO);