#28 - Remove deprecated methods for verbs get(), put() etc ... need to use GET() PUT() etc

Author: rbygrave

client/pom.xml

@@ -9,7 +9,7 @@
 
   <groupId>io.avaje</groupId>
   <artifactId>avaje-http-client</artifactId>
-  <version>1.8.2-SNAPSHOT</version>
+  <version>1.9-SNAPSHOT</version>
 
   <scm>
     <developerConnection>scm:git:git@github.com:avaje/avaje-http-client.git</developerConnection>

client/src/main/java/io/avaje/http/client/HttpClientRequest.java

@@ -307,46 +307,6 @@ public interface HttpClientRequest {
    */
   HttpClientRequest body(HttpRequest.BodyPublisher body);
 
-  /**
-   * Deprecated migrate to GET().
-   */
-  @Deprecated
-  default HttpClientResponse get() {
-    return GET();
-  }
-
-  /**
-   * Deprecated migrate to POST().
-   */
-  @Deprecated
-  default HttpClientResponse post() {
-    return POST();
-  }
-
-  /**
-   * Deprecated migrate to PUT().
-   */
-  @Deprecated
-  default HttpClientResponse put() {
-    return PUT();
-  }
-
-  /**
-   * Deprecated migrate to PATCH().
-   */
-  @Deprecated
-  default HttpClientResponse patch() {
-    return PATCH();
-  }
-
-  /**
-   * Deprecated migrate to DELETE().
-   */
-  @Deprecated
-  default HttpClientResponse delete() {
-    return DELETE();
-  }
-
   /**
    * Execute the request as a GET.
    */

client/src/main/java/io/avaje/http/client/HttpClientResponse.java

@@ -146,12 +146,4 @@ public interface HttpClientResponse {
    */
   <T> HttpResponse<T> withHandler(HttpResponse.BodyHandler<T> responseHandler);
 
-  /**
-   * Deprecated migrate to {@link #withHandler(HttpResponse.BodyHandler)}
-   */
-  @Deprecated
-  default <T> HttpResponse<T> withResponseHandler(HttpResponse.BodyHandler<T> responseHandler) {
-    return withHandler(responseHandler);
-  }
-
 }

client/src/main/java/io/avaje/http/client/HttpException.java

@@ -124,27 +124,11 @@ public int statusCode() {
     return statusCode;
   }
 
-  /**
-   * Deprecated migrate to statusCode()
-   */
-  @Deprecated
-  public int getStatusCode() {
-    return statusCode();
-  }
-
   /**
    * Return the underlying HttpResponse.
    */
   public HttpResponse<?> httpResponse() {
     return httpResponse;
   }
 
-  /**
-   * Deprecated migrate to httpResponse().
-   */
-  @Deprecated
-  public HttpResponse<?> getHttpResponse() {
-    return httpResponse();
-  }
-
 }

client/src/test/java/io/avaje/http/client/HelloControllerTest.java

@@ -722,7 +722,7 @@ void async_whenComplete_throwingHttpException() {
 
         final HttpException httpException = (HttpException) throwable.getCause();
         causeRef.set(httpException);
-        assertThat(httpException.getStatusCode()).isEqualTo(422);
+        assertThat(httpException.statusCode()).isEqualTo(422);
 
         // convert json error response body to a bean
         final ErrorResponse errorResponse = httpException.bean(ErrorResponse.class);
@@ -903,7 +903,7 @@ void postForm_asVoid_invokesValidation_expect_badRequest_extractError() {
     } catch (HttpException e) {
       assertEquals(422, e.statusCode());
 
-      final HttpResponse<?> httpResponse = e.getHttpResponse();
+      final HttpResponse<?> httpResponse = e.httpResponse();
       assertNotNull(httpResponse);
       assertEquals(422, httpResponse.statusCode());
 

test/pom.xml

@@ -16,19 +16,19 @@
     <dependency>
       <groupId>io.avaje</groupId>
       <artifactId>avaje-http-client</artifactId>
-      <version>1.3</version>
+      <version>1.9-SNAPSHOT</version>
     </dependency>
 
     <dependency>
       <groupId>io.avaje</groupId>
       <artifactId>avaje-http-client-gson</artifactId>
-      <version>1.3</version>
+      <version>1.8</version>
     </dependency>
 
     <dependency>
       <groupId>io.avaje</groupId>
       <artifactId>avaje-http-api</artifactId>
-      <version>1.2</version>
+      <version>1.7</version>
     </dependency>
 
     <dependency>

test/src/main/java/example/github/SimpleHttpClient.java

@@ -37,7 +37,7 @@ public List<Repo> listRepos(String user, String other) throws HttpException {
       return context.request()
         .path("users").path(user).path("repos")
         .queryParam("other", other)
-        .get().list(Repo.class);
+        .GET().list(Repo.class);
     }
 
   }

test/src/test/java/example/github/GithubTest.java

@@ -4,7 +4,6 @@
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.google.gson.Gson;
 import io.avaje.http.client.BodyAdapter;
-import io.avaje.http.client.HttpApi;
 import io.avaje.http.client.HttpClientContext;
 import io.avaje.http.client.JacksonBodyAdapter;
 import io.avaje.http.client.RequestLogger;
@@ -34,7 +33,7 @@ private void assertListRepos(BodyAdapter bodyAdapter) {
       .withRequestListener(new RequestLogger())
       .build();
 
-    final Simple simple = HttpApi.provide(Simple.class, clientContext);
+    final Simple simple = clientContext.create(Simple.class);
 
     final List<Repo> repos = simple.listRepos("rbygrave", "junk");
     assertThat(repos).isNotEmpty();