#30 - ENH: Add default constructor option for JacksonBodyAdapter() with reasonable defaults

Author: rbygrave

client/src/main/java/io/avaje/http/client/JacksonBodyAdapter.java

@@ -1,9 +1,8 @@
 package io.avaje.http.client;
 
+import com.fasterxml.jackson.annotation.JsonInclude;
 import com.fasterxml.jackson.core.JsonProcessingException;
-import com.fasterxml.jackson.databind.ObjectMapper;
-import com.fasterxml.jackson.databind.ObjectReader;
-import com.fasterxml.jackson.databind.ObjectWriter;
+import com.fasterxml.jackson.databind.*;
 import com.fasterxml.jackson.databind.type.CollectionType;
 
 import java.io.IOException;
@@ -18,7 +17,6 @@
  *   HttpClientContext.newBuilder()
  *       .baseUrl(baseUrl)
  *       .bodyAdapter(new JacksonBodyAdapter(new ObjectMapper()))
- *       //.bodyAdapter(new GsonBodyAdapter(new Gson()))
  *       .build();
  *
  * }</pre>
@@ -33,10 +31,24 @@ public class JacksonBodyAdapter implements BodyAdapter {
 
   private final ConcurrentHashMap<Class<?>, BodyReader<?>> listReaderCache = new ConcurrentHashMap<>();
 
+  /**
+   * Create passing the ObjectMapper to use.
+   */
   public JacksonBodyAdapter(ObjectMapper mapper) {
     this.mapper = mapper;
   }
 
+  /**
+   * Create with a ObjectMapper that allows unknown properties and inclusion non empty.
+   */
+  public JacksonBodyAdapter() {
+    this.mapper = new ObjectMapper()
+      .configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false)
+      .configure(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS, false)
+      .configure(SerializationFeature.FAIL_ON_EMPTY_BEANS, false)
+      .setSerializationInclusion(JsonInclude.Include.NON_EMPTY);
+  }
+
   @Override
   public BodyWriter beanWriter(Class<?> cls) {
     return beanWriterCache.computeIfAbsent(cls, aClass -> {

client/src/test/java/io/avaje/http/client/DHttpApiTest.java

@@ -16,12 +16,9 @@ public class DHttpApiTest {
   @Test
   void test_github_listRepos() {
 
-    JacksonBodyAdapter bodyAdapter = new JacksonBodyAdapter(new ObjectMapper()
-      .configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false));
-
     final HttpClientContext clientContext = HttpClientContext.newBuilder()
       .baseUrl("https://api.github.com")
-      .bodyAdapter(bodyAdapter)
+      .bodyAdapter(new JacksonBodyAdapter())
       .build();
 
     DHttpApi httpApi = new DHttpApi();

client/src/test/java/io/avaje/http/client/RequestListenerTest.java

@@ -37,7 +37,7 @@ private HttpClientContext createClient(TDRequestListener tdRequestListener) {
     return HttpClientContext.newBuilder()
       .baseUrl(baseUrl)
       .requestListener(new RequestLogger())
-      .bodyAdapter(new JacksonBodyAdapter(new ObjectMapper()))
+      .bodyAdapter(new JacksonBodyAdapter())
       .requestListener(tdRequestListener)
       .build();
   }

client/src/test/java/io/avaje/http/client/RetryTest.java

@@ -15,7 +15,7 @@ public class RetryTest extends BaseWebTest {
   HttpClientContext initClientWithRetry() {
     return HttpClientContext.newBuilder()
       .baseUrl("http://localhost:8887")
-      .bodyAdapter(new JacksonBodyAdapter(new ObjectMapper()))
+      .bodyAdapter(new JacksonBodyAdapter())
       .requestListener(new RequestLogger())
       .retryHandler(new SimpleRetryHandler(4, 1))
       .requestIntercept(myIntercept)

client/src/test/java/org/example/github/GithubTest.java

@@ -1,7 +1,5 @@
 package org.example.github;
 
-import com.fasterxml.jackson.databind.DeserializationFeature;
-import com.fasterxml.jackson.databind.ObjectMapper;
 import io.avaje.http.client.HttpClientContext;
 import io.avaje.http.client.JacksonBodyAdapter;
 import io.avaje.http.client.RequestLogger;
@@ -14,16 +12,13 @@
 
 public class GithubTest {
 
-  private final JacksonBodyAdapter bodyAdapter = new JacksonBodyAdapter(new ObjectMapper()
-    .configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false));
-
   @Test
   @Disabled
   void test() throws InterruptedException {
 
     final HttpClientContext clientContext = HttpClientContext.newBuilder()
       .baseUrl("https://api.github.com")
-      .bodyAdapter(bodyAdapter)
+      .bodyAdapter(new JacksonBodyAdapter())
       .requestListener(new RequestLogger())
       .build();
 

test/src/test/java/example/github/GithubTest.java

@@ -1,7 +1,5 @@
 package example.github;
 
-import com.fasterxml.jackson.databind.DeserializationFeature;
-import com.fasterxml.jackson.databind.ObjectMapper;
 import com.google.gson.Gson;
 import io.avaje.http.client.BodyAdapter;
 import io.avaje.http.client.HttpClientContext;
@@ -40,8 +38,7 @@ private void assertListRepos(BodyAdapter bodyAdapter) {
   }
 
   private BodyAdapter jacksonBodyAdapter() {
-    return new JacksonBodyAdapter(new ObjectMapper()
-        .configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false));
+    return new JacksonBodyAdapter();
   }
 
   private BodyAdapter gsonBodyAdapter() {