Merge branch 'master' into alarso16/rpc-flakes

Author: alarso16

.avalanche-golangci.yml

@@ -77,7 +77,7 @@ linters:
     - spancheck
     - staticcheck
     - tagalign
-    # - testifylint
+    - testifylint
     - unconvert
     - unparam
     - unused
@@ -208,16 +208,16 @@ linters:
         - serialize
       strict: true
     testifylint:
-    # Enable all checkers (https://github.com/Antonboom/testifylint#checkers).
-    # Default: false
-    enable-all: true
-    # Disable checkers by name
-    # (in addition to default
-    #   suite-thelper
-    # ).
-    disable:
-      - go-require
-      - float-compare
+      # Enable all checkers (https://github.com/Antonboom/testifylint#checkers).
+      # Default: false
+      enable-all: true
+      # Disable checkers by name
+      # (in addition to default
+      #   suite-thelper
+      # ).
+      disable:
+        - go-require
+        - float-compare
     unused:
       # Mark all struct fields that have been written to as used.
       # Default: true

.github/CONTRIBUTING.md

@@ -34,22 +34,22 @@ Mocks are auto-generated using [mockgen](https://pkg.go.dev/go.uber.org/mock/moc
 - To **re-generate all mocks**, use the command below from the root of the project:
 
     ```sh
-    go generate -run "go.uber.org/mock/mockgen" ./...
+    go generate -run mockgen ./...
     ```
 
-- To **add** an interface that needs a corresponding mock generated:
-  - if the file `mocks_generate_test.go` exists in the package where the interface is located, either:
-    - modify its `//go:generate go run go.uber.org/mock/mockgen` to generate a mock for your interface (preferred); or
-    - add another `//go:generate go run go.uber.org/mock/mockgen` to generate a mock for your interface according to specific mock generation settings
-  - if the file `mocks_generate_test.go` does not exist in the package where the interface is located, create it with content (adapt as needed):
+* To **add** an interface that needs a corresponding mock generated:
+  * if the file `mocks_generate_test.go` exists in the package where the interface is located, either:
+    * modify its `//go:generate go tool -modfile=tools/go.mod mockgen` to generate a mock for your interface (preferred); or
+    * add another `//go:generate go tool -modfile=tools/go.mod mockgen` to generate a mock for your interface according to specific mock generation settings
+  * if the file `mocks_generate_test.go` does not exist in the package where the interface is located, create it with content (adapt as needed):
 
     ```go
     // Copyright (C) 2019-2025, Ava Labs, Inc. All rights reserved.
     // See the file LICENSE for licensing terms.
 
     package mypackage
 
-    //go:generate go run go.uber.org/mock/mockgen -package=${GOPACKAGE} -destination=mocks_test.go . YourInterface
+    //go:generate go tool -modfile=tools/go.mod mockgen -package=${GOPACKAGE} -destination=mocks_test.go . YourInterface
     ```
 
     Notes:
@@ -58,22 +58,28 @@ Mocks are auto-generated using [mockgen](https://pkg.go.dev/go.uber.org/mock/moc
 - To **remove** an interface from having a corresponding mock generated:
   1. Edit the `mocks_generate_test.go` file in the directory where the interface is defined
   1. If the `//go:generate` mockgen command line:
-      - generates a mock file for multiple interfaces, remove your interface from the line
-      - generates a mock file only for the interface, remove the entire line. If the file is empty, remove `mocks_generate_test.go` as well.
+      * generates a mock file for multiple interfaces, remove your interface from the line
+      * generates a mock file only for the interface, remove the entire line. If the file is empty, remove `mocks_generate_test.go` as well.
 
-## Documentation guidelines
+## Tool Dependencies
 
-- Code should be well commented, so it is easier to read and maintain.
- Any complex sections or invariants should be documented explicitly.
-- Code must be documented adhering to the official Go
-  [commentary](https://go.dev/doc/effective_go#commentary) guidelines.
-- Changes with user facing impact (e.g., addition or modification of flags and
- options) should be accompanied by a link to a pull request to the [avalanche-docs](https://github.com/ava-labs/avalanche-docs)
- repository. [example](https://github.com/ava-labs/avalanche-docs/pull/1119/files).
-- Changes that modify a package significantly or add new features should
- either update the existing or include a new `README.md` file in that package.
+This project uses `go tool` to manage development tool dependencies in `tools/go.mod`. This isolates tool dependencies from the main application dependencies and provides consistent, version-locked tools across the team.
 
-## Can I have feature X
+### Managing Tools
 
-Before you submit a feature request, please check and make sure that it isn't
-possible through some other means.
+* To **add a new tool**:
+  ```sh
+  go get -tool -modfile=tools/go.mod example.com/tool/cmd/toolname@version
+  ```
+
+* To **upgrade a tool**:
+  ```sh
+  go get -tool -modfile=tools/go.mod example.com/tool/cmd/toolname@newversion
+  ```
+
+* To **run a tool manually**:
+  ```sh
+  go tool -modfile=tools/go.mod toolname [args...]
+  ```
+
+Note: `ginkgo` remains in the main `go.mod` as it is used directly in e2e test code.

.github/workflows/ci.yml

@@ -19,6 +19,10 @@ jobs:
       - uses: actions/setup-go@v5
         with:
           go-version-file: "go.mod"
+          cache-dependency-path: |
+            go.sum
+            tools/go.sum
+            tools/legacy-golangci-lint.sum
       - name: Run all lint checks
         run: ./scripts/run_task.sh lint-all-ci
       - name: Check go.mod and go.sum are up-to-date
@@ -40,6 +44,9 @@ jobs:
       - uses: actions/setup-go@v5
         with:
           go-version-file: "go.mod"
+          cache-dependency-path: |
+            go.sum
+            tools/go.sum
       - run: go mod download
       - name: Check generated codec files are up to date
         run: ./scripts/run_task.sh check-generate-codec
@@ -60,10 +67,6 @@ jobs:
         with:
           fetch-depth: 0
           submodules: recursive
-      - name: Set up Go
-        uses: actions/setup-go@v5
-        with:
-          go-version-file: "go.mod"
       - name: Set up solc
         uses: ARR4N/setup-solc@v0.2.0
         with:
@@ -104,7 +107,7 @@ jobs:
       - name: Setup Contracts
         run: ./scripts/run_task.sh setup-contracts
       - name: Run Warp E2E Tests
-        uses: ava-labs/avalanchego/.github/actions/run-monitored-tmpnet-cmd@edff59906ed4d6334d9e591dcb9c85a144520600
+        uses: ava-labs/avalanchego/.github/actions/run-monitored-tmpnet-cmd@29b4e6bc541bcd913da6c51c1c5403fff2e377a4
         with:
           run: ./scripts/run_task.sh test-e2e-warp-ci
           artifact_prefix: warp
@@ -126,7 +129,7 @@ jobs:
         with:
           fetch-depth: 0
       - name: Run E2E Load Tests
-        uses: ava-labs/avalanchego/.github/actions/run-monitored-tmpnet-cmd@edff59906ed4d6334d9e591dcb9c85a144520600
+        uses: ava-labs/avalanchego/.github/actions/run-monitored-tmpnet-cmd@29b4e6bc541bcd913da6c51c1c5403fff2e377a4
         with:
           run: ./scripts/run_task.sh test-e2e-load-ci
           artifact_prefix: load

README.md

@@ -30,6 +30,7 @@ The Subnet EVM runs in a separate process from the main AvalancheGo process and
 [v0.7.7] AvalancheGo@v1.13.3 (Protocol Version: 42)
 [v0.7.8] AvalancheGo@v1.13.4 (Protocol Version: 43)
 [v0.7.9] AvalancheGo@v1.13.5 (Protocol Version: 43)
+[v0.8.0] AvalancheGo@v1.14.0 (Protocol Version: 44)
 ```
 
 ## API

RELEASES.md

@@ -1,8 +1,19 @@
 # Release Notes
 
-## [v0.7.10](https://github.com/ava-labs/subnet-evm/releases/tag/v0.7.10)
+## [v0.8.1](https://github.com/ava-labs/subnet-evm/releases/tag/v0.8.1)
 
 - Add pending releases here
+
+## [v0.8.0](https://github.com/ava-labs/subnet-evm/releases/tag/v0.8.0)
+
+This version is compatible with the Avalanche Granite upgrade. All mainnet nodes **MUST** update to a Granite compatible version prior to the upgrade activation time: November 19th, 2025 16:00 UTC.
+
+### AvalancheGo Compatibility
+
+The plugin version is **updated** to 44 and is compatible with AvalancheGo version v1.14.0.
+
+### Updates
+
 - Upgrade to Go version 1.24
 - ACP-226:
   - Set expected block gas cost to 0 in Granite network upgrade, removing block gas cost requirements for block building.

Taskfile.yml

@@ -67,10 +67,14 @@ tasks:
       - task: check-clean-branch
 
   check-go-mod-tidy:
-    desc: Checks that go.mod and go.sum are up-to-date (requires a clean git working tree)
+    desc: Checks that all go.mod and go.sum files are up-to-date (requires a clean git working tree)
     cmds:
       - cmd: go mod tidy
       - task: check-clean-branch
+      - cmd: cd tools && go mod tidy
+      - task: check-clean-branch
+      - cmd: cd tools && go mod tidy -modfile=legacy-golangci-lint.mod
+      - task: check-clean-branch
 
   coverage:
     desc: Display test coverage statistics from coverage.out file
@@ -80,19 +84,19 @@ tasks:
     desc: Generates fjl/gencodec files
     cmds:
       - cmd: grep -lr -E '^// Code generated by github\.com\/fjl\/gencodec\. DO NOT EDIT\.$' . | xargs -r rm
-      - cmd: go generate -run "github.com/fjl/gencodec" ./...
+      - cmd: go generate -run gencodec ./...
 
   generate-mocks:
     desc: Generates testing mocks
     cmds:
       - cmd: grep -lr -E '^// Code generated by MockGen\. DO NOT EDIT\.$' . | xargs -r rm
-      - cmd: go generate -run "go.uber.org/mock/mockgen" ./...
-  
+      - cmd: go generate -run mockgen ./...
+
   generate-rlp:
     desc: Generates rlp files
     cmds:
       - cmd: grep -lr -E '^// Code generated by rlpgen\. DO NOT EDIT.\.$' . | xargs -r rm
-      - cmd: go generate -run "github.com/ava-labs/libevm/rlp/rlpgen" ./...
+      - cmd: go generate -run rlpgen ./...
 
   install-avalanchego-release:
     desc: Download and install AvalancheGo release binary for testing, with fallback to building from source

accounts/abi/abi_extra_test.go

@@ -4,7 +4,6 @@
 package abi
 
 import (
-	"bytes"
 	"math/big"
 	"strings"
 	"testing"
@@ -82,14 +81,10 @@ func TestUnpackInputIntoInterface(t *testing.T) {
 				err = abi.UnpackInputIntoInterface(&v, "receive", data, test.strictMode) // skips 4 byte selector
 
 				if test.expectedErrorSubstring != "" {
-					require.Error(t, err)
 					require.ErrorContains(t, err, test.expectedErrorSubstring)
 				} else {
 					require.NoError(t, err)
-					// Verify unpacked values match input
-					require.Equal(t, v.Amount, input.Amount)
-					require.EqualValues(t, v.Amount, input.Amount)
-					require.True(t, bytes.Equal(v.Memo, input.Memo))
+					require.Equal(t, input, v)
 				}
 			})
 		}

accounts/abi/abi_test.go

@@ -1319,8 +1319,8 @@ func TestABI_PackEvent(t *testing.T) {
 				t.Fatal(err)
 			}
 
-			assert.EqualValues(t, test.expectedTopics, topics)
-			assert.EqualValues(t, test.expectedData, data)
+			assert.Equal(t, test.expectedTopics, topics)
+			assert.Equal(t, test.expectedData, data)
 		})
 	}
 }

bin/ginkgo

@@ -0,0 +1 @@
+../scripts/run_ginkgo.sh