QA - new import PK/PS wallets (#3359)

eunjisong · web-flow · commit 3257ad3456c6 · 2025-11-24T10:40:10.000-05:00
diff --git a/packages/core-mobile/app/new/common/components/SimpleTextInput.tsx b/packages/core-mobile/app/new/common/components/SimpleTextInput.tsx
@@ -15,7 +15,7 @@ export const SimpleTextInput = ({
   maxLength,
   autoFocus,
   secureTextEntry,
-  testID = 'text_input'
+  testID = 'input_text'
 }: {
   value: string
   onChangeText: (name: string) => void
diff --git a/packages/core-mobile/app/new/common/components/WalletCard.tsx b/packages/core-mobile/app/new/common/components/WalletCard.tsx
@@ -95,32 +95,34 @@ const WalletCard = ({
         </View>
 
         {showMoreButton && (
-          <DropdownMenu
-            groups={[
-              {
-                key: 'wallet-actions',
-                items: getDropdownItems(wallet)
-              }
-            ]}
-            onPressAction={(event: { nativeEvent: { event: string } }) =>
-              handleDropdownSelect(event.nativeEvent.event, wallet)
-            }>
-            <TouchableOpacity
-              hitSlop={8}
-              style={{
-                minHeight: 48,
-                paddingRight: 24,
-                paddingLeft: 12,
-                justifyContent: 'center',
-                alignItems: 'center'
-              }}>
-              <Icons.Navigation.MoreHoriz
-                color={colors.$textSecondary}
-                width={20}
-                height={20}
-              />
-            </TouchableOpacity>
-          </DropdownMenu>
+          <View accessible={true} testID={`more_icon__${wallet.name}`}>
+            <DropdownMenu
+              groups={[
+                {
+                  key: 'wallet-actions',
+                  items: getDropdownItems(wallet)
+                }
+              ]}
+              onPressAction={(event: { nativeEvent: { event: string } }) =>
+                handleDropdownSelect(event.nativeEvent.event, wallet)
+              }>
+              <TouchableOpacity
+                hitSlop={8}
+                style={{
+                  minHeight: 48,
+                  paddingRight: 24,
+                  paddingLeft: 12,
+                  justifyContent: 'center',
+                  alignItems: 'center'
+                }}>
+                <Icons.Navigation.MoreHoriz
+                  color={colors.$textSecondary}
+                  width={20}
+                  height={20}
+                />
+              </TouchableOpacity>
+            </DropdownMenu>
+          </View>
         )}
       </TouchableOpacity>
 
diff --git a/packages/core-mobile/app/new/routes/(signedIn)/(modals)/accountSettings/importPrivateKey.tsx b/packages/core-mobile/app/new/routes/(signedIn)/(modals)/accountSettings/importPrivateKey.tsx
@@ -72,6 +72,8 @@ const ImportPrivateKeyScreen = (): JSX.Element => {
 
     return (
       <Button
+        accessible={true}
+        testID="import_wallet"
         type="primary"
         size="large"
         onPress={handleImportPrivateKey}
diff --git a/packages/core-mobile/app/new/routes/(signedIn)/(modals)/accountSettings/importSeedWallet.tsx b/packages/core-mobile/app/new/routes/(signedIn)/(modals)/accountSettings/importSeedWallet.tsx
@@ -123,6 +123,8 @@ const ImportSeedWallet = (): React.JSX.Element => {
           gap: 12
         }}>
         <Button
+          accessible={true}
+          testID="import_wallet"
           size="large"
           type="primary"
           onPress={handleImport}
diff --git a/packages/core-mobile/app/new/routes/(signedIn)/(modals)/accountSettings/importWallet.tsx b/packages/core-mobile/app/new/routes/(signedIn)/(modals)/accountSettings/importWallet.tsx
@@ -79,7 +79,10 @@ const ImportWalletScreen = (): JSX.Element => {
       {
         title: 'Type in a recovery phrase',
         subtitle: (
-          <Text variant="caption" sx={{ fontSize: 12, paddingTop: 4 }}>
+          <Text
+            testID="import_recovery_phrase_btn"
+            variant="caption"
+            sx={{ fontSize: 12, paddingTop: 4 }}>
             Access with your recovery phrase
           </Text>
         ),
@@ -98,7 +101,10 @@ const ImportWalletScreen = (): JSX.Element => {
       {
         title: 'Import a private key',
         subtitle: (
-          <Text variant="caption" sx={{ fontSize: 12, paddingTop: 4 }}>
+          <Text
+            testID="import_private_key_btn"
+            variant="caption"
+            sx={{ fontSize: 12, paddingTop: 4 }}>
             Access with an existing private key
           </Text>
         ),
diff --git a/packages/core-mobile/app/new/routes/(signedIn)/(modals)/accountSettings/manageAccounts.tsx b/packages/core-mobile/app/new/routes/(signedIn)/(modals)/accountSettings/manageAccounts.tsx
@@ -172,7 +172,7 @@ const ManageAccountsScreen = (): React.JSX.Element => {
           },
           title: (
             <Text
-              testID={`manage_accounts_list__${account.name}`}
+              testID={`manage_accounts_list__${wallet.name}__${account.name}`}
               variant="body1"
               numberOfLines={2}
               sx={{
@@ -210,11 +210,11 @@ const ManageAccountsScreen = (): React.JSX.Element => {
           onPress: () => handleSetActiveAccount(account.id),
           accessory: (
             <TouchableOpacity
+              testID={`account_detail_icon__${wallet.name}_${account.name}`}
               hitSlop={16}
               sx={{ marginLeft: 4 }}
               onPress={() => gotoAccountDetails(account.id)}>
               <Icons.Alert.AlertCircle
-                testID={`account_detail_icon__${wallet.name}_${account.name}`}
                 color={colors.$textSecondary}
                 width={18}
                 height={18}
@@ -269,7 +269,7 @@ const ManageAccountsScreen = (): React.JSX.Element => {
           },
           title: (
             <Text
-              testID={`manage_accounts_list__${account.name}`}
+              testID={`private_key_account__${account.name}`}
               variant="body1"
               numberOfLines={2}
               sx={{
@@ -307,6 +307,7 @@ const ManageAccountsScreen = (): React.JSX.Element => {
           onPress: () => handleSetActiveAccount(account.id),
           accessory: (
             <TouchableOpacity
+              testID={`account_detail_icon__${account.name}`}
               hitSlop={16}
               sx={{ marginLeft: 4 }}
               onPress={() => gotoAccountDetails(account.id)}>
diff --git a/packages/core-mobile/app/new/routes/(signedIn)/(modals)/accountSettings/viewPrivateKey.tsx b/packages/core-mobile/app/new/routes/(signedIn)/(modals)/accountSettings/viewPrivateKey.tsx
@@ -68,6 +68,7 @@ const ViewPrivateKeyScreen = (): JSX.Element => {
             height: 120
           }}>
           <Text
+            testID="private_key"
             variant="mono"
             selectable
             sx={{
diff --git a/packages/core-mobile/e2e-appium/helpers/actions.ts b/packages/core-mobile/e2e-appium/helpers/actions.ts
@@ -242,8 +242,49 @@ async function verifyText(text: string, ele: ChainablePromiseElement) {
   )
 }
 
+async function pasteText(inputElement: ChainablePromiseElement, text: string) {
+  const encodedText = Buffer.from(text, 'utf-8').toString('base64')
+  if (driver.isIOS) {
+    await driver.setClipboard(encodedText)
+  } else {
+    await driver.setClipboard(encodedText, 'plaintext')
+  }
+
+  await waitFor(inputElement)
+  await inputElement.longPress({
+    x: 0,
+    y: 0,
+    duration: 600
+  })
+
+  if (driver.isIOS) {
+    await click(selectors.getByText('Paste'))
+  } else {
+    await tapXY(160, 650)
+  }
+
+  await tapEnterOnKeyboard()
+}
+
+async function tapXY(x: number, y: number) {
+  await driver.performActions([
+    {
+      type: 'pointer',
+      id: 'finger1',
+      parameters: { pointerType: 'touch' },
+      actions: [
+        { type: 'pointerMove', duration: 0, x, y },
+        { type: 'pointerDown', button: 0 },
+        { type: 'pause', duration: 100 },
+        { type: 'pointerUp', button: 0 }
+      ]
+    }
+  ])
+}
+
 export const actions = {
   type,
+  pasteText,
   tapNumberPad,
   verifyElementText,
   waitFor,
@@ -266,5 +307,6 @@ export const actions = {
   scrollTo,
   log,
   getAmount,
-  verifyText
+  verifyText,
+  tapXY
 }
diff --git a/packages/core-mobile/e2e-appium/helpers/warmup.ts b/packages/core-mobile/e2e-appium/helpers/warmup.ts
@@ -1,9 +1,7 @@
 import onboardingPage from '../pages/onboarding.page'
-import settingsPage from '../pages/settings.page'
 import { actions } from './actions'
 
 export default async function warmup(
-  addAccount = false,
   mnemonic = process.env.E2E_MNEMONIC as string
 ) {
   await onboardingPage.exitMetro()
@@ -19,9 +17,6 @@ export default async function warmup(
   await onboardingPage.tapNextBtnOnAvatarScreen()
   await onboardingPage.tapLetsGo()
   await onboardingPage.verifyLoggedIn()
-  if (addAccount) {
-    await settingsPage.createNthAccount()
-  }
 }
 
 export async function unlockLoggedIn(pin = '000000') {
diff --git a/packages/core-mobile/e2e-appium/locators/commonEls.loc.ts b/packages/core-mobile/e2e-appium/locators/commonEls.loc.ts
@@ -70,6 +70,7 @@ export default {
   usdcAddress: '0xb97ef9ef8734c71904d8002f8b6bc66dd9c48a6e',
   ethAddress: '0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2',
   delete: 'Delete',
+  remove: 'Remove',
   cancel: 'Cancel',
   approvePopupTitle: 'Do you approve this transaction?',
   approvePopupSpendTitle: 'Do you approve this spend limit?',
diff --git a/packages/core-mobile/e2e-appium/locators/onboarding.loc.ts b/packages/core-mobile/e2e-appium/locators/onboarding.loc.ts
@@ -3,6 +3,7 @@ export default {
   chooseWalletTitle: 'How would you like to access your existing wallet?',
   typeRecoverPhase: 'list_item__Type in a recovery phrase',
   recoveryPhraseInput: `text_area__recovery_phrase`,
+  enterRecoveryPhraseTitle: 'Enter your\nrecovery phrase',
   letsGo: 'lets_go_btn',
   unlockBtn: 'unlock_btn',
   agreeAndContinue: 'agreeAndContinueBtn',
diff --git a/packages/core-mobile/e2e-appium/locators/settings.loc.ts b/packages/core-mobile/e2e-appium/locators/settings.loc.ts
@@ -23,6 +23,8 @@ export default {
   selectCurrencyTitle: 'Select a currency',
   addWalletBtn: 'add_wallet_btn',
   createNewAccountBtn: 'create_new_account_btn',
+  importRecoveryPhraseBtn: 'import_recovery_phrase_btn',
+  importPrivateKeyBtn: 'import_private_key_btn',
   accountList: 'account_carousel_list',
   accountDetailIconIdPrefix: 'account_detail_icon__',
   accountCarouselItemIdPrefix: 'account_carousel_item__',
@@ -35,6 +37,13 @@ export default {
   unlockWithFaceId: 'Unlock with Face ID',
   showRecoveryPhrase: 'Show recovery phrase',
   showRecoveryPhraseTitle: 'Show recovery\nphrase',
+  privateKey: 'private_key',
+  copyKey: 'Copy key',
+  imported: 'Imported',
+  primary: 'Primary',
+  privateKeyDescription: 'private_key_description',
+  privateKeyWarning:
+    'Anyone with this private key can access the account(s) associated with it',
   showRecoveryPhraseDescription:
     'This phrase is your access key to your wallet. Carefully write it down and store it in a safe location.',
   showRecoveryPhraseWarning: 'Losing this phrase will result in lost funds',
@@ -50,6 +59,11 @@ export default {
   testnetAvatar: 'testnet_avatar',
   addressCopied: ' address copied',
   renameAccount: 'Rename account',
+  removeAccount: 'Remove account',
+  showPrivateKey: 'Show private key',
+  rename: 'Rename',
+  addAccountToThisWallet: 'Add account to this wallet',
+  removeWallet: 'Remove wallet',
   newAccountName: 'NewName Account 1',
   manageAccountsBtn: 'manage_accounts',
   emptyContacts: 'No saved addresses',
@@ -58,6 +72,7 @@ export default {
   connectedSites: 'Connected sites',
   disconnectAll: 'Disconnect all',
   manageAccountsTitle: 'Manage accounts',
+  importWalletBtn: 'import_wallet',
   addNetworkBtn: 'add_network_btn',
   chainID: 'chainId',
   arbCustomNetworkName: 'Arbitrum One',
diff --git a/packages/core-mobile/e2e-appium/pages/commonEls.page.ts b/packages/core-mobile/e2e-appium/pages/commonEls.page.ts
@@ -264,6 +264,10 @@ class CommonElsPage {
     return selectors.getByText(commonEls.hkd)
   }
 
+  listItem(name: string) {
+    return selectors.getById(`list_item__${name}`)
+  }
+
   async filter(
     item = commonEls.cChain_2,
     filterDropdown = this.filterDropdown
@@ -422,6 +426,18 @@ class CommonElsPage {
     }
   }
 
+  async tapRemoveAlert() {
+    if (driver.isIOS) {
+      try {
+        await actions.click(selectors.getById(commonEls.remove))
+      } catch (e) {
+        console.log('Appium handled the auto accept alerts')
+      }
+    } else {
+      await actions.click(selectors.getBySmartText(commonEls.remove))
+    }
+  }
+
   async verifyAccountName(expectedName: string, whichScreen = 'settings') {
     await actions.waitFor(selectors.getByText(expectedName), 30000)
     const UIaccountName = await this.getBalanceHeaderAccountName(whichScreen)
diff --git a/packages/core-mobile/e2e-appium/pages/onboarding.page.ts b/packages/core-mobile/e2e-appium/pages/onboarding.page.ts
@@ -21,6 +21,10 @@ class OnboardingPage {
     return selectors.getById(onboardingLoc.recoveryPhraseInput)
   }
 
+  get enterRecoveryPhraseTitle() {
+    return selectors.getByText(onboardingLoc.enterRecoveryPhraseTitle)
+  }
+
   get letsGo() {
     return selectors.getById(onboardingLoc.letsGo)
   }
@@ -141,7 +145,7 @@ class OnboardingPage {
 
   async enterRecoveryPhrase(recoveryPhrase: string) {
     await actions.type(this.recoveryPhraseInput, recoveryPhrase)
-    await actions.dismissKeyboard(onboardingLoc.recoveryPhraseInput)
+    await actions.tap(this.enterRecoveryPhraseTitle)
   }
 
   async enterWalletName(walletName: string | undefined = undefined) {
diff --git a/packages/core-mobile/e2e-appium/pages/settings.page.ts b/packages/core-mobile/e2e-appium/pages/settings.page.ts
diff --git a/packages/core-mobile/e2e-appium/specs/onboarding/metaMaskWallet.spec.ts b/packages/core-mobile/e2e-appium/specs/onboarding/metaMaskWallet.spec.ts
diff --git a/packages/core-mobile/e2e-appium/specs/settings/accounts.spec.ts b/packages/core-mobile/e2e-appium/specs/settings/accounts.spec.ts
diff --git a/packages/core-mobile/e2e-appium/specs/settings/importPK.spec.ts b/packages/core-mobile/e2e-appium/specs/settings/importPK.spec.ts
diff --git a/packages/core-mobile/e2e-appium/specs/settings/importPS.spec.ts b/packages/core-mobile/e2e-appium/specs/settings/importPS.spec.ts
diff --git a/packages/core-mobile/e2e/pages/settings.page.ts b/packages/core-mobile/e2e/pages/settings.page.ts
