Skip to content

Conversation

@RodrigoVillar
Copy link
Contributor

@RodrigoVillar RodrigoVillar commented Oct 30, 2025

Why this should be merged

Now that Firewood can be run in archival mode, we can use this option in the reexecution test.

How this works

Adds a firewood-archive config option for running Firewood in archive mode.

How this was tested

Ran reexecution test with firewood-archive set and verified that archival mode was enabled by running tree $CURRENT_STATE_DIR -L 3

├── chain-data-dir
│   └── firewood
│       ├── firewood.db # Firewood database
│       └── root_store # Archival state directory
└── db

Need to be documented in RELEASES.md?

No

@RodrigoVillar RodrigoVillar self-assigned this Nov 25, 2025
@RodrigoVillar RodrigoVillar added DO NOT MERGE This PR must not be merged in its current state loadtesting labels Nov 25, 2025
@RodrigoVillar
Copy link
Contributor Author

Note to reviewers: I've marked this PR as Do Not Merge since this will work only after the Coreth migration. However, this PR can still be reviewed since there will be 0 code changes after the Coreth migration.

@RodrigoVillar RodrigoVillar marked this pull request as ready for review November 25, 2025 14:20
Copilot AI review requested due to automatic review settings November 25, 2025 14:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for running Firewood in archival mode during reexecution tests by introducing a new configuration option.

  • Adds a firewood-with-archive configuration that enables Firewood's archival mode by disabling pruning
  • Allows testing of Firewood's archival state storage capabilities in the reexecution test suite

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@aaronbuchwald aaronbuchwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RodrigoVillar RodrigoVillar removed the DO NOT MERGE This PR must not be merged in its current state label Nov 25, 2025
@aaronbuchwald aaronbuchwald added this pull request to the merge queue Dec 1, 2025
Merged via the queue into master with commit 088b955 Dec 1, 2025
40 checks passed
@aaronbuchwald aaronbuchwald deleted the rodrigo/add-firewood-archive-config-in-reexecution branch December 1, 2025 15:31
@github-project-automation github-project-automation bot moved this to Done 🎉 in avalanchego Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done 🎉

Development

Successfully merging this pull request may close these issues.

4 participants