-
Notifications
You must be signed in to change notification settings - Fork 837
feat(reexecute/c): add firewood archival config option #4442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(reexecute/c): add firewood archival config option #4442
Conversation
|
Note to reviewers: I've marked this PR as Do Not Merge since this will work only after the Coreth migration. However, this PR can still be reviewed since there will be 0 code changes after the Coreth migration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for running Firewood in archival mode during reexecution tests by introducing a new configuration option.
- Adds a
firewood-with-archiveconfiguration that enables Firewood's archival mode by disabling pruning - Allows testing of Firewood's archival state storage capabilities in the reexecution test suite
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aaronbuchwald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Why this should be merged
Now that Firewood can be run in archival mode, we can use this option in the reexecution test.
How this works
Adds a
firewood-archiveconfig option for running Firewood in archive mode.How this was tested
Ran reexecution test with
firewood-archiveset and verified that archival mode was enabled by runningtree $CURRENT_STATE_DIR -L 3Need to be documented in RELEASES.md?
No