Remove duplicate header write (#4408)

Author: StephenButtolph

vms/rpcchainvm/ghttp/http_client.go

@@ -7,7 +7,10 @@ import (
 	"io"
 	"net/http"
 
+	"go.uber.org/zap"
+
 	"github.com/ava-labs/avalanchego/proto/pb/io/reader"
+	"github.com/ava-labs/avalanchego/utils/logging"
 	"github.com/ava-labs/avalanchego/vms/rpcchainvm/ghttp/greader"
 	"github.com/ava-labs/avalanchego/vms/rpcchainvm/ghttp/gresponsewriter"
 	"github.com/ava-labs/avalanchego/vms/rpcchainvm/grpcutils"
@@ -21,13 +24,15 @@ var _ http.Handler = (*Client)(nil)
 // Client is an http.Handler that talks over RPC.
 type Client struct {
 	client httppb.HTTPClient
+	log    logging.Logger
 }
 
 // NewClient returns an HTTP handler database instance connected to a remote
 // HTTP handler instance
-func NewClient(client httppb.HTTPClient) *Client {
+func NewClient(client httppb.HTTPClient, log logging.Logger) *Client {
 	return &Client{
 		client: client,
+		log:    log,
 	}
 }
 
@@ -190,8 +195,9 @@ func (c *Client) serveHTTPSimple(w http.ResponseWriter, r *http.Request) {
 	}
 
 	if err := convertWriteResponse(w, resp); err != nil {
-		http.Error(w, err.Error(), http.StatusInternalServerError)
-		return
+		c.log.Debug("failed sending HTTP response",
+			zap.Error(err),
+		)
 	}
 }
 

vms/rpcchainvm/ghttp/http_test.go

@@ -17,6 +17,7 @@ import (
 	"google.golang.org/grpc/credentials/insecure"
 	"google.golang.org/grpc/test/bufconn"
 
+	"github.com/ava-labs/avalanchego/utils/logging"
 	"github.com/ava-labs/avalanchego/vms/rpcchainvm/grpcutils"
 
 	httppb "github.com/ava-labs/avalanchego/proto/pb/http"
@@ -76,7 +77,7 @@ func TestRequestClientArbitrarilyLongBody(t *testing.T) {
 	conn, err := grpc.NewClient(listener.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials()))
 	require.NoError(err)
 
-	client := NewClient(httppb.NewHTTPClient(conn))
+	client := NewClient(httppb.NewHTTPClient(conn), logging.NoLog{})
 
 	w := &httptest.ResponseRecorder{}
 	r := &http.Request{
@@ -167,7 +168,7 @@ func TestHttpResponse(t *testing.T) {
 				Body:      bytes.NewBuffer(nil),
 			}
 
-			client := NewClient(httppb.NewHTTPClient(conn))
+			client := NewClient(httppb.NewHTTPClient(conn), logging.NoLog{})
 			request := &http.Request{
 				Body:   io.NopCloser(strings.NewReader("foo")),
 				Header: tt.requestHeaders,

vms/rpcchainvm/vm_client.go

@@ -382,7 +382,7 @@ func (vm *VMClient) CreateHandlers(ctx context.Context) (map[string]http.Handler
 		}
 
 		vm.conns = append(vm.conns, clientConn)
-		handlers[handler.Prefix] = ghttp.NewClient(httppb.NewHTTPClient(clientConn))
+		handlers[handler.Prefix] = ghttp.NewClient(httppb.NewHTTPClient(clientConn), vm.logger)
 	}
 	return handlers, nil
 }
@@ -403,7 +403,7 @@ func (vm *VMClient) NewHTTPHandler(ctx context.Context) (http.Handler, error) {
 	}
 
 	vm.conns = append(vm.conns, clientConn)
-	return ghttp.NewClient(httppb.NewHTTPClient(clientConn)), nil
+	return ghttp.NewClient(httppb.NewHTTPClient(clientConn), vm.logger), nil
 }
 
 func (vm *VMClient) WaitForEvent(ctx context.Context) (common.Message, error) {