test: separate block sync summary parse tests into a new file

Author: powerslider

vms/evm/sync/message/block_sync_summary_parser.go

@@ -4,13 +4,18 @@
 package message
 
 import (
+	"errors"
 	"fmt"
 
 	"github.com/ava-labs/libevm/crypto"
 
 	"github.com/ava-labs/avalanchego/ids"
 )
 
+// errInvalidBlockSyncSummary is returned when the provided bytes cannot be
+// parsed into a valid BlockSyncSummary.
+var errInvalidBlockSyncSummary = errors.New("invalid block sync summary")
+
 type BlockSyncSummaryParser struct{}
 
 func NewBlockSyncSummaryParser() *BlockSyncSummaryParser {
@@ -20,7 +25,7 @@ func NewBlockSyncSummaryParser() *BlockSyncSummaryParser {
 func (*BlockSyncSummaryParser) Parse(summaryBytes []byte, acceptImpl AcceptImplFn) (Syncable, error) {
 	summary := BlockSyncSummary{}
 	if _, err := Codec.Unmarshal(summaryBytes, &summary); err != nil {
-		return nil, fmt.Errorf("failed to parse syncable summary: %w", err)
+		return nil, fmt.Errorf("%w", errInvalidBlockSyncSummary)
 	}
 
 	summary.bytes = summaryBytes

vms/evm/sync/message/block_sync_summary_parser_test.go

@@ -0,0 +1,47 @@
+// Copyright (C) 2019-2025, Ava Labs, Inc. All rights reserved.
+// See the file LICENSE for licensing terms.
+
+package message
+
+import (
+	"context"
+	"testing"
+
+	"github.com/ava-labs/libevm/common"
+	"github.com/stretchr/testify/require"
+
+	"github.com/ava-labs/avalanchego/snow/engine/snowman/block"
+)
+
+func TestBlockSyncSummaryParser_ParseValid(t *testing.T) {
+	t.Parallel()
+
+	blockSyncSummary, err := NewBlockSyncSummary(common.Hash{1}, 2, common.Hash{3})
+	require.NoError(t, err)
+
+	parser := NewBlockSyncSummaryParser()
+	called := false
+	acceptImplTest := func(Syncable) (block.StateSyncMode, error) {
+		called = true
+		return block.StateSyncSkipped, nil
+	}
+	s, err := parser.Parse(blockSyncSummary.Bytes(), acceptImplTest)
+	require.NoError(t, err)
+	require.Equal(t, blockSyncSummary.GetBlockHash(), s.GetBlockHash())
+	require.Equal(t, blockSyncSummary.Height(), s.Height())
+	require.Equal(t, blockSyncSummary.GetBlockRoot(), s.GetBlockRoot())
+	require.Equal(t, blockSyncSummary.Bytes(), s.Bytes())
+
+	mode, err := s.Accept(context.Background())
+	require.NoError(t, err)
+	require.Equal(t, block.StateSyncSkipped, mode)
+	require.True(t, called)
+}
+
+func TestBlockSyncSummaryParser_ParseInvalid(t *testing.T) {
+	t.Parallel()
+
+	parser := NewBlockSyncSummaryParser()
+	_, err := parser.Parse([]byte("not-a-summary"), nil)
+	require.ErrorIs(t, err, errInvalidBlockSyncSummary)
+}

vms/evm/sync/message/block_sync_summary_test.go

@@ -4,17 +4,16 @@
 package message
 
 import (
-	"context"
 	"encoding/base64"
 	"testing"
 
 	"github.com/ava-labs/libevm/common"
 	"github.com/stretchr/testify/require"
-
-	"github.com/ava-labs/avalanchego/snow/engine/snowman/block"
 )
 
-func TestMarshalBlockSyncSummary(t *testing.T) {
+func TestBlockSyncSummary_MarshalGolden(t *testing.T) {
+	t.Parallel()
+
 	blockSyncSummary, err := NewBlockSyncSummary(common.Hash{1}, 2, common.Hash{3})
 	require.NoError(t, err)
 
@@ -24,22 +23,4 @@ func TestMarshalBlockSyncSummary(t *testing.T) {
 
 	expectedBase64Bytes := "AAAAAAAAAAAAAgEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="
 	require.Equal(t, expectedBase64Bytes, base64.StdEncoding.EncodeToString(blockSyncSummary.Bytes()))
-
-	parser := NewBlockSyncSummaryParser()
-	called := false
-	acceptImplTest := func(Syncable) (block.StateSyncMode, error) {
-		called = true
-		return block.StateSyncSkipped, nil
-	}
-	s, err := parser.Parse(blockSyncSummary.Bytes(), acceptImplTest)
-	require.NoError(t, err)
-	require.Equal(t, blockSyncSummary.GetBlockHash(), s.GetBlockHash())
-	require.Equal(t, blockSyncSummary.Height(), s.Height())
-	require.Equal(t, blockSyncSummary.GetBlockRoot(), s.GetBlockRoot())
-	require.Equal(t, blockSyncSummary.Bytes(), s.Bytes())
-
-	mode, err := s.Accept(context.TODO())
-	require.NoError(t, err)
-	require.Equal(t, block.StateSyncSkipped, mode)
-	require.True(t, called)
 }