[Bug]: tab.get_frame() Unable to locate frame

[sadikhan918]

Checklist before reporting

• I have searched for similar issues and didn't find a duplicate.
• I have updated to the latest version of pydoll to verify the issue still exists.

pydoll Version

2.12.0

Python Version

3.13.5

Operating System

Windows

Bug Description

For some reason I am unable to locate an iframe on a page using get_frame().

Steps to Reproduce

1. Open page with valid IFrame within it
2. Find the IFrame element using tab.find() or another method
3. Attempt to get the frame using tab.get_frame() and the element found in step 2

Code Example

try:
                    iframeElements = await page.find(tag_name='iframe', find_all=True)
                    for c in iframeElements : 
                        if 'someSpecificURL' in c._attributes['src']:
                            iframeElement = c
                            # The frame is being found here (not null)
                            break
                    iframe = await page.get_frame(iframeElement)
                   # continue to do things
                except Exception as e:
                    # Getting 'The target for the iframe was not found' Error


# another approach



                try:
                    iframeElement = await page.find(tag_name='iframe', title='someSpecificTitle')
                    # The frame is being found here (not null)
                    iframe = await page.get_frame(iframeElement)
                   # continue to do things
                except Exception as e:
                    # Getting 'The target for the iframe was not found' Error

Expected Behavior

The page should find the iframe.

Actual Behavior

The page throws an 'The target for the iframe was not found' error.

Relevant Log Output

Additional Context

No response

[thalissonvs]

Hello! can you share the target website?

[sadikhan918]

Hello! can you share the target website?

Unfortunately the IFrame only exists on a page within a certain timeframe (for about 10-20 minutes) and the URL of the page changes constantly. The next time it's going to be visible is tomorrow at 9am CT, I can paste a link then.

[theo-xx]

I have a similar problem when trying to deal with a page that has nested iframes. I tried to replicate the logic with this simple sample page: https://theo-xx.github.io/testing/nested_iframes_test.html

If I run this script:

 async with Chrome() as browser:
      tab = await browser.start()
      await browser.set_window_maximized()
      
      await tab.go_to('https://theo-xx.github.io/testing/nested_iframes_test.html')
      
      try:
          first_iframe_el = await tab.find(id='first-iframe')
          print(first_iframe_el)
          first_frame = await tab.get_frame(first_iframe_el)
          print('found!')
      except Exception as e:
          print(str(e))
          pass

the output is:

WebElement(id='first-iframe', src='https://theo-xx.github.io/testing/second_iframe.html', tag_name='iframe')(object_id=-8853449679070757543.1.1)
The target for the iframe was not found

so the element is found but get_frame() fails because the iframe src is not found in the browser targets in tab.py

targets = await self._browser.get_targets()
iframe_target = next((target for target in targets if target['url'] == frame_url), None)
if not iframe_target:
    raise IFrameNotFound('The target for the iframe was not found')

[thalissonvs]

Hello @sadikhan918 @theo-xx can you test the referenced PR and see if it works for you?

[sadikhan918]

@thalissonvs I tried with the new changes from the PR but it still looks like it isn't working. I modified the test code from above a bit:

async with Chrome() as browser:
    tab = await browser.start()
    # await browser.set_window_maximized()
    
    await tab.go_to('https://theo-xx.github.io/testing/nested_iframes_test.html')
    await asyncio.sleep(3)
    try:
        first_iframe_el = await tab.find(id='first-iframe')
        print(first_iframe_el)
        second_frame = await first_iframe_el.find(id='second-iframe')
        print(second_frame)
        # first_frame = await tab.get_frame(first_iframe_el)    --> Same error as before
        text = await second_frame.find(By.TAG_NAME, 'div')    # --> Error
        print('found!')
    except Exception as e:
        print(repr(e))
        pass

Results from this were:

WebElement(id='first-iframe', src='https://theo-xx.github.io/testing/second_iframe.html', tag_name='iframe')(object_id=-500680525498775758.1.1)
WebElement(id='second-iframe', src='https://example.com', tag_name='iframe')(object_id=-500680525498775758.3.2)
KeyError('result')

It's able to detect the inner IFrame but has issues with interacting, like trying to get the text content from the inner IFrame.

Using tab.get_frame() also fails, with the same error as before. The logs said it was deprecated, so I wanted to try both aproaches (using get_frame() and using the webelement directly) but it still failed.

[thalissonvs]

hmm, interesting. I'll push some commits soon

[thalissonvs]

Hello @sadikhan918, I think now it's working. Can you test again?

[sadikhan918]

@thalissonvs I tested the recent changes and they are working with the example above. The get_frame() method still says the frame is not found, but interacting with the frame directly as a WebElement works and finds the text content of the div. Thank you!