Skip to content

Commit f3b785e

Browse files
Refactor browser preferences types
1 parent b35cced commit f3b785e

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

pydoll/browser/interfaces.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
from pydoll.constants import PageLoadState
44

5+
from pydoll.browser.preference_types import BrowserPreferences
6+
57

68
class Options(ABC):
79
@property
@@ -25,7 +27,7 @@ def add_argument(self, argument: str):
2527

2628
@property
2729
@abstractmethod
28-
def browser_preferences(self) -> dict:
30+
def browser_preferences(self) -> BrowserPreferences:
2931
pass
3032

3133
@property

pydoll/browser/options.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from contextlib import suppress
2-
from typing import Any, Optional
2+
from typing import Any, Optional, cast
33

44
from pydoll.browser.interfaces import Options
55
from pydoll.browser.preference_types import PREFERENCE_SCHEMA, BrowserPreferences
@@ -154,7 +154,7 @@ def _set_pref_path(self, path: list, value):
154154
self._validate_pref_path(path)
155155
self._validate_pref_value(path, value)
156156

157-
d = self._browser_preferences
157+
d = cast(dict[str, Any], self._browser_preferences)
158158
for key in path[:-1]:
159159
d = d.setdefault(key, {})
160160
d[path[-1]] = value

pydoll/browser/preference_types.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
from typing import NotRequired, TypedDict
1+
from typing import TypedDict, Any
2+
from typing_extensions import NotRequired
23

34

45
class DownloadPreferences(TypedDict):

0 commit comments

Comments
 (0)