Merge pull request SortableJS#35 from bbenjamin/expand-isHtmlAttribute

Expand isHtmlAttribute

Author: David-Desmaisons

src/util/tags.js

@@ -127,7 +127,7 @@ function isTransition(name) {
 }
 
 function isHtmlAttribute(value) {
-  return ["id", "class"].includes(value) || value.startsWith("data-");
+  return ["id", "class", "role"].includes(value) || value.startsWith("data-") || value.startsWith("aria-");
 }
 
 export { isHtmlTag, isHtmlAttribute, isTransition };

tests/unit/util/tags.spec.js

@@ -1,4 +1,4 @@
-import { isHtmlTag, isTransition } from "@/util/tags";
+import { isHtmlTag, isTransition, isHtmlAttribute } from "@/util/tags";
 
 describe("isHtmlTag", () => {
   test.each([
@@ -17,6 +17,25 @@ describe("isHtmlTag", () => {
   )
 });
 
+describe("isHtmlAttribute", () => {
+  test.each([
+    ["class", true],
+    ["id", true],
+    ["role", true],
+    ["data-whatever", true],
+    ["aria-whatever", true],
+    ["notattribute", false],
+    ["href", false],
+    ["name", false],
+  ])(
+    "for %s returns %s",
+    (value, expected) =>{
+      const actual = isHtmlAttribute(value);
+      expect(actual).toEqual(expected);
+    }
+  )
+});
+
 describe("isTransition", () => {
   test.each([
     ["TransitionGroup", true],