fix: only warn on project-based rules in case there is a TypeScript file

Author: aminya

package.json

@@ -37,7 +37,6 @@
     "eslint-plugin-optimize-regex": "^1.2.1",
     "eslint-plugin-react": "^7.32.2",
     "eslint-plugin-yaml": "^0.5.0",
-    "fast-glob": "^3.2.12",
     "prettier": "2.8.8",
     "read-pkg-up": "^7.0.1",
     "semver": "^7.5.1",

pnpm-lock.yaml

@@ -1,21 +1,57 @@
 const { eslintRulesExtra } = require("./official-eslint-rules")
 const { pluginImportRulesExtra, pluginImportTypeScriptRulesExtra } = require("./plugin-import-rules")
 const { pluginNodeRules } = require("./plugin-node-rules")
-const glob = require("fast-glob")
+const fs = require("fs")
+const path = require("path")
 
-const project = ["./**/tsconfig.json", "!./**/node_modules/**/tsconfig.json"]
+const tsFiles = ["**/*.tsx", "**/*.ts"]
+const project = ["**/tsconfig.json", "!**/node_modules/**/tsconfig.json"]
 
-const projectedBasedRules = glob.sync(project, { onlyFiles: true, suppressErrors: true }).length !== 0
-if (!projectedBasedRules) {
-  console.warn(
-    "\x1b[33m%s\x1b[0m",
-    "No tsconfig.json found, disabling the project-based rules. To enable them, include all the **/*.ts(x)? files in the includes of the tsconfig.json files and run eslint again."
-  )
+function findOneFile(cwd, fileEnding, ignoredFolders) {
+  // recursively search the current folder for a file with the given fileEnding, ignoring the given folders, and return true as soon as one is found
+  const files = fs.readdirSync(cwd, { withFileTypes: true, recursive: false })
+  for (const file of files) {
+    if (file.isDirectory()) {
+      if (!ignoredFolders.includes(file.name)) {
+        // if the folder is not ignored, search it recursively
+        const found = findOneFile(path.join(cwd, file.name), fileEnding, ignoredFolders)
+        if (found) {
+          return true
+        }
+      }
+    } else if (file.name.endsWith(fileEnding)) {
+      // if the file ends with the given fileEnding, return true
+      return true
+    }
+  }
+  return false
+}
+
+/** Check if there are any tsconfig.json files */
+function disableProjectBasedRules() {
+  const hasTsFile = findOneFile(process.cwd(), ".ts", ["node_modules", ".git"])
+  const hasTsConfig = findOneFile(process.cwd(), "tsconfig.json", ["node_modules", ".git"])
+
+  // if there is no tsconfig.json file, but there are ts files, disable the project-based rules
+  const disable = !hasTsConfig && hasTsFile
+
+  if (disable) {
+    console.warn(
+      "\x1b[33m%s\x1b[0m",
+      "No tsconfig.json found, disabling the project-based rules. To enable them, include all the **/*.ts(x)? files in the includes of the tsconfig.json files and run eslint again."
+    )
+  }
+
+  return disable
 }
 
-// turn-off no-unused-vars for typescript files
-const typeScriptEslintExtra = { ...eslintRulesExtra }
-typeScriptEslintExtra["no-unused-vars"] = "off"
+function javaScriptRules() {
+  // turn-off no-unused-vars for typescript files
+  const typeScriptEslintExtra = { ...eslintRulesExtra }
+  typeScriptEslintExtra["no-unused-vars"] = "off"
+
+  return typeScriptEslintExtra
+}
 
 const pluginTypeScriptRulesExtra = {
   "@typescript-eslint/no-unused-vars": [
@@ -46,8 +82,9 @@ const pluginTypeScriptRulesExtra = {
   // "@typescript-eslint/prefer-string-starts-ends-with": "error",
 }
 
-const pluginTypeScriptProjectRules = projectedBasedRules
-  ? {
+const pluginTypeScriptProjectRules = disableProjectBasedRules()
+  ? {}
+  : {
       "@typescript-eslint/no-floating-promises": "error",
       "@typescript-eslint/no-unnecessary-boolean-literal-compare": "error",
       "@typescript-eslint/no-unnecessary-condition": "error",
@@ -60,11 +97,10 @@ const pluginTypeScriptProjectRules = projectedBasedRules
       "@typescript-eslint/strict-boolean-expressions": "error",
       "@typescript-eslint/switch-exhaustiveness-check": "warn",
     }
-  : {}
 
 exports.tsConfig = {
   // TypeScript files
-  files: ["**/*.tsx", "**/*.ts"],
+  files: tsFiles,
   parser: "@typescript-eslint/parser",
   parserOptions: {
     project,
@@ -80,7 +116,7 @@ exports.tsConfig = {
     "prettier",
   ],
   rules: {
-    ...typeScriptEslintExtra,
+    ...javaScriptRules(),
     ...pluginTypeScriptRulesExtra,
     ...pluginTypeScriptProjectRules,
     ...pluginNodeRules,