fix: combine tsc/ts search for TypeScript project-based rules

Author: aminya

src/typescript.cts

@@ -54,12 +54,7 @@ function disableProjectBasedRules() {
   )
 
   // check if there are any ts files
-  const [hasTscConfig, hasTsFile] = findFilesForGroups(cwd, [tscConfigFiles, tsFiles], ignore)
-
-  // return if there are no ts files
-  if (!hasTsFile) {
-    return true
-  }
+  const [hasTscConfig, hasTsFile] = findFilesForGroups(cwd, tscConfigFiles, tsFiles, ignore)
 
   // if there is no tsconfig.json file, but there are ts files, disable the project-based rules
   const disable = !hasTscConfig && hasTsFile

src/utils.cts

@@ -2,30 +2,47 @@ import { readdirSync } from "fs"
 import { join } from "path"
 import { default as anymatch } from "anymatch"
 
-export function findFilesForGroups(cwd: string, searchGroups: string[][], ignored: string[]) {
-  const status = searchGroups.map(() => false);
-  searchDirectory(cwd, status, searchGroups, ignored);
+export function findFilesForGroups(
+  cwd: string,
+  earlyExitSearchGroup: string[],
+  exhaustiveSearchGroup: string[],
+  ignored: string[],
+) {
+  const status = [false, false]
+  searchDirectory(cwd, status, earlyExitSearchGroup, exhaustiveSearchGroup, ignored)
 
   return status
 }
 
-function searchDirectory(directory: string, status: boolean[], searchGroups: string[][], ignored: string[]) {
-    // recursively search the current folder for a file with the given fileEnding, ignoring the given folders, and return true as soon as one is found
-  const files = readdirSync(directory, { withFileTypes: true, recursive: false });
+function searchDirectory(
+  directory: string,
+  status: boolean[],
+  earlyExitSearchGroup: string[],
+  exhaustiveSearchGroup: string[],
+  ignored: string[],
+): boolean {
+  // recursively search the current folder for a file with the given fileEnding, ignoring the given folders, and return true as soon as one is found
+  const files = readdirSync(directory, { withFileTypes: true, recursive: false })
   for (const file of files) {
-    const path = join(directory, file.name);
+    const path = join(directory, file.name)
     if (file.isDirectory()) {
+      // if the folder is not ignored, search it recursively
       if (!anymatch(ignored, path)) {
-        // if the folder is not ignored, search it recursively
-        searchDirectory(path, status, searchGroups, ignored);
+        if (searchDirectory(path, status, earlyExitSearchGroup, exhaustiveSearchGroup, ignored)) {
+          return true // exit
+        }
       }
     } else {
-      // for each search group, check if the file matches any of the patterns
-      for (const [index, searchGroup] of searchGroups.entries()) {
-        if (!status[index] && anymatch(searchGroup, path)) {
-          status[index] = true;
-        }
+      // check the early exit search group first
+      status[0] = status[0] || anymatch(exhaustiveSearchGroup, path)
+      if (status[0]) {
+        return true // exit
       }
+
+      // check the exhaustive search group
+      status[1] = status[1] || anymatch(exhaustiveSearchGroup, path)
     }
   }
+
+  return false // continue
 }