fix: fix bugs with solid and astro support

Author: aminya

.vscode/settings.json

@@ -1,5 +1,9 @@
 {
-  "cSpell.words": ["Globified", "globify"],
+  "cSpell.words": [
+    "astrojs",
+    "Globified",
+    "globify"
+  ],
   "explorer.fileNesting.patterns": {
     "index.js": "*.js"
   }

package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-atomic",
-  "version": "1.21.1",
+  "version": "1.21.2",
   "description": "Eslint config used in atom-ide-community",
   "repository": "https://github.com/atom-ide-community/eslint-config-atomic",
   "license": "MIT",
@@ -36,6 +36,7 @@
     "anymatch": "^3.1.3",
     "eslint": "^8.57.0",
     "eslint-config-prettier": "^9.1.0",
+    "eslint-plugin-astro": "^0.31.4",
     "eslint-plugin-html": "^8.0.0",
     "eslint-plugin-import": "^2.29.1",
     "eslint-plugin-json": "^3.1.0",
@@ -44,7 +45,6 @@
     "eslint-plugin-optimize-regex": "^1.2.1",
     "eslint-plugin-react": "^7.34.0",
     "eslint-plugin-solid": "^0.13.1",
-    "eslint-plugin-astro": "^0.31.4",
     "eslint-plugin-yaml": "^0.5.0",
     "globify-gitignore": "^1.0.3",
     "make-synchronous": "^0.1.1",

src/astro.cts

@@ -1,4 +1,5 @@
 import { Linter } from "eslint"
+import { pluginImportAstroRulesExtra } from "./plugin-import-rules.cjs"
 
 export const astroConfig: Linter.ConfigOverride<Linter.RulesRecord> = {
   // astro files
@@ -10,4 +11,10 @@ export const astroConfig: Linter.ConfigOverride<Linter.RulesRecord> = {
   },
   plugins: ["astro", "only-warn"],
   extends: ["plugin:astro/recommended"],
+  rules: {
+    ...pluginImportAstroRulesExtra
+  },
+  globals: {
+    astroHTML: "readonly",
+  },
 }

src/index-solid.cts

@@ -4,9 +4,13 @@ import { tsConfig } from "./typescript.cjs"
 
 const nonStrictConfig: Linter.Config = {
   ...base,
-  plugins: ["solid", ...(base.plugins ?? [])],
-  extends: ["plugin:solid/recommended", ...(base.extends ?? [])],
   overrides: [
+    // JavaScript:
+    {
+      files: ["*.js", "*.jsx", "*.mjs", "*.cjs"],
+      plugins: ["solid", ...(base.plugins ?? [])],
+      extends: ["plugin:solid/recommended", ...(base.extends ?? [])],
+    },
     // TypeScript:
     {
       ...tsConfig,

src/plugin-import-rules.cts

@@ -24,17 +24,26 @@ export const pluginImportTypeScriptRulesExtra: Linter.RulesRecord = {
   "import/namespace": "off",
 }
 
+export const pluginImportAstroRulesExtra: Linter.RulesRecord = {
+  // Buggy on Astro:
+  "import/default": "off",
+  "import/no-absolute-path": "off",
+  "import/no-unresolved": "off",
+  "import/no-extraneous-dependencies": "off",
+}
+
 export const pluginImportSettings = {
   "import/core-modules": ["atom", "electron"],
   // support TypeScript and Coffee importing
-  "import/extensions": [".ts", ".tsx", ".cts", ".mts", ".d.ts", ".js", ".cjs", ".mjs", ".jsx", ".coffee"],
+  "import/extensions": [".ts", ".tsx", ".cts", ".mts", ".d.ts", ".js", ".cjs", ".mjs", ".jsx", ".coffee", ".astro"],
   "import/external-module-folders": ["node_modules", "node_modules/@types"],
   "import/parsers": {
     "@typescript-eslint/parser": [".ts", ".tsx", ".d.ts"],
+    "astro-eslint-parser": [".astro"],
   },
   "import/resolver": {
     node: {
-      extensions: [".ts", ".tsx", ".cts", ".mts", ".d.ts", ".js", ".cjs", ".mjs", ".jsx", ".coffee"],
+      extensions: [".ts", ".tsx", ".cts", ".mts", ".d.ts", ".js", ".cjs", ".mjs", ".jsx", ".coffee", ".astro"],
     },
   },
 }