changesets

Author: Noviny

.changeset/little-scissors-bow/changes.json

@@ -0,0 +1,9 @@
+{
+  "releases": [
+    { "name": "extract-react-types", "type": "patch" },
+    { "name": "extract-react-types-loader", "type": "patch" },
+    { "name": "kind2string", "type": "patch" },
+    { "name": "pretty-proptypes", "type": "patch" }
+  ],
+  "dependents": []
+}

.changeset/little-scissors-bow/changes.md

@@ -0,0 +1 @@
+Remove dangerous debug code that broke everything

packages/extract-react-types/__snapshots__/test.js.snap

@@ -4970,6 +4970,41 @@ Object {
 }
 `;
 
+exports[`typescript React.ComponentType 1`] = `
+Object {
+  "component": Object {
+    "kind": "generic",
+    "name": Object {
+      "kind": "id",
+      "name": "Component",
+      "type": null,
+    },
+    "value": Object {
+      "kind": "object",
+      "members": Array [
+        Object {
+          "key": Object {
+            "kind": "id",
+            "name": "children",
+          },
+          "kind": "property",
+          "optional": false,
+          "value": Object {
+            "kind": "generic",
+            "value": Object {
+              "kind": "id",
+              "name": "React.ComponentType",
+            },
+          },
+        },
+      ],
+      "referenceIdName": "Props",
+    },
+  },
+  "kind": "program",
+}
+`;
+
 exports[`typescript indexed imported type 1`] = `
 Object {
   "component": Object {

packages/extract-react-types/src/index.js

@@ -798,10 +798,9 @@ converters.Identifier = (path, context): K.Id => {
       }
 
       if (bindingPath) {
-        if (name === 'SomethingId')
-          if (bindingPath.kind === 'module') {
-            bindingPath = bindingPath.path;
-          }
+        if (bindingPath.kind === 'module') {
+          bindingPath = bindingPath.path;
+        }
 
         // If path is a descendant of bindingPath and share the same name, this is a recursive type.
         if (path.isDescendant(bindingPath) && bindingPath.get('id').node.name === name) {

packages/extract-react-types/test.js

@@ -408,6 +408,21 @@ const TESTS = [
     }
   `
   },
+  {
+    name: 'typescript React.ComponentType',
+    typeSystem: 'typescript',
+    code: `
+    import React from 'react';
+
+    type Props = {
+      children: React.ComponentType,
+    };
+
+    class Component extends React.Component<Props> {
+
+    }
+  `
+  },
   {
     name: 'ts custom prop',
     typeSystem: 'typescript',