[pretty-proptypes]: resolve thrown error on null values in members array (\w tests) (#96)

* resolve thrown error on null values in members array, add tests

* add console.error to make the error trackable

* add changeset

Author: gwyneplaine

.changeset/wet-masks-taste/changes.json

@@ -0,0 +1 @@
+{ "releases": [{ "name": "pretty-proptypes", "type": "patch" }], "dependents": [] }

.changeset/wet-masks-taste/changes.md

@@ -0,0 +1 @@
+Work around added in object converter to not throw on null value in members list

packages/pretty-proptypes/src/PrettyConvert/converters.js

@@ -104,7 +104,14 @@ export const converters: { [string]: ?Function } = {
     if (type.members.length === 0) {
       return <components.Type>Object</components.Type>;
     }
-    let simpleObj = type.members.filter(mem => !SIMPLE_TYPES.includes(mem.kind)).length === 0;
+    let simpleObj = type.members.filter(mem => {
+      if (mem === null) {
+        /** if the member is null, error out */
+        console.error(`null property in members of ${type.referenceIdName} of kind ${type.kind} `)
+        return false;
+      }
+      return !SIMPLE_TYPES.includes(mem.kind)
+    }).length === 0;
 
     if (simpleObj) {
       return <components.Type>{convert(type)}</components.Type>;
@@ -114,7 +121,7 @@ export const converters: { [string]: ?Function } = {
       <span>
         <AddBrackets BracketStyler={components.TypeMeta} openBracket="{" closeBracket="}">
           <components.Indent>
-            {type.members.map(prop => {
+            {type.members.filter(p => p).map(prop => {
               if (prop.kind === 'spread') {
                 const nestedObj = resolveFromGeneric(prop.value);
                 // Spreads almost always resolve to an object, but they can
@@ -237,4 +244,5 @@ const prettyConvert = (type: K.AnyKind, components: Components, depth: number =
   return converter(type, components, depth);
 };
 
+
 export default prettyConvert;

packages/pretty-proptypes/src/PrettyConvert/converters.test.js

@@ -122,9 +122,35 @@ test('resolve generic of array', () => {
   expect(wrapper.html().includes('string')).toBeTruthy();
 });
 
+test('objects with null members do not throw', () => {
+  const type = {
+    kind: "object",
+    members: [
+      {
+        kind: "property",
+        optional: false,
+        key: {
+          kind: "id",
+          name: "children"
+        },
+        value: {
+          kind: "generic",
+          value: {
+            kind: "id",
+            name: "React.ReactNode"
+          }
+        }
+      },
+      null
+    ],
+    referenceIdName: "LabelTextProps"
+  }
+  expect(() => prettyConvert(type, components)).not.toThrow();
+})
+
 test.skip('object with spread object', () => {
   let values = getSingleDefault(`{ ...something, c: 'something' }`);
-  let wrapper = shallow(prettyConvert(values, components));
+  let wrapper = shallow(prettyConvert(`{ ...something, c: 'something' }`, components));
   expect(wrapper).toBe('something');
 });
 test.skip('resolve generic of array with complex type', () => {