[BitBucket] Fix missing function for paged API. (#630)

* [BitBucket] Fix missing function for paged API.

Fix wrong function calls found while implementing tests.

* Change api_root for cloud.  

Api root for data center (cloud and not https://api.bitbucket.org) shall be `api_root` as in 1.17.7.

Author: Spacetown

atlassian/bitbucket/__init__.py

@@ -18,7 +18,7 @@ def __init__(self, url, *args, **kwargs):
         if "api_version" not in kwargs:
             kwargs["api_version"] = "2.0" if "cloud" in kwargs and kwargs["cloud"] else "1.0"
         if "cloud" in kwargs:
-            kwargs["api_root"] = "" if "api.bitbucket.org" in url else "api"
+            kwargs["api_root"] = "" if "api.bitbucket.org" in url else "rest/api"
         super(Bitbucket, self).__init__(url, *args, **kwargs)
 
     def markup_preview(self, data):
@@ -2343,7 +2343,7 @@ def get_pipeline_step(self, workspace, repository_slug, pipeline_uuid, step_uuid
             .workspaces.get(workspace)
             .repositories.get(repository_slug)
             .pipelines.get(pipeline_uuid)
-            .steps(step_uuid)
+            .step(step_uuid)
             .data
         )
 
@@ -2363,7 +2363,7 @@ def get_pipeline_step_log(self, workspace, repository_slug, pipeline_uuid, step_
             .workspaces.get(workspace)
             .repositories.get(repository_slug)
             .pipelines.get(pipeline_uuid)
-            .steps(step_uuid)
+            .step(step_uuid)
             .log()
         )
 
@@ -2467,6 +2467,7 @@ def delete_issue(self, workspace, repository_slug, id):
             .repositories.get(repository_slug)
             .issues.get(id)
             .delete()
+            .data
         )
 
     @deprecated(
@@ -2572,6 +2573,7 @@ def delete_branch_restriction(self, workspace, repository_slug, id):
             .repositories.get(repository_slug)
             .branch_restrictions.get(id)
             .delete()
+            .data
         )
 
     @deprecated(

atlassian/bitbucket/base.py

@@ -30,6 +30,37 @@ def __init__(self, url, *args, **kwargs):
     def __str__(self):
         return PrettyPrinter(indent=4).pformat(self.__data)
 
+    def _get_paged(self, url, params={}, data=None, flags=None, trailing=None, absolute=False):
+        """
+        Used to get the paged data
+        :param url:       The url to retrieve.
+        :param params:    The parameters (optional).
+        :param data:      The data (optional).
+
+        :return: nothing
+        """
+
+        while True:
+            response = self.get(url, trailing=trailing, params=params, data=data, flags=flags, absolute=absolute)
+            if "values" not in response:
+                return
+
+            for value in response.get("values", []):
+                yield value
+
+            if self.cloud:
+                url = response.get("next")
+                if url is None:
+                    break
+                # From now on we have absolute URLs
+                absolute = True
+            else:
+                if response.get("nextPageStart") is None:
+                    break
+                params["start"] = response.get("nextPageStart")
+
+        return
+
     @property
     def _new_session_args(self):
         return dict(

atlassian/rest_client.py

@@ -158,7 +158,7 @@ def resource_url(self, resource, api_root=None, api_version=None):
 
     @staticmethod
     def url_joiner(url, path, trailing=None):
-        url_link = "/".join(s.strip("/") for s in [url, path] if s is not None)
+        url_link = "/".join(str(s).strip("/") for s in [url, path] if s is not None)
         if trailing:
             url_link += "/"
         return url_link