Skip to content

fix: update handlePkceVerifier to prevent missing code_challenge #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: update handlePkceVerifier to prevent missing code_challenge #465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/runtime/server/lib/oauth/azureb2c.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export function defineOAuthAzureB2CEventHandler({ config, onSuccess, onError }:
config.scope = [...new Set(config.scope)]

// Create pkce verifier
const verifier = await handlePkceVerifier(event)
const verifier = await handlePkceVerifier(event, { onlyConsume: !!query.code })
const state = await handleState(event)

if (!query.code) {
Expand Down
2 changes: 1 addition & 1 deletion src/runtime/server/lib/oauth/kick.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export function defineOAuthKickEventHandler({ config, onSuccess, onError }: OAut
}

// Create pkce verifier
const verifier = await handlePkceVerifier(event)
const verifier = await handlePkceVerifier(event, { onlyConsume: !!query.code })

const redirectURL = config.redirectURL || getOAuthRedirectURL(event)

Expand Down
2 changes: 1 addition & 1 deletion src/runtime/server/lib/oauth/zitadel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export function defineOAuthZitadelEventHandler({ config, onSuccess, onError }: O
const redirectURL = config.redirectURL || getOAuthRedirectURL(event)

// Create pkce verifier
const verifier = await handlePkceVerifier(event)
const verifier = await handlePkceVerifier(event, { onlyConsume: !!query.code })
const state = await handleState(event)

if (!query.code) {
Expand Down
7 changes: 6 additions & 1 deletion src/runtime/server/lib/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,10 +181,15 @@ function getRandomBytes(size: number = 32) {
return getRandomValues(new Uint8Array(size))
}

export async function handlePkceVerifier(event: H3Event) {
export async function handlePkceVerifier(
event: H3Event,
{ onlyConsume }: { onlyConsume?: boolean } = {},
) {
let verifier = getCookie(event, 'nuxt-auth-pkce')
if (verifier) {
deleteCookie(event, 'nuxt-auth-pkce')
}
if (onlyConsume) {
return { code_verifier: verifier }
}

Expand Down