Merge remote-tracking branch 'upstream/main'

Author: dchourasia

.github/workflows/code-quality.yaml

@@ -48,14 +48,17 @@ jobs:
         run: uv version
 
       - name: Install deps
+        id: install-deps
         run: uv sync --locked
 
       # https://github.com/pre-commit/action
       - name: Run pre-commit on all files
+        if: ${{ steps.install-deps.conclusion == 'success' && !cancelled() }}
         run: |
           uv run pre-commit run --all-files
 
-      - run: uv run pytest
+      - run: make test
+        if: ${{ steps.install-deps.conclusion == 'success' && !cancelled() }}
 
   code-static-analysis:
     runs-on: ubuntu-latest

.tekton/odh-base-image-cuda-py312-ubi9-push.yaml

@@ -1,5 +1,6 @@
 apiVersion: tekton.dev/v1
 kind: PipelineRun
+# test
 metadata:
   annotations:
     build.appstudio.openshift.io/repo: https://github.com/opendatahub-io/notebooks?rev={{revision}}

.tekton/odh-base-image-rocm-py312-ubi9-push.yaml

@@ -1,5 +1,6 @@
 apiVersion: tekton.dev/v1
 kind: PipelineRun
+# test
 metadata:
   annotations:
     build.appstudio.openshift.io/repo: https://github.com/opendatahub-io/notebooks?rev={{revision}}

Makefile

@@ -512,3 +512,8 @@ endif
 .PHONY: print-release
 print-release:
 	@echo "$(RELEASE)"
+
+.PHONY: test
+test:
+	@echo "Running quick static tests"
+	uv run pytest

README.md

@@ -16,7 +16,7 @@ Make sure the following tools are installed in your environment:
  - podman/docker
  - python
  - pipenv
- - make
+ - make (on macOS install/use: gmake)
  - curl
 
 ### Installation
@@ -76,9 +76,11 @@ uv sync --locked
 By completing configuration in previous section, you are able to run any tests that don't need to start a container using following command:
 
 ```
-uv run pytest
+make test
 ```
 
+Use `gmake test` if you're on macOS.
+
 ##### Container selftests
 
 We're using [Testcontainers.com](https://testcontainers.com/) to run containers from Python tests.