Merge pull request #89 from atc-net/bug/fix-nuget-version-updater

Bug fix for nuget version updates - do not upgrade on major version change

Author: davidkallesen

Directory.Build.props

@@ -43,10 +43,10 @@
   <ItemGroup Label="Code Analyzers">
     <PackageReference Include="AsyncFixer" Version="1.5.1" PrivateAssets="All" />
     <PackageReference Include="Asyncify" Version="0.9.7" PrivateAssets="All" />
-    <PackageReference Include="Meziantou.Analyzer" Version="1.0.697" PrivateAssets="All" />
+    <PackageReference Include="Meziantou.Analyzer" Version="1.0.698" PrivateAssets="All" />
     <PackageReference Include="SecurityCodeScan.VS2019" Version="5.6.2" PrivateAssets="All" />
     <PackageReference Include="StyleCop.Analyzers" Version="1.1.118" PrivateAssets="All" />
-    <PackageReference Include="SonarAnalyzer.CSharp" Version="8.36.1.44192" PrivateAssets="All" />
+    <PackageReference Include="SonarAnalyzer.CSharp" Version="8.37.0.45539" PrivateAssets="All" />
   </ItemGroup>
 
 </Project>

src/Atc.CodingRules.AnalyzerProviders/Atc.CodingRules.AnalyzerProviders.csproj

@@ -9,7 +9,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Atc" Version="2.0.95" />
+    <PackageReference Include="Atc" Version="2.0.115" />
     <PackageReference Include="HtmlAgilityPack" Version="1.11.42" />
   </ItemGroup>
 

src/Atc.CodingRules.Updater.CLI/Atc.CodingRules.Updater.CLI.csproj

@@ -13,9 +13,9 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Atc" Version="2.0.95" />
-    <PackageReference Include="Atc.Console.Spectre" Version="2.0.95" />
-    <PackageReference Include="EPPlus" Version="5.8.6" />
+    <PackageReference Include="Atc" Version="2.0.115" />
+    <PackageReference Include="Atc.Console.Spectre" Version="2.0.115" />
+    <PackageReference Include="EPPlus" Version="5.8.8" />
     <PackageReference Include="Microsoft.Extensions.Hosting" Version="6.0.1" />
   </ItemGroup>
 

src/Atc.CodingRules.Updater/Atc.CodingRules.Updater.csproj

@@ -5,9 +5,9 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Atc" Version="2.0.95" />
-    <PackageReference Include="Atc.DotNet" Version="2.0.95" />
-    <PackageReference Include="Atc.Console.Spectre" Version="2.0.95" />
+    <PackageReference Include="Atc" Version="2.0.115" />
+    <PackageReference Include="Atc.DotNet" Version="2.0.115" />
+    <PackageReference Include="Atc.Console.Spectre" Version="2.0.115" />
   </ItemGroup>
 
   <ItemGroup>

src/Atc.CodingRules.Updater/DirectoryBuildPropsHelper.cs

@@ -198,7 +198,7 @@ private static List<DotnetNugetPackage> GetPackageReferencesThatNeedsToBeUpdated
                     var latestVersion = AtcApiNugetClientHelper.GetLatestVersionForPackageId(logger, item.PackageId, CancellationToken.None);
 
                     if (latestVersion is not null &&
-                        latestVersion.GreaterThan(version, significantParts: 4, startingPart: 2))
+                        latestVersion.IsNewerThan(version, withinMinorReleaseOnly: true))
                     {
                         result.Add(
                             new DotnetNugetPackage(

src/Atc.CodingRules.Updater/Models/DotnetNugetPackage.cs

@@ -1,30 +1,29 @@
-namespace Atc.CodingRules.Updater.Models
+namespace Atc.CodingRules.Updater.Models;
+
+public class DotnetNugetPackage
 {
-    public class DotnetNugetPackage
+    public DotnetNugetPackage(string packageId, Version currentVersion)
     {
-        public DotnetNugetPackage(string packageId, Version currentVersion)
-        {
-            this.PackageId = packageId;
-            this.Version = currentVersion;
-            this.NewestVersion = currentVersion;
-        }
+        this.PackageId = packageId;
+        this.Version = currentVersion;
+        this.NewestVersion = currentVersion;
+    }
 
-        public DotnetNugetPackage(string packageId, Version currentVersion, Version newestVersion)
-        {
-            this.PackageId = packageId;
-            this.Version = currentVersion;
-            this.NewestVersion = newestVersion;
-        }
+    public DotnetNugetPackage(string packageId, Version currentVersion, Version newestVersion)
+    {
+        this.PackageId = packageId;
+        this.Version = currentVersion;
+        this.NewestVersion = newestVersion;
+    }
 
-        public string PackageId { get; }
+    public string PackageId { get; }
 
-        public Version Version { get; }
+    public Version Version { get; }
 
-        public Version NewestVersion { get; set; }
+    public Version NewestVersion { get; set; }
 
-        public bool IsNewest => Version >= NewestVersion;
+    public bool IsNewest => Version >= NewestVersion;
 
-        public override string ToString()
-            => $"{nameof(PackageId)}: {PackageId}, {nameof(Version)}: {Version}, {nameof(NewestVersion)}: {NewestVersion}, {nameof(IsNewest)}: {IsNewest}";
-    }
+    public override string ToString()
+        => $"{nameof(PackageId)}: {PackageId}, {nameof(Version)}: {Version}, {nameof(NewestVersion)}: {NewestVersion}, {nameof(IsNewest)}: {IsNewest}";
 }

src/Atc.CodingRules/Atc.CodingRules.csproj

@@ -7,7 +7,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Atc" Version="2.0.95" />
+    <PackageReference Include="Atc" Version="2.0.115" />
   </ItemGroup>
 
 </Project>

test/Atc.CodingRules.AnalyzerProviders.Tests/Atc.CodingRules.AnalyzerProviders.Tests.csproj

@@ -6,7 +6,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Atc.XUnit" Version="2.0.93" />
+    <PackageReference Include="Atc.XUnit" Version="2.0.115" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.1.0" />
     <PackageReference Include="xunit" Version="2.4.1" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.3">