feat: Improve handle temporarySuppressions when MSB and NU errors is found

Author: davidkallesen

src/Atc.CodingRules.Updater.CLI/ProjectHelper.cs

@@ -1,4 +1,3 @@
-using Atc.CodingRules.Updater.CLI.Models.Options;
 using Atc.DotNet;
 using OfficeOpenXml;
 using OfficeOpenXml.Style;
@@ -198,40 +197,64 @@ private static async Task HandleTemporarySuppressions(
             return;
         }
 
-        var suppressionLinesPrAnalyzer = GetSuppressionLines(analyzerProviderBaseRules, buildResult);
-        if (!suppressionLinesPrAnalyzer.Any())
+        if (buildResult.Any(x => x.Key.StartsWith("MSB", StringComparison.Ordinal)))
         {
-            logger.LogTrace("     No suppressions to add.");
-            return;
-        }
-
-        await EditorConfigHelper.UpdateRootFileAddCustomAtcAutogeneratedRuleSuppressions(projectPath, suppressionLinesPrAnalyzer);
-        for (var i = 0; i < MaxNumberOfTimesToBuild; i++)
-        {
-            var runAgain = await BuildAndCollectErrorsAgainAndUpdateFile(
-                logger,
-                projectPath,
-                2 + i,
-                buildFile,
-                buildResult,
-                analyzerProviderBaseRules);
+            var errorTypes = buildResult
+                .Where(x => x.Key.StartsWith("MSB", StringComparison.Ordinal))
+                .Select(x => x.Key)
+                .OrderBy(x => x)
+                .ToList();
 
-            if (!runAgain)
-            {
-                break;
-            }
+            logger.LogWarning($"     MSB-errors ({string.Join(',', errorTypes)}) was found, please correct them manually first and try again.");
         }
-
-        suppressionLinesPrAnalyzer = GetSuppressionLines(analyzerProviderBaseRules, buildResult);
-        if (temporarySuppressionsPath is not null)
+        else if (buildResult.Any(x => x.Key.StartsWith("NU", StringComparison.Ordinal)))
         {
-            await EditorConfigHelper.WriteAllText(projectPath, rootEditorConfigContent);
-            await CreateSuppressionsFileInTempPath(logger, temporarySuppressionsPath, temporarySuppressionAsExcel, suppressionLinesPrAnalyzer);
+            var errorTypes = buildResult
+                .Where(x => x.Key.StartsWith("NU", StringComparison.Ordinal))
+                .Select(x => x.Key)
+                .OrderBy(x => x)
+                .ToList();
+
+            logger.LogWarning($"     NU-errors ({string.Join(',', errorTypes)}) was found, please correct them manually first and try again.");
         }
         else
         {
-            var totalSuppressions = suppressionLinesPrAnalyzer.Sum(x => x.Item2.Count);
-            logger.LogInformation($"{EmojisConstants.FileUpdated}   [yellow]/[/]{EditorConfigHelper.FileName} is updated with {totalSuppressions} suppressions");
+            var suppressionLinesPrAnalyzer = GetSuppressionLines(analyzerProviderBaseRules, buildResult);
+            if (suppressionLinesPrAnalyzer.Any())
+            {
+                await EditorConfigHelper.UpdateRootFileAddCustomAtcAutogeneratedRuleSuppressions(projectPath, suppressionLinesPrAnalyzer);
+                for (var i = 0; i < MaxNumberOfTimesToBuild; i++)
+                {
+                    var runAgain = await BuildAndCollectErrorsAgainAndUpdateFile(
+                        logger,
+                        projectPath,
+                        2 + i,
+                        buildFile,
+                        buildResult,
+                        analyzerProviderBaseRules);
+
+                    if (!runAgain)
+                    {
+                        break;
+                    }
+                }
+
+                suppressionLinesPrAnalyzer = GetSuppressionLines(analyzerProviderBaseRules, buildResult);
+                if (temporarySuppressionsPath is not null)
+                {
+                    await EditorConfigHelper.WriteAllText(projectPath, rootEditorConfigContent);
+                    await CreateSuppressionsFileInTempPath(logger, temporarySuppressionsPath, temporarySuppressionAsExcel, suppressionLinesPrAnalyzer);
+                }
+                else
+                {
+                    var totalSuppressions = suppressionLinesPrAnalyzer.Sum(x => x.Item2.Count);
+                    logger.LogInformation($"{EmojisConstants.FileUpdated}   [yellow]/[/]{EditorConfigHelper.FileName} is updated with {totalSuppressions} suppressions");
+                }
+            }
+            else
+            {
+                logger.LogTrace("     No suppressions to add.");
+            }
         }
 
         stopwatch.Stop();