Skip to content

Commit f181331

Browse files
svats0001jchrys
authored andcommitted
Fixed integration test
1 parent b20cc05 commit f181331

File tree

3 files changed

+11
-24
lines changed

3 files changed

+11
-24
lines changed

r2dbc-mysql/src/main/java/io/asyncer/r2dbc/mysql/Capability.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -181,22 +181,11 @@ public final class Capability {
181181
TRANSACTIONS | SECURE_SALT | MULTI_STATEMENTS | MULTI_RESULTS | PS_MULTI_RESULTS |
182182
PLUGIN_AUTH | CONNECT_ATTRS | VAR_INT_SIZED_AUTH | SESSION_TRACK | DEPRECATE_EOF | ZSTD_COMPRESS;
183183

184-
private static final long ALL_SUPPORTED_MARIADB = FOUND_ROWS | LONG_FLAG | CONNECT_WITH_DB |
185-
NO_SCHEMA | COMPRESS | LOCAL_FILES | IGNORE_SPACE | PROTOCOL_41 | INTERACTIVE | SSL |
186-
TRANSACTIONS | SECURE_SALT | MULTI_STATEMENTS | MULTI_RESULTS | PS_MULTI_RESULTS | PLUGIN_AUTH |
187-
CONNECT_ATTRS | VAR_INT_SIZED_AUTH | SESSION_TRACK | DEPRECATE_EOF | ZSTD_COMPRESS |
188-
MARIADB_CLIENT_EXTENDED_TYPE_INFO;
189-
190184
/**
191185
* The default capabilities for a MySQL connection. It contains all client supported capabilities.
192186
*/
193187
public static final Capability DEFAULT = new Capability(ALL_SUPPORTED);
194188

195-
/**
196-
* The default capabilities for a MariaDB connection. It contains all client supported capabilities.
197-
*/
198-
public static final Capability DEFAULT_MARIADB = new Capability(ALL_SUPPORTED_MARIADB);
199-
200189
private final long bitmap;
201190

202191
/**

r2dbc-mysql/src/main/java/io/asyncer/r2dbc/mysql/message/server/DefinitionMetadataMessage.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -183,13 +183,8 @@ private static DefinitionMetadataMessage decode41(ByteBuf buf, ConnectionContext
183183

184184
String extendTypeInfo = null;
185185
if (context.getCapability().isMariaDb() && context.getCapability().isExtendedTypeInfo()) {
186-
buf.markReaderIndex();
187-
short extendedTypeInfoDataType = buf.readUnsignedByte();
188-
if (extendedTypeInfoDataType == 0 || extendedTypeInfoDataType == 1) {
189-
extendTypeInfo = readVarIntSizedString(buf, charset);
190-
} else {
191-
buf.resetReaderIndex();
192-
}
186+
buf.readUnsignedByte();
187+
extendTypeInfo = readVarIntSizedString(buf, charset);
193188
}
194189

195190
// Skip constant 0x0c encoded by var integer

r2dbc-mysql/src/test/java/io/asyncer/r2dbc/mysql/MariaDbIntegrationTestSupport.java

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ void returningGetRowUpdated() {
152152
@Test
153153
@EnabledIf("envIsMariaDb10_5_1")
154154
void returningExtendedTypeInfoJson() {
155-
complete(conn -> changeCapability(conn).createStatement("CREATE TEMPORARY TABLE test(" +
155+
complete(conn -> conn.createStatement("CREATE TEMPORARY TABLE test(" +
156156
"id INT NOT NULL AUTO_INCREMENT PRIMARY KEY, value JSON NOT NULL)")
157157
.execute()
158158
.flatMap(IntegrationTestSupport::extractRowsUpdated)
@@ -162,7 +162,7 @@ void returningExtendedTypeInfoJson() {
162162
.execute())
163163
.flatMap(result -> result.map(DataEntity::readExtendedTypeInfoResult))
164164
.collectList()
165-
.doOnNext(list -> assertThat(list.get(0)).isEqualTo(true))
165+
.doOnNext(list -> assertIfExtendedTypeInfoEnabled(conn, list))
166166
);
167167
}
168168

@@ -196,10 +196,13 @@ private static Mono<Void> assertWithoutCreatedAt(MySqlConnection conn, Mono<List
196196
.then();
197197
}
198198

199-
private static MySqlConnection changeCapability(MySqlConnection conn) {
200-
ConnectionContext ctxt = ((MySqlSimpleConnection) conn).context();
201-
ctxt.initHandshake(ctxt.getConnectionId(), ctxt.getServerVersion(), Capability.DEFAULT_MARIADB);
202-
return conn;
199+
private static void assertIfExtendedTypeInfoEnabled(MySqlConnection conn, List<Boolean> list) {
200+
boolean enabled = ((MySqlSimpleConnection)conn).context().getCapability().isExtendedTypeInfo();
201+
if (enabled) {
202+
assertThat(list.get(0)).isEqualTo(true);
203+
} else {
204+
assertThat(list.get(0)).isEqualTo(false);
205+
}
203206
}
204207

205208
private static final class DataEntity {

0 commit comments

Comments
 (0)