[Symfony] Fixed empty clients key (#199)

* [Symfony] Fixed empty clients key

* CS

Author: Nyholm

CHANGELOG.md

@@ -0,0 +1,16 @@
+# Change Log
+
+## 0.1.1
+
+### Added
+
+- Support for async-aws/core: ^0.2
+- Support for CloudFormation, Lambda and SNS
+
+### Fixed
+
+- Configuration bug where you specified `async_aws.client:` and nothing more
+
+## 0.1.0
+
+First version

DependencyInjection/Configuration.php

@@ -44,8 +44,12 @@ public function getConfigTreeBuilder()
         return $treeBuilder;
     }
 
-    private static function validateType(array $clients)
+    private static function validateType(?array $clients)
     {
+        if (null === $clients) {
+            return [];
+        }
+
         $awsServices = AwsPackagesProvider::getServiceNames();
         foreach ($clients as $name => $config) {
             if (\in_array($name, $awsServices)) {

Tests/Functional/BundleInitializationTest.php

@@ -75,6 +75,18 @@ public function testNotRegisterServices()
         self::assertFalse($container->has(SqsClient::class));
     }
 
+    public function testEmptyClientsKey()
+    {
+        $kernel = $this->createKernel();
+        $kernel->addConfigFile(__DIR__ . '/Resources/config/empty_clients_key.yaml');
+        $this->bootKernel();
+
+        $container = $this->getContainer();
+        self::assertTrue($container->has('async_aws.client.s3'));
+        self::assertTrue($container->has('async_aws.client.sqs'));
+        self::assertTrue($container->has(SqsClient::class));
+    }
+
     public function testNotRegisterSqs()
     {
         $kernel = $this->createKernel();

Tests/Functional/Resources/config/empty_clients_key.yaml

@@ -0,0 +1,9 @@
+framework:
+  router:
+    utf8: true
+
+async_aws:
+    config:
+        region: eu-central-1
+
+    clients:

composer.json

@@ -11,15 +11,15 @@
     "license": "MIT",
     "require": {
         "php": "^7.2.5",
-        "async-aws/core": "^0.1.0",
+        "async-aws/core": "^0.1 || ^0.2",
         "symfony/config": "^4.4 || ^5.0",
         "symfony/dependency-injection": "^4.4 || ^5.0",
         "symfony/http-kernel": "^4.4 || ^5.0"
     },
     "require-dev": {
-        "async-aws/s3": "^0.1",
-        "async-aws/ses": "^0.1",
-        "async-aws/sqs": "^0.1",
+        "async-aws/s3": "^0.1 || ^0.2",
+        "async-aws/ses": "^0.1 || ^0.2",
+        "async-aws/sqs": "^0.1 || ^0.2",
         "matthiasnoback/symfony-config-test": "^4.1",
         "nyholm/symfony-bundle-test": "^1.6.1"
     },