DateTimeInterface::ISO8601 Incompatibility with ISO8601 (#1576)

* Incompatibility DateTimeInterface::ISO8601

* Revert "Incompatibility DateTimeInterface::ISO8601"

This reverts commit 4b5264a.

* CodeGenerator DateTimeInterface::ATOM vs ISO8601

* Check timestampFormat Return

* Generate All

* Changelog fixed ATOM vs ISO8601

* iso8601 / timestampFormat

* Description of what is fixed

Author: ngourle

src/CodeGenerator/src/Generator/InputGenerator.php

@@ -562,6 +562,10 @@ private function stringify(string $variable, Member $member, string $part): stri
         switch ($shape->getType()) {
             case 'timestamp':
                 $format = strtoupper($shape->get('timestampFormat') ?? ('header' === $part ? 'rfc822' : 'iso8601'));
+                if ('ISO8601' === $format) {
+                    $format = 'ATOM';
+                }
+
                 if (!\defined('\DateTimeInterface::' . $format)) {
                     throw new \InvalidArgumentException('Constant "\DateTimeInterface::' . $format . '" does not exists.');
                 }

src/Service/S3/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## NOT RELEASED
 
+### Fixed
+
+- Fix the format of the `objectLockRetainUntilDate` field in requests
+
 ### Changed
 
 - Allow passing explicit null values for optional fields of input objects

src/Service/S3/src/Input/CopyObjectRequest.php

@@ -906,7 +906,7 @@ public function request(): Request
             $headers['x-amz-object-lock-mode'] = $this->objectLockMode;
         }
         if (null !== $this->objectLockRetainUntilDate) {
-            $headers['x-amz-object-lock-retain-until-date'] = $this->objectLockRetainUntilDate->format(\DateTimeInterface::ISO8601);
+            $headers['x-amz-object-lock-retain-until-date'] = $this->objectLockRetainUntilDate->format(\DateTimeInterface::ATOM);
         }
         if (null !== $this->objectLockLegalHoldStatus) {
             if (!ObjectLockLegalHoldStatus::exists($this->objectLockLegalHoldStatus)) {

src/Service/S3/src/Input/CreateMultipartUploadRequest.php

@@ -652,7 +652,7 @@ public function request(): Request
             $headers['x-amz-object-lock-mode'] = $this->objectLockMode;
         }
         if (null !== $this->objectLockRetainUntilDate) {
-            $headers['x-amz-object-lock-retain-until-date'] = $this->objectLockRetainUntilDate->format(\DateTimeInterface::ISO8601);
+            $headers['x-amz-object-lock-retain-until-date'] = $this->objectLockRetainUntilDate->format(\DateTimeInterface::ATOM);
         }
         if (null !== $this->objectLockLegalHoldStatus) {
             if (!ObjectLockLegalHoldStatus::exists($this->objectLockLegalHoldStatus)) {

src/Service/S3/src/Input/PutObjectRequest.php

@@ -851,7 +851,7 @@ public function request(): Request
             $headers['x-amz-object-lock-mode'] = $this->objectLockMode;
         }
         if (null !== $this->objectLockRetainUntilDate) {
-            $headers['x-amz-object-lock-retain-until-date'] = $this->objectLockRetainUntilDate->format(\DateTimeInterface::ISO8601);
+            $headers['x-amz-object-lock-retain-until-date'] = $this->objectLockRetainUntilDate->format(\DateTimeInterface::ATOM);
         }
         if (null !== $this->objectLockLegalHoldStatus) {
             if (!ObjectLockLegalHoldStatus::exists($this->objectLockLegalHoldStatus)) {