Upgrade phpstan (#1458)

* Upgrade phpstan

* Remove dead generated code

The isset check ensures that this value is not null or missing.

* Remove dead code

* Fix the case when calling the fixCs method

Author: stof

composer.json

@@ -30,7 +30,7 @@
         "nette/php-generator": "^3.6.4",
         "nette/utils": "^3.0",
         "nyholm/symfony-bundle-test": "^2.0",
-        "phpstan/phpstan": "1.6.0",
+        "phpstan/phpstan": "1.10.21",
         "psr/cache": "^1.0 || ^2.0 || ^3.0",
         "swaggest/json-diff": "^3.7",
         "symfony/cache": "^4.4 || ^5.0 || ^6.0 || ^7.0",

src/CodeGenerator/src/Command/GenerateCommand.php

@@ -295,7 +295,7 @@ private function generateService(SymfonyStyle $io, InputInterface $input, array
         $this->composerWriter->setRequirements($namespace, $this->generator->getUpdatedRequirements(), $input->getOption('all') && 'Sts' !== $serviceName);
 
         if (!$input->getOption('raw')) {
-            $this->fixCS($clientClass, $io);
+            $this->fixCs($clientClass, $io);
         }
 
         return $manifest;

src/CodeGenerator/src/Generator/InputGenerator.php

@@ -193,7 +193,7 @@ public function generate(Operation $operation): ClassName
                     $constructorBody .= strtr('
                         if (isset($input["NAME"])) {
                             $this->PROPERTY = [];
-                            foreach ($input["NAME"] ?? [] as $key => $item) {
+                            foreach ($input["NAME"] as $key => $item) {
                                 $this->PROPERTY[$key] = array_map([CLASS::class, "create"], $item);
                             }
                         }

src/Integration/Laravel/Cache/src/ServiceProvider.php

@@ -37,8 +37,8 @@ private function getClosure(): \Closure
         return \Closure::fromCallable(function ($app, array $config) {
             $clientConfig = [];
             if (isset($config['key']) && isset($config['secret'])) {
-                $clientConfig['accessKeyId'] = $config['key'] ?? null;
-                $clientConfig['accessKeySecret'] = $config['secret'] ?? null;
+                $clientConfig['accessKeyId'] = $config['key'];
+                $clientConfig['accessKeySecret'] = $config['secret'];
                 $clientConfig['sessionToken'] = $config['token'] ?? null;
             }
 

src/Integration/Laravel/Mail/src/ServiceProvider.php

@@ -23,8 +23,8 @@ public function createTransport(array $config): AsyncAwsSesTransport
     {
         $clientConfig = [];
         if (isset($config['key']) && isset($config['secret'])) {
-            $clientConfig['accessKeyId'] = $config['key'] ?? null;
-            $clientConfig['accessKeySecret'] = $config['secret'] ?? null;
+            $clientConfig['accessKeyId'] = $config['key'];
+            $clientConfig['accessKeySecret'] = $config['secret'];
             $clientConfig['sessionToken'] = $config['token'] ?? null;
         }
 

src/Integration/Laravel/Queue/src/Connector/AsyncAwsSqsConnector.php

@@ -18,8 +18,8 @@ public function connect(array $config)
     {
         $clientConfig = [];
         if (isset($config['key']) && isset($config['secret'])) {
-            $clientConfig['accessKeyId'] = $config['key'] ?? null;
-            $clientConfig['accessKeySecret'] = $config['secret'] ?? null;
+            $clientConfig['accessKeyId'] = $config['key'];
+            $clientConfig['accessKeySecret'] = $config['secret'];
             $clientConfig['sessionToken'] = $config['token'] ?? null;
         }
 

src/Service/DynamoDb/src/Input/BatchWriteItemInput.php

@@ -71,7 +71,7 @@ public function __construct(array $input = [])
     {
         if (isset($input['RequestItems'])) {
             $this->requestItems = [];
-            foreach ($input['RequestItems'] ?? [] as $key => $item) {
+            foreach ($input['RequestItems'] as $key => $item) {
                 $this->requestItems[$key] = array_map([WriteRequest::class, 'create'], $item);
             }
         }